ancientmarinerdev
  • Joined on 2022-10-03
ancientmarinerdev commented on pull request VoxeLibre/VoxeLibre#4025 2024-01-13 01:54:53 +01:00
Spawning: fix random weighted choice

Updated the test with more locations.

Overall looks good!

The things that stood out to me ([highlighted in yellow in the spreadsheet](https://docs.google.com/spreadsheets/d/1a2OkLpH

ancientmarinerdev commented on pull request VoxeLibre/VoxeLibre#4134 2024-01-11 21:54:19 +01:00
Fix mcl_shields is_blocking crash when object not found under player

Logic should be indented within an if block, but best to answer the comment from MrRar first.

ancientmarinerdev commented on issue VoxeLibre/VoxeLibre#4135 2024-01-09 18:44:45 +01:00
My one year anniversary since first contributions

You've come a long way, and it's been great having you around contributing. You've solved or helped to solve some problems that have been quite annoying for players so it's made a difference! That…

ancientmarinerdev commented on pull request VoxeLibre/VoxeLibre#4124 2024-01-08 20:32:10 +01:00
Nylium can be turned into netherrack

We have to be really careful with ABMs. They're already really heavy and sometimes don't run. We need to get the burden down. I'm hoping this doesn't lag hard every 8 seconds, and in particular on…

ancientmarinerdev commented on issue VoxeLibre/VoxeLibre#4086 2024-01-01 17:39:28 +01:00
players get hurt from falling into 1 block deep water from high places this shouldn't happen at all

I personally think after about 50-100 blocks, it's absolutely ridiculous and it isn't a mechanic I care much for. Can always just add multiple deep water blocks for deeper drops. For practical…

ancientmarinerdev commented on issue VoxeLibre/VoxeLibre#4086 2024-01-01 17:08:35 +01:00
players get hurt from falling into 1 block deep water from high places this shouldn't happen at all

I personally think about 100 blocks, it's absolutely ridiculous and it isn't a mechanic I care much for. Can always just add multiple deep water blocks for deeper drops.

ancientmarinerdev commented on pull request VoxeLibre/VoxeLibre#4097 2023-12-28 00:24:39 +01:00
accelerate non-moving carts on mcl_minecarts:golden_rail_on

I think it is called when the signal changes to "on". see: dd7d56a385/mods/ITEMS/REDSTONE/mesecons/int

ancientmarinerdev commented on issue VoxeLibre/VoxeLibre#4105 2023-12-28 00:22:55 +01:00
Missing dependency on mcl_sounds in various redstone mods

Duplicate of this:

MineClone2/MineClone2#2866

It's due to use using the mesecons namespace. We really need to consider getting off that with our own, but in…

ancientmarinerdev commented on pull request VoxeLibre/VoxeLibre#4095 2023-12-23 22:44:45 +01:00
br_pt_translation by JoseDouglas26

Our of curiosity. How did you do this @the-real-herowl . I'm assuming you didn't cherry-pick 99 commits? Removing the merge commit in an interactive rebase?

ancientmarinerdev commented on pull request VoxeLibre/VoxeLibre#4097 2023-12-23 22:09:18 +01:00
accelerate non-moving carts on mcl_minecarts:golden_rail_on

How frequently is this run?

ancientmarinerdev commented on pull request VoxeLibre/VoxeLibre#4097 2023-12-23 22:07:56 +01:00
accelerate non-moving carts on mcl_minecarts:golden_rail_on

I would put this out of the function and name it something like adjacent nodes. That way we only create these 5 tables, once. Call it something like ADJACENT_POS

ancientmarinerdev deleted branch bamboo_crash_fix from VoxeLibre/VoxeLibre 2023-12-20 22:28:21 +01:00
ancientmarinerdev closed issue VoxeLibre/VoxeLibre#4063 2023-12-20 22:28:14 +01:00
Crashes on German MineClone2 server
ancientmarinerdev pushed to master at VoxeLibre/VoxeLibre 2023-12-20 22:28:10 +01:00
5071855d00 Merge pull request 'Fix wrong argument when piston dig calls on_dignode callbacks (Credit: Cora)' (#4089) from bamboo_crash_fix into master
4cfd4ef6ce Fix wrong argument when piston dig calls on_dignode callbacks
Compare 2 commits »
ancientmarinerdev merged pull request VoxeLibre/VoxeLibre#4089 2023-12-20 22:28:09 +01:00
Fix wrong argument when piston dig calls on_dignode callbacks (Credit: Cora)
ancientmarinerdev commented on issue VoxeLibre/VoxeLibre#4057 2023-12-20 20:51:08 +01:00
Gameplay Improvement (1)

So that newly arrived people, and those who are already involved in the game, can immediately see what kind of help is needed, what work is a priority, and what is not so much. Old problems…

ancientmarinerdev opened issue VoxeLibre/VoxeLibre#4090 2023-12-20 18:18:18 +01:00
Initial object properties need to be set correctly to remove warning (minetest 5.8.0)
ancientmarinerdev commented on issue VoxeLibre/VoxeLibre#4034 2023-12-20 18:07:38 +01:00
Feature: seperate tables for spawning passive/hostile mobs in different dimensions

Primary one for me is by dimension. That way you can avoiding looking for lava spawn in overworld or water in nether etc. Passives and hostiles, I'm also open to as you could eventually move the…

ancientmarinerdev created pull request VoxeLibre/VoxeLibre#4089 2023-12-20 17:56:04 +01:00
Fix wrong argument when piston dig calls on_dignode callbacks (Credit: Cora)
ancientmarinerdev pushed to bamboo_crash_fix at VoxeLibre/VoxeLibre 2023-12-20 17:55:11 +01:00
4cfd4ef6ce Fix wrong argument when piston dig calls on_dignode callbacks