the-real-herowl
  • Joined on 2023-08-07
the-real-herowl commented on pull request VoxeLibre/VoxeLibre#3980 2023-10-27 06:04:37 +02:00
hopper reimplementation

This is not a boolean value, so no need for the ~= nil – just if dst_def._mcl_hoppers_on_try_push then will suffice.

the-real-herowl commented on pull request VoxeLibre/VoxeLibre#3980 2023-10-27 06:04:36 +02:00
hopper reimplementation

Same issue as furnaces. Make a function and reuse it.

the-real-herowl commented on pull request VoxeLibre/VoxeLibre#3980 2023-10-27 06:04:36 +02:00
hopper reimplementation

...this too.

the-real-herowl commented on pull request VoxeLibre/VoxeLibre#3980 2023-10-27 06:04:35 +02:00
hopper reimplementation

See smoker.

the-real-herowl commented on pull request VoxeLibre/VoxeLibre#3980 2023-10-27 06:04:34 +02:00
hopper reimplementation

See smoker.

the-real-herowl commented on pull request VoxeLibre/VoxeLibre#3980 2023-10-27 06:04:34 +02:00
hopper reimplementation

See smoker.

the-real-herowl commented on pull request VoxeLibre/VoxeLibre#3980 2023-10-27 06:04:34 +02:00
hopper reimplementation

See smoker.

the-real-herowl commented on pull request VoxeLibre/VoxeLibre#3980 2023-10-27 06:04:33 +02:00
hopper reimplementation

Code duplicated (multiplicated considering furnance and blast furnance). Make a reusable function outside the definition and add it to both definitions. You can define that function in mcl_furnaces, since mcl_smoker depends on that anyway (and mcl_blast_furnace does too).

the-real-herowl commented on pull request VoxeLibre/VoxeLibre#3980 2023-10-27 06:04:33 +02:00
hopper reimplementation

Code duplicated. See above.

the-real-herowl pushed to potions_api_redo at the-real-herowl/MineClone2 2023-10-27 05:12:40 +02:00
79bc215f5f Creative inventory using new potions API
91223a9e63 Added new potion tooltip handling
4f87bbcfea Added new potions registering API
a9a79dbb6c Translatable effect names and cleanup
84b6d56103 Arabic-to-Roman converter redo
Compare 10 commits »
the-real-herowl deleted branch slime_light_fix from VoxeLibre/VoxeLibre 2023-10-23 07:32:39 +02:00
the-real-herowl pushed to master at VoxeLibre/VoxeLibre 2023-10-23 07:32:24 +02:00
4fcd1ae541 Fix slime spawn crash (#3977)
the-real-herowl closed issue VoxeLibre/VoxeLibre#3975 2023-10-23 07:32:23 +02:00
slime spawn crash the server when light is nil
the-real-herowl merged pull request VoxeLibre/VoxeLibre#3977 2023-10-23 07:32:20 +02:00
Fix slime spawn crash
the-real-herowl approved VoxeLibre/VoxeLibre#3977 2023-10-23 07:31:16 +02:00
Fix slime spawn crash
the-real-herowl commented on issue VoxeLibre/VoxeLibre#3955 2023-10-22 21:26:09 +02:00
Shield appears in third-person view when being used

This is P4 because this should be fixed along with a shields redo and shields have more problems than this.

the-real-herowl commented on issue VoxeLibre/VoxeLibre#3976 2023-10-22 21:14:28 +02:00
mcl_hunger crash the server when a fake player eat food items

Quoting OgelGames:

The issue is because there's only a useless is_player() check: (which returns true for fake players too)

https://git.minetest.land/MineClone2/MineClone2/src/bra

the-real-herowl commented on issue VoxeLibre/VoxeLibre#3976 2023-10-22 20:56:50 +02:00
mcl_hunger crash the server when a fake player eat food items

@pepebotella You should let https://github.com/mt-mods/pipeworks know. That way they can check their code and make updates. nonfreegithub seems to do updates for the mod.

I am…

the-real-herowl commented on issue VoxeLibre/VoxeLibre#3975 2023-10-22 19:33:02 +02:00
slime spawn crash the server when light is nil

Also @Codiac again

the-real-herowl commented on issue VoxeLibre/VoxeLibre#3975 2023-10-22 19:32:38 +02:00
slime spawn crash the server when light is nil

Okay - question... Are you using the very latest master snapshot? Like, from an hour ago? And, if so, is it with or without the Minecraft 1.18+ light levels enabled?

also, @Codiac…