Now reloaded arrows do disappear when collected, but don't appear in the inventory and no sound is played (in survival). Also I think no pickup sound is played ever in creative.
Got one more issue. Arrows (shot in survival in my testing) stuck in the ground can't be picked up anymore after reloading a world. Weird stuff happens with other projectiles too, eg. spears stuck…
Somebody should close this issue or the old one at some point, or just fix and close them both then. Not sure.
Got the crash mentioned in #4703 here too:
AsyncErr: Lua: Runtime error from mod '??' in callback luaentity_Step(): ...wik/.minetest/games/mcl2-dev/mods/CORE/mcl_util/init.lua:735: bad…
AsyncErr: Lua: Runtime error from mod '??' in callback luaentity_Step(): ...wik/.minetest/games/mcl2-dev/mods/CORE/mcl_util/init.lua:735: bad argument #1 to 'get_player_by_name' (string…
Arrows stuck in walls (unlike those stuck in floors) misbehave seriously, dealing damage when picked up.
While throwing eggs (either after spawning a chicken or hitting a chicken with an egg):
AsyncErr: Lua: Runtime error from mod '??' in callback luaentity_Step(): ...inetest/games/mcl2-dev/mods…
BTW by removing debug code I meant random log calls and not blocks placed behind a DEBUG flag. Not sure how useful that particular one was though.
Perhaps, but I think this should still be possible to fix. This is actually really annoying and quite noticeable too, to the point that I noticed it in my first ten minutes playing.
If…
-- Don't allow players to pick up arrows stuck in them or other players
Why though 🙃
(I do get why, but could be an interesting possibility to allow that one day, along with lingering…
Task to be done before merge: check whether all debug code is removed (logging mostly).
Re splash potion "grace distance": does it still allow hitting yourself when you actually want to by throwing it straight under your feet (or up to hit your head)?
@teknomunk Are you sure it should use deal_damage() directly and not punch()? The latter should technically handle knockback while the former does not.
Is your fork the
origin
or is it the official repo?The fork is taken from this repo, it is not the original files that I uploaded.
Post the outcome of git remote -v
@the-real-herowl I'm going to start checking this against spears in #4261 WIP: New weapons.
Regarding spears, I'm mainly concerned about whether my rotation manipulation to allow making…
I don't think sky color has anything to do with block lighting (param1).