Shield appears in third-person view when being used #3955

New Issue

DokoDemoCrafter1999 · 2023-09-30T02:48:17+02:00

DokoDemoCrafter1999 commented

2023-09-30 02:48:17 +02:00

MineClone2 version: latest commit (at time of writing is a620d24ec8)

What happened?

Shield shows up in camera despite being in third-person.

What should happen:

Shield shouldn't appear in camera if in third-person

Steps to reproduce

Get a shield
Go into third-person (Press C)
Use shield (It appears in your view, even though that doesn't make sense)

MineClone2 version: latest commit (at time of writing is a620d24ec848d6a7e20a43f462bcbf09ccca683c) ### What happened? Shield shows up in camera despite being in third-person. ### What should happen: Shield shouldn't appear in camera if in third-person ### Steps to reproduce Get a shield Go into third-person (Press C) Use shield (It appears in your view, even though that doesn't make sense)

635 KiB

931 KiB

586 KiB

634 KiB

1012 KiB

DokoDemoCrafter1999 added the

bug

unconfirmed

labels 2023-09-30 02:48:17 +02:00

Michieal commented

2023-09-30 23:16:09 +02:00

You are very correct, in gameplay, it shouldn't be. Yet, the shield (and its usage) has been shoehorned in, because minetest doesn't allow dual wielding yet. It used to, but there were issues with it, so their devs removed it. Until that is changed, it's going to be hacky at best. But, it's a needed gameplay feature. (It was "hacked" in, which is why it acts... oddly, rather than a smooth usage. I'm sure you have noticed, when trying to block attacks.)

To "fix" this bug, I am assuming that the shield addon/module would need to be removed... or at least heavily rewritten. As I understand it, the Shield image gets written to be displayed as part of the HUD, so that you can see it when it's used. Hence, it being in the "camera" (in the HUD) when used.

To be fair, here, this is a known issue.

You are very correct, in gameplay, it shouldn't be. Yet, the shield (and its usage) has been shoehorned in, because minetest doesn't allow dual wielding yet. It used to, but there were issues with it, so their devs removed it. Until that is changed, it's going to be hacky at best. But, it's a needed gameplay feature. (It was "hacked" in, which is why it acts... oddly, rather than a smooth usage. I'm sure you have noticed, when trying to block attacks.) To "fix" this bug, I am assuming that the shield addon/module would need to be removed... or at least heavily rewritten. As I understand it, the Shield image gets written to be displayed as part of the HUD, so that you can see it when it's used. Hence, it being in the "camera" (in the HUD) when used. To be fair, here, this is a known issue.

the-real-herowl added

looking for contributor

player

and removed

unconfirmed

labels 2023-10-22 21:25:10 +02:00

the-real-herowl commented

2023-10-22 21:26:09 +02:00

This is P4 because this should be fixed along with a shields redo and shields have more problems than this.

🚀 1

Michieal commented

2023-10-23 21:36:12 +02:00

Shields have had serious issues since minetest stopped supporting dual wield.
So, yeah, it's going to need a major overhaul. Up until now, though, it's been marked as "Needs engine change" due to the fact that it had to be hacked in.

The reported bug could be fixed, by copying parts of the player arm code... but, that still won't fix the other issues with shields.

Shields have had serious issues since minetest stopped supporting dual wield. So, yeah, it's going to need a major overhaul. Up until now, though, it's been marked as "Needs engine change" due to the fact that it had to be hacked in. The reported bug could be fixed, by copying parts of the player arm code... but, that still won't fix the other issues with shields.

the-real-herowl referenced this issue

2024-06-02 15:09:35 +02:00

Improper Eating Animation in 3rd person view #4360

teknomunk referenced this issue

2024-06-12 23:03:01 +02:00

Client-side mod? #4428

Sign in to join this conversation.