slime spawn crash the server when light is nil #3975

New Issue

pepebotella · 2023-10-22T17:33:25+02:00

pepebotella commented

2023-10-22 17:33:25 +02:00

MineClone2 version:

master branch commit f941817c39

What happened?

it crash when light value is nil

ERROR[Main]: ServerError: AsyncErr: Lua: Runtime error from mod '' in callback environment_Step(): ...es/MineClone2/mods/ENTITIES/mobs_mc/slime+magma_cube.lua:171: attempt to compare number with nil
ERROR[Main]: stack traceback:
ERROR[Main]: 	...es/MineClone2/mods/ENTITIES/mobs_mc/slime+magma_cube.lua:171: in function 'spawn_check'
ERROR[Main]: 	.../../games/MineClone2/mods/ENTITIES/mcl_mobs/spawning.lua:1030: in function 'spawn_a_mob'
ERROR[Main]: 	.../../games/MineClone2/mods/ENTITIES/mcl_mobs/spawning.lua:1125: in function <.../../games/MineClone2/mods/ENTITIES/mcl_mobs/spawning.lua:1101>
ERROR[Main]: 	...rt1/Minetest/minetest/bin/../builtin/common/register.lua:26: in function <...rt1/Minetest/minetest/bin/../builtin/common/register.lua:12>

MineClone2 version: master branch commit f941817c390d0b607b9d173ddad3db0e58aad999 ### What happened? it crash when light value is `nil` ``` ERROR[Main]: ServerError: AsyncErr: Lua: Runtime error from mod '' in callback environment_Step(): ...es/MineClone2/mods/ENTITIES/mobs_mc/slime+magma_cube.lua:171: attempt to compare number with nil ERROR[Main]: stack traceback: ERROR[Main]: ...es/MineClone2/mods/ENTITIES/mobs_mc/slime+magma_cube.lua:171: in function 'spawn_check' ERROR[Main]: .../../games/MineClone2/mods/ENTITIES/mcl_mobs/spawning.lua:1030: in function 'spawn_a_mob' ERROR[Main]: .../../games/MineClone2/mods/ENTITIES/mcl_mobs/spawning.lua:1125: in function <.../../games/MineClone2/mods/ENTITIES/mcl_mobs/spawning.lua:1101> ERROR[Main]: ...rt1/Minetest/minetest/bin/../builtin/common/register.lua:26: in function <...rt1/Minetest/minetest/bin/../builtin/common/register.lua:12> ```

pepebotella added the

bug

unconfirmed

labels 2023-10-22 17:33:25 +02:00

Michieal commented

2023-10-22 19:20:11 +02:00

Okay - question... Are you using the very latest master snapshot? Like, from an hour ago?
And, if so, is it with or without the Minecraft 1.18+ light levels enabled?

also, @Codiac (because reasons)

Okay - question... Are you using the very latest master snapshot? Like, from an hour ago? And, if so, is it with or without the Minecraft 1.18+ light levels enabled? also, @Codiac (because reasons)

the-real-herowl commented

2023-10-22 19:32:37 +02:00

Okay - question... Are you using the very latest master snapshot? Like, from an hour ago?
And, if so, is it with or without the Minecraft 1.18+ light levels enabled?

also, @Codiac (because reasons)

It seems it is the latest master, look at the commit. Yeah, this one will be very interesting.

> Okay - question... Are you using the very latest master snapshot? Like, from an hour ago? > And, if so, is it with or without the Minecraft 1.18+ light levels enabled? > > > also, @Codiac (because reasons) It seems it is the latest master, look at the commit. Yeah, this one will be very interesting.

the-real-herowl commented

2023-10-22 19:33:02 +02:00

Also @Codiac again

the-real-herowl added the

#P1 CRITICAL

label 2023-10-22 19:34:07 +02:00

the-real-herowl added the

gameplay

mobs

needs more information

Testing / Retest

looking for contributor

environment

labels 2023-10-22 19:35:55 +02:00

Michieal commented

2023-10-22 19:48:45 +02:00

It seems it is the latest master, look at the commit. Yeah, this one will be very interesting.

Ahh, okay. You're right.
So, the question then remains -- Was the new light levels setting enabled or no?

> It seems it is the latest master, look at the commit. Yeah, this one will be very interesting. Ahh, okay. You're right. So, the question then remains -- Was the new light levels setting enabled or no?

ancientmarinerdev commented

2023-10-23 01:21:47 +02:00

local art_light = minetest.get_artificial_light(my_node.param1)

seems to be zero.

I'm wondering if the node in question doesn't have paramtype = "light" and whether this isn't guaranteed to always return a value, so the spawn check needs to take this into consideration.

https://github.com/minetest/minetest/blob/master/doc/lua_api.md

` local art_light = minetest.get_artificial_light(my_node.param1)` seems to be zero. I'm wondering if the node in question doesn't have paramtype = "light" and whether this isn't guaranteed to always return a value, so the spawn check needs to take this into consideration. https://github.com/minetest/minetest/blob/master/doc/lua_api.md

Screenshot_20231023_001936.png

36 KiB

Codiac commented

2023-10-23 01:54:41 +02:00

I'm wondering if the node in question doesn't have paramtype = "light" and whether this isn't guaranteed to always return a value, so the spawn check needs to take this into consideration.

These would seem the most likely cause. The question then becomes what to do about the light check for that node?

You could: pass the check, fail the check, use gotten_light is the same check. Thoughts?

> I'm wondering if the node in question doesn't have paramtype = "light" and whether this isn't guaranteed to always return a value, so the spawn check needs to take this into consideration. These would seem the most likely cause. The question then becomes what to do about the light check for that node? You could: pass the check, fail the check, use gotten_light is the same check. Thoughts?

Codiac commented

2023-10-23 02:06:39 +02:00

Actually looks like git cherry pick fail on my part; it's probably because the declaration of swamp_light_max wasn't moved above the new function.

Codiac referenced a pull request that will close this issue

2023-10-23 02:27:27 +02:00

Fix slime spawn crash #3977

the-real-herowl closed this issue

2023-10-23 07:32:23 +02:00

the-real-herowl referenced this issue from a commit

2023-10-23 07:32:24 +02:00

Fix slime spawn crash (#3977)

the-real-herowl removed the