Commit Graph

10926 Commits

Author SHA1 Message Date
teknomunk c09607d0b9 Address review comments 2024-11-02 21:28:11 +01:00
teknomunk 113e40b9e2 Only show particles if bone meal is consumed, don't continue testing positions if bonemeal was used on the first check position 2024-11-02 21:28:11 +01:00
teknomunk 91eced01c2 Show particles regardless of success 2024-11-02 21:28:11 +01:00
teknomunk c2faca7ca2 Quick patch to get cherry saplings growing pending inclusing of a proper tree API 2024-11-02 21:28:11 +01:00
teknomunk 9beac4a3e4 Remove check with mcl_core.check_vines_supported for twisted and crimson vines 2024-11-02 21:28:11 +01:00
teknomunk 875d2c7a59 Address review comments on mcl_util.trace_nodes 2024-11-02 21:28:11 +01:00
teknomunk d8abc79948 Add growth limits to crimson/twisting vines 2024-11-02 21:28:11 +01:00
teknomunk 2bbeb502e3 Add mcl_util.trace_node(), rewrite bamboo growth code to fix bone meal growth 2024-11-02 21:28:11 +01:00
teknomunk 8d9c3d4bd9 Prevent bonemealing grass from making flowers and also bonemealing the block above the grass 2024-11-02 21:28:11 +01:00
teknomunk 3810f7805e Fix crash when bonemealing weaping and twisting vines, fix weaping vine growth 2024-11-02 21:28:11 +01:00
teknomunk 00f46f3dfb Reorder functions to prevent crash 2024-11-02 21:28:11 +01:00
teknomunk 9d421bac11 Remove TODO pending future discussions, revert timer change in composter code 2024-11-02 21:28:11 +01:00
teknomunk 8b122bf7de Make composter_progress_chance local, as it is not used anywhere except in mcl_composters 2024-11-02 21:28:11 +01:00
teknomunk 064a3419c2 Fix typo that prevented bone mealing pumpkin plants 2024-11-02 21:28:11 +01:00
teknomunk 5a0bab8a26 Check both above and below in pointed_thing for bonemealing (and pass thru the position as .under), make crimson vines and twisting vines compostable by rightclicking on the composter 2024-11-02 21:28:11 +01:00
teknomunk 71b9ca4fdc Fix crash at one more spot 2024-11-02 21:28:11 +01:00
teknomunk 0df4da7c56 Fix crashes when using bonemeal on nether nodes 2024-11-02 21:28:11 +01:00
teknomunk 31c50452ce Change _mcl_on_bonemealing to _on_bone_meal, update API.md to reflect this 2024-11-02 21:28:11 +01:00
teknomunk 5d849ecabd Fix mods/ITEMS/mcl_composters/locale/mcl_composters.ru.tr 2024-11-02 21:28:11 +01:00
teknomunk 913d808a3f Update mod authors, remove a TODO 2024-11-02 21:28:11 +01:00
teknomunk 3b576576ae Remove bone to bone meal recipe from mcl_dye as it now resides in mcl_bone_meal 2024-11-02 21:28:11 +01:00
teknomunk 684748eb0f Modify backtrace listing to use minetest.log 2024-11-02 21:28:11 +01:00
teknomunk 2583829ca5 Fix localization errors 2024-11-02 21:28:11 +01:00
teknomunk 4eb78d28fe Only consume bone meal if a _mcl_on_bonemealing callback is defined or the legacy API returns true, convert vines to use new bonemeal API 2024-11-02 21:28:11 +01:00
teknomunk e4c07b0c6e Fix localization except mcl_composters.ru.tr 2024-11-02 21:28:11 +01:00
teknomunk 4a9f59c168 Enable bamboo bonemealing despite rightclick handling strangeness 2024-11-02 21:28:11 +01:00
teknomunk fbd166392a Rename localization files 2024-11-02 21:28:11 +01:00
teknomunk 7ef1624b2b Add untested bonemeal mod compatibility shim 2024-11-02 21:28:11 +01:00
teknomunk 8800f02bac Move commented out bamboo bone meal code into mods/ITEMS/mcl_bamboo/bamboo_base.lua 2024-11-02 21:28:11 +01:00
teknomunk e225d7f6a1 Add new API call mcl_bone_meal.use_bone_meal and use this to remove duplicate code, update mcl_farming:sweet_berries to use bonemeal API, add stub for bonemeal mod compatibility 2024-11-02 21:28:11 +01:00
teknomunk b8abe6b8b7 Update mcl_crimson to use bonemealing API 2024-11-02 21:28:11 +01:00
teknomunk 4df1139c0e Remove bone meal definition in mcl_dye, make textures in mcl_cocoas match master branch 2024-11-02 21:28:11 +01:00
teknomunk 5c09efdfcc Display call stack to assist in removing deprecated function calls 2024-11-02 21:28:11 +01:00
teknomunk d762af8b2f Fix mod dependencies 2024-11-02 21:28:11 +01:00
kabou 1468da0c67 Remove color specifications from bone meal.
* The bone meal craftitem definition still had color specifications
  from its past as a dye substitute.  These can be removed now.
* Also remove default stack_max setting.
2024-11-02 21:28:11 +01:00
kabou 0dbfd46e53 Remove color specifications from cocoa beans.
* The cocoa beans craftitem definition still had color specifications
  from its past as a dye substitute.  These can be removed now.
2024-11-02 21:28:11 +01:00
kabou d7be908b74 Also generate double grass when bonemealing grass blocks. 2024-11-02 21:28:11 +01:00
kabou 7a59db88a1 Remove expired bone meal API.md from mcl_dye. 2024-11-02 21:28:11 +01:00
kabou 13c4b44c47 Bonemealing mechanics bugfix.
When applying bonemeal to eg. farm crops, these have a chance to grow in
response to the application of bone meal. When a node can be bonemealed, the
applied bone meal item should always be spent after using it, regardless of
the results.  Currently this does not work correctly, if the result of
bonemealing has no effect on the node, the used bone meal item is not spent.

This commit fixes the behavior of the bone meal item to always be taken when
used on a node that defines a `_mcl_on_bonemealing()` callback.

The nodes that implement the callback imay use the handler's return value
only to signal if the bonemealing was succesful, not to signal if it was at
all possible.  For this reason, some nodes need to be made more strictly
conforming to the API.

* Always take the used bone meal item (if user is not in creative mode),
  regardless of whether the bonemealed node's handler returned `true`.
* Make dispensers spawn particles after succesful bonemealing.
* Trivial comment fix.
* Ripe cocoa pod cannot be bonemealed.
* Update API.md to describe the stricter API semantics.
2024-11-02 21:28:11 +01:00
kabou c4bdb19353 Improve mcl_bone_meal fr translations.
* Changed the wording after suggestions by AFCMS.
2024-11-02 21:28:11 +01:00
kabou 4c12334337 Add missing es translation to mcl_bone_meal. 2024-11-02 21:28:11 +01:00
kabou 6cae8d17cc Move cocoa beans item to mcl_cocoas.
* Add `mcl_cocoas:coca_beans` craftitem to mcl_cocoas.
* Remove `mcl_dye:brown` craftitem from mcl_dye.
* Move cocoa beans translations from mcl_dye to mcl_cocoas.
* Add `mcl_dye:brown` alias for `mcl_cocoas:cocoa_beans` to
  mcl_dye.
* Abstract cocoa pod node registration into a loop.
* Update chocolate cookies crafting recipe in mcl_farming.
2024-11-02 21:28:11 +01:00
kabou 6165307a63 Remove stray line from locale template.
* Removed a line from the mcl_bone_meal locale template that had by
  accident put there during the bone meal <-> white dye changes.
2024-11-02 21:28:11 +01:00
kabou b81e2761db Use better override mechanism.
* Use `minetest.override_item()` instead of re-registering the node with
  ":" prefixed to its name.  Thanks again to wsor for mentioning this.
2024-11-02 21:28:11 +01:00
kabou 621de9fea3 Add more particles when bonemealing grass.
* Bonemealing dirt_with_grass spawns new growth over a wide area, so it
  looks better if we spawn a few more extra bone meal particles.
* Update mod.conf depends to mcl_bone_meal.
2024-11-02 21:28:11 +01:00
kabou c09eab6b39 Update to new bone meal API.
* Update to use new mcl_bone_meal API:
* Use new bone meal item and remove related comment.
* Update mod depends in mod.conf
* Spelling fixes: s/bonemeal/bone meal/g
2024-11-02 21:28:11 +01:00
kabou a7b3a6dac3 Add mcl_bone_meal.
* New mod mcl_bone_meal, replacing bone meal functionality previously
  held in mcl_dye.
* Improve bonemealing API using callbacks in the nodes that support
  bonemealing.
* Rename bone meal item to `"mcl_bone_meal:bone_meal"` and updated its
  crafting recipe.
* Implement legacy compatibility for older bone meal API.
* Remove all non dye-related bone meal code, texture and translations from
  mcl_dye.
* Add legacy compatibility shims to mcl_dye that refer to mcl_bone_meal.
* Add an alias for "mcl_dye:white" to keep mcl_dye and its API working
  uniterrupted.
* Update mod depends in mcl_dye mod.conf.
2024-11-02 21:28:11 +01:00
kabou df27697d46 Add bonemealing callback for fern.
* Adds a _mcl_on_bonemealing callback to fern.
2024-11-02 21:28:11 +01:00
kabou ec6f247c07 Add bonemealing callback for tall grass.
* Adds a _mcl_on_bonemealing callback to tall grass.
2024-11-02 21:28:11 +01:00
kabou 4b776f3e23 Add bonemealing callback for double flowers.
* Adds a _mcl_on_bonemealing callback to the double flowers.
2024-11-02 21:28:11 +01:00