- pos: (26.8, 8.3, 33.1)
- https://codeberg.org/rudzik8
-
Siberian 15yo Minetest player and modder, MineClone 2 contributor
#nowar
- Joined on
2022-02-18
My only concern is this line. Wouldn't it be more rational to check for the entity's name sooner? Like, we have no reason to perform the former two checks if the latter will most of the time turn out to be false anyway. Up to discussion, of course.
Tested; villagers have lost their abnormal eating behaviors. No code-wise problems found.
This issue is blocked by #4221, that's what I was trying to set through Gitea's confusing interface.
I'd love to reproduce this, but I don't know how any of you run mods that depend on default on VoxeLibre. Is it through cora's Default Lite?
Good job on the mouth. As for the heads, I think we should leave fixing its bugs and quirks for a different PR. The solution you propose sounds fine enough to me.
Tested; does what expected, improves code readability. LGTM
I suggest that you prefix all new mods with vl_ instead of mcl_, it's the practice we've been following since the rename.
I've noticed this is the same as mobs_mc.shears_wear. Is there anything we could do with that? Like, what about moving that to a different mod/namespace (e.g. mcl_vars) and use it here?