Mikita Wiśniewski rudzik8
  • pos: (26.8, 8.3, 33.1)
  • https://codeberg.org/rudzik8
  • Siberian 15yo Minetest player and modder, MineClone 2 contributor

    #nowar

  • Joined on 2022-02-18
rudzik8 pushed to mcl_chests_redo at VoxeLibre/VoxeLibre 2024-06-28 14:51:06 +02:00
06d79b4c1f Fix ender chests rotate crash
rudzik8 pushed to mcl_chests_redo at VoxeLibre/VoxeLibre 2024-06-28 14:43:28 +02:00
5e1719ca04 Remove nil fields from trapped chest definition
rudzik8 pushed to mcl_chests_redo at VoxeLibre/VoxeLibre 2024-06-28 14:36:55 +02:00
9a6d5feb56 Fix typos in API.md
rudzik8 created pull request VoxeLibre/VoxeLibre#4469 2024-06-28 09:58:11 +02:00
Improve acacia and birch plank textures
rudzik8 pushed to improve_planks at VoxeLibre/VoxeLibre 2024-06-28 09:53:08 +02:00
b7667191e3 Improve acacia and birch plank textures
rudzik8 created branch improve_planks in VoxeLibre/VoxeLibre 2024-06-28 09:53:08 +02:00
rudzik8 commented on pull request VoxeLibre/VoxeLibre#4466 2024-06-27 16:10:07 +02:00
More randomness for slime chunks

@rudzik8, updated. Please let me know whether I should de-localize these functions.

First:

image

Second, after reading through…

rudzik8 pushed to mcl_chests_redo at VoxeLibre/VoxeLibre 2024-06-27 16:06:35 +02:00
9ac4d77a4f Resolve teknomunk's comments
rudzik8 suggested changes for VoxeLibre/VoxeLibre#4466 2024-06-27 05:26:36 +02:00
More randomness for slime chunks

Here's your review.

rudzik8 commented on pull request VoxeLibre/VoxeLibre#4466 2024-06-27 05:26:36 +02:00
More randomness for slime chunks

Reduce all of these settings to from mcl_mobs_slime_... to slime_... (and don't forget to update the .lua file for that). Explanation:

rudzik8 commented on pull request VoxeLibre/VoxeLibre#4466 2024-06-27 05:26:36 +02:00
More randomness for slime chunks

Why localize these functions if you're already using them unlocalized a few lines above (when handling settings)?

rudzik8 commented on pull request VoxeLibre/VoxeLibre#4466 2024-06-27 05:26:36 +02:00
More randomness for slime chunks

So now you're getting an integer value through get_bool, with true as the default value. O_o

rudzik8 commented on pull request VoxeLibre/VoxeLibre#4466 2024-06-27 05:26:36 +02:00
More randomness for slime chunks
  1. Getting boolean values through get method is... bizarre.
rudzik8 commented on pull request VoxeLibre/VoxeLibre#4466 2024-06-27 04:50:32 +02:00
More randomness for slime chunks

Fixed the typo, thanks.

Next time you fix something, please mark the conversation as 'Resolved'.

rudzik8 commented on pull request VoxeLibre/VoxeLibre#4280 2024-06-27 04:47:26 +02:00
New mcl_copper
rudzik8 closed pull request VoxeLibre/VoxeLibre#4292 2024-06-27 04:09:38 +02:00
Update mods/ENVIRONMENT/mcl_weather/skycolor.lua
rudzik8 commented on pull request VoxeLibre/VoxeLibre#4292 2024-06-27 04:09:38 +02:00
Update mods/ENVIRONMENT/mcl_weather/skycolor.lua

Closed in favor of #4338.

rudzik8 commented on pull request VoxeLibre/VoxeLibre#4280 2024-06-26 15:56:53 +02:00
New mcl_copper

I'll try making some textures soon.

rudzik8 commented on pull request VoxeLibre/VoxeLibre#4280 2024-06-26 15:05:39 +02:00
New mcl_copper

The original code is already like this.

Problem also with the original code.

You don't have to be defensive about it. Even though I'm using "you", I don't treat code personally (as in…

rudzik8 approved VoxeLibre/VoxeLibre#4265 2024-06-26 14:50:17 +02:00
Add persistence to XP Orbs

Previous review has been fully resolved. LGTM