ancientmarinerdev
  • Joined on 2022-10-03
ancientmarinerdev commented on pull request VoxeLibre/VoxeLibre#4421 2024-06-09 21:04:52 +02:00
Prevent mob conversion code from crashing

I feel we should check set pos in a variable and check it first. If the entity is yet to load, it won't have a position and cannot use that position to create it. Usually checking a pos is a good way to see if an entity is there. Same with checking velocity etc. to try and get the actual object.

ancientmarinerdev commented on issue VoxeLibre/VoxeLibre#938 2024-06-09 13:24:53 +02:00
Implement leaf decay like in minecraft

I think the question is whether the node has been converted to an _orphan node. If it hasn't, it's probably on us and our logic. If it has, the ABM probably ain't doing great.

ancientmarinerdev commented on issue VoxeLibre/VoxeLibre#2564 2024-06-08 22:47:33 +02:00
[core] implement API alternatives for ABMs, nodetimers

On the topic of ABM's though, if we want to improve things, we could potentially make them more frequent with less chance. So if for example, it runs on every node every 10s, making it run on…

ancientmarinerdev commented on issue VoxeLibre/VoxeLibre#4417 2024-06-08 22:37:28 +02:00
Fire in distance never extinguishes

In minetest engine, each 16x16x16 map blocks can be in one of four states:

  1. Loaded and ABMs running
  2. Loaded without running ABMs
  3. Emerging (Loading from disk or generating) …
ancientmarinerdev commented on issue VoxeLibre/VoxeLibre#4417 2024-06-08 22:14:12 +02:00
Fire in distance never extinguishes

This should be investigated as part of VoxeLibre/VoxeLibre#4304. This may require a feature as described in VoxeLibre/VoxeLibre#25

ancientmarinerdev commented on issue VoxeLibre/VoxeLibre#2564 2024-06-08 22:10:19 +02:00
[core] implement API alternatives for ABMs, nodetimers

I would caution against use of timers. I recently unpicked it from kelp. Basically it used 20% of the CPU because it avoided ABM's. The code was complex, messy, and worse performing than the abm's…

ancientmarinerdev commented on issue VoxeLibre/VoxeLibre#1288 2024-06-07 01:47:48 +02:00
Mapgen warnings

Deprecation to me means this is going to break in the future. We're 3 years in the future, so it's something that is worth doing for the mapgen update.

ancientmarinerdev commented on issue VoxeLibre/VoxeLibre#334 2024-06-06 19:44:23 +02:00
Pixel Perfection cleanup

I would second closing it. It's not official for a long time. It's the pack of last resort if we cannot create our own art and that somehow the art we are missing in PP isn't derivative or a…

ancientmarinerdev commented on issue VoxeLibre/VoxeLibre#4406 2024-06-05 23:19:09 +02:00
Zombie piglins spawned from eggs are passive, not neutral

I think for some reason mobs spawned from eggs are tamed.

ancientmarinerdev commented on issue VoxeLibre/VoxeLibre#3358 2024-06-05 16:31:47 +02:00
bug boat obsidian lava

It should sink in water, but maybe a boat that could be used on lava could make sense?

That's a point, but are you going to break this to the striders? Their whole purpose in life could come…

ancientmarinerdev commented on issue VoxeLibre/VoxeLibre#4401 2024-06-05 16:30:03 +02:00
Anvils which break while falling delete items inside them

Expected behaviour: If an anvil breaks due to falling, items in the anvil's inventory slots should drop as items. I'm not sure what the MC behaviour is but it seems harsh to delete items…

ancientmarinerdev commented on issue VoxeLibre/VoxeLibre#3358 2024-06-05 16:26:11 +02:00
bug boat obsidian lava

It's worth considering.

However, I see no need for an obsidian boat, and if it sinks as a joke, it kind of kills the joke for a pointless feature.

I think we have enough issues without…

ancientmarinerdev commented on issue VoxeLibre/VoxeLibre#3923 2024-05-30 17:00:09 +02:00
golems are hostile towards creepers (or the other way around)

Elevated because risking villagers is probably not ideal when many of our villages aren't populated.

ancientmarinerdev closed issue VoxeLibre/VoxeLibre#3907 2024-05-30 16:51:11 +02:00
Malformed spanish translation line
ancientmarinerdev commented on issue VoxeLibre/VoxeLibre#3971 2024-05-30 16:41:06 +02:00
server crash when def.wield_scale is not a number value

As we didn't get an answer on what item had an issue with wield_scale, I'm assuming it's a custom item and a data issue. Without further information, it's impossible to really proceed with this…

ancientmarinerdev commented on issue VoxeLibre/VoxeLibre#3876 2024-05-30 16:20:18 +02:00
The effect factors don't work intuitively

Is this something addressed by potions, or still outstanding?

ancientmarinerdev commented on pull request VoxeLibre/VoxeLibre#4342 2024-05-30 15:45:59 +02:00
Fix beacon crash

Ah. I see now.

ancientmarinerdev commented on pull request VoxeLibre/VoxeLibre#4342 2024-05-30 15:45:10 +02:00
Fix beacon crash

Ah. Thanks for clarifying :).

ancientmarinerdev commented on pull request VoxeLibre/VoxeLibre#4342 2024-05-30 15:02:21 +02:00
Fix beacon crash

This variable name is mispelled, and we later try to reference by key. Is this an error?

ancientmarinerdev commented on issue VoxeLibre/VoxeLibre#4305 2024-05-30 00:16:56 +02:00
Let's raise the stack size of snowballs to 64

The egg stack size is a joke. Makes them quite useless. This would be a good QoL improvement.