fix barrel sound code for proper max hear distance #3900

SmokeyDope · 2023-08-27T06:31:35+02:00

SmokeyDope commented

2023-08-27 06:31:35 +02:00

This PR fixes #3899 by correcting barrel sound code.

The documentation regarding proper sound playing specs in the minetest engine are somewhat messy, ambiguous variable specifications meant that the original version of the code didn't properly apply max_hear_distance flag. It took some puzzling with @ancientmarinerdev to figure out the proper way to implement the code with the composter sounds.

For more information on this issue see:
MineClone2/MineClone2#3670 Add Barrel Sounds PR

MineClone2/MineClone2#3767 Add max hear distance to composter PR (where we figured it out)

MineClone2/MineClone2#3763 related composter sound Issue (fixed)

This PR fixes #3899 by correcting barrel sound code. The documentation regarding proper sound playing specs in the minetest engine are somewhat messy, ambiguous variable specifications meant that the original version of the code didn't properly apply max_hear_distance flag. It took some puzzling with @ancientmarinerdev to figure out the proper way to implement the code with the composter sounds. For more information on this issue see: https://git.minetest.land/MineClone2/MineClone2/pulls/3670 Add Barrel Sounds PR https://git.minetest.land/MineClone2/MineClone2/pulls/3767 Add max hear distance to composter PR (where we figured it out) https://git.minetest.land/MineClone2/MineClone2/issues/3763 related composter sound Issue (fixed)

👍 2

ancientmarinerdev added the

sounds

label 2023-09-01 00:55:16 +02:00

ancientmarinerdev force-pushed fix_barrel_sound_distance from 10b43f0faf to b911f99d23

2023-09-01 00:55:30 +02:00

Compare

ancientmarinerdev added this to the 0.85.0 - Fire and Stone milestone 2023-09-01 00:55:34 +02:00

ancientmarinerdev approved these changes 2023-09-01 00:56:14 +02:00

ancientmarinerdev left a comment

LGTM. Thanks for fixing.

ancientmarinerdev merged commit c6256295a7 into master