VoxeLibre/VoxeLibre
VoxeLibre
/
VoxeLibre
62
134
Fork 181
Code Issues 954 Pull Requests 91 Projects 4 Releases Wiki Activity

add barrel sounds #3670

Merged
ancientmarinerdev merged 4 commits from add-barrel-sound into master 2023-05-04 23:48:10 +02:00
Conversation 8 Commits 4 Files Changed 4 +4
SmokeyDope commented 2023-04-27 20:47:24 +02:00
Member
Copy Link

This PR Adds sounds to opening and closing barrels. The sounds are properly attributed in the 'attribution.txt' file. They are published under Creative Commons 0 (CC0) and the source for them is here

This PR Adds sounds to opening and closing barrels. The sounds are properly attributed in the 'attribution.txt' file. They are published under Creative Commons 0 (CC0) and the source for them is [here](https://freesound.org/people/quantumriver/sounds/552153/)
👍 2
kneekoo reviewed 2023-04-27 22:20:44 +02:00
mods/ITEMS/mcl_barrels/sounds/attribution.txt Outdated
@ -0,0 +1,2 @@
barrel-open.ogg and barrel-close.ogg taken from https://freesound.org/people/quantumriver/sounds/552153/
Liscence: Creative Commons 0 (CC0)
kneekoo commented 2023-04-27 22:20:44 +02:00
Contributor
Copy Link
  • Licence
* Licence
SmokeyDope commented 2023-04-27 22:25:08 +02:00
Author
Member
Copy Link

Whoops! Nice catch.

Whoops! Nice catch.
SmokeyDope marked this conversation as resolved
Ghost commented 2023-04-27 22:25:15 +02:00
First-time contributor
Copy Link

Might need to check sound distance, and add a max_hear_distance tag.

Might need to check sound distance, and add a max_hear_distance tag.
👍 1
SmokeyDope commented 2023-04-27 22:31:27 +02:00
Author
Member
Copy Link

@PrairieWind What do you think a good max hear distance would be? Wiki says 32 is default but that seems a little far. Im thinking 16 or maybe even 10.

@PrairieWind What do you think a good max hear distance would be? Wiki says 32 is default but that seems a little far. Im thinking 16 or maybe even 10.
ancientmarinerdev commented 2023-04-27 22:35:22 +02:00
Owner
Copy Link

@PrairieWind What do you think a good max hear distance would be? Wiki says 32 is default but that seems a little far. Im thinking 16 or maybe even 10.

I think 32 is fine, as it's a tapered sound and the further away, the quieter, though I couldn't imagine it would be audible from more than 16 blocks away. Either are fine.

> @PrairieWind What do you think a good max hear distance would be? Wiki says 32 is default but that seems a little far. Im thinking 16 or maybe even 10. I think 32 is fine, as it's a tapered sound and the further away, the quieter, though I couldn't imagine it would be audible from more than 16 blocks away. Either are fine.
Ghost commented 2023-04-27 22:36:28 +02:00
First-time contributor
Copy Link

It seems the wiki says 16.

It seems the wiki says 16.
SmokeyDope commented 2023-04-27 23:00:25 +02:00
Author
Member
Copy Link

It seems the wiki says 16.

I got the number 32 from here: https://minetest.gitlab.io/minetest/sounds/

> It seems the wiki says 16. I got the number 32 from here: https://minetest.gitlab.io/minetest/sounds/
Ghost commented 2023-04-27 23:03:14 +02:00
First-time contributor
Copy Link

If I am correct, the attenuation distances are the sound distances.
https://minecraft.fandom.com/wiki/Barrel#Sounds

If I am correct, the attenuation distances are the sound distances. https://minecraft.fandom.com/wiki/Barrel#Sounds
👍 1
Ghost added the
nodes
sounds
 labels 2023-04-27 23:47:44 +02:00
kneekoo commented 2023-04-28 00:51:18 +02:00
Contributor
Copy Link

Indeed, the default attenuation distance is 16 blocks in Minecraft. To be sure, I checked over 20 items and mobs, and it was 16 for all of them.

Indeed, the default attenuation distance is 16 blocks in Minecraft. To be sure, I checked over 20 items and mobs, and it was 16 for all of them.
SmokeyDope commented 2023-04-28 01:02:46 +02:00
Author
Member
Copy Link

Good to know, I choose to set it to 16 already so the pr is good to go if theres no other issues

Good to know, I choose to set it to 16 already so the pr is good to go if theres no other issues
ancientmarinerdev force-pushed add-barrel-sound from 0a9c6f580a to c2fac5f6e0 2023-05-04 23:18:27 +02:00 Compare
ancientmarinerdev approved these changes 2023-05-04 23:19:32 +02:00
ancientmarinerdev left a comment
Owner
Copy Link

Looks good and sounds good. Small and simple. Thanks for doing this.

I will squash the commits on merge as this only really justifies 1 commit.

Looks good and sounds good. Small and simple. Thanks for doing this. I will squash the commits on merge as this only really justifies 1 commit.
ancientmarinerdev added this to the 0.84.0 - Very Nice milestone 2023-05-04 23:47:20 +02:00
ancientmarinerdev merged commit 3b64ceb5b2 into master 2023-05-04 23:48:10 +02:00
ancientmarinerdev deleted branch add-barrel-sound 2023-05-04 23:48:22 +02:00
Sign in to join this conversation.
Reviewers
No reviewers
ancientmarinerdev
Labels
Clear labels   
#P1 CRITICAL

for crashes, catastrophic bugs, etc.

  
#P2: HIGH

highest priority level

  
#P3: elevated

2nd-highest priority level

  
#P4 priority: medium

for things that aren't elevated but have been prioritised

  
#P6: low

low priority level

  
#Review

Tickets that may improve or fix an issue but will need a review after a short period of time

  
annoying

non-bugs that annoys people

  
API

   
bug

   
code quality

   
combat

   
commands

   
compatibility

Label to cover migration issues from old worlds or mcl5

  
configurability

   
contribution inside

   
controls

   
core feature

   
creative mode

   
delayed for engine release

   
documentation

   
duplicate

   
enhancement

enhancement request/suggestion

  
environment

Issues that affect weather or light

  
feature request

   
gameplay

   
graphics

   
ground content conflict

mapgen gc-specific quirks

  
GUI/HUD

   
help wanted

   
incomplete feature

   
invalid / won't fix

Invalid, or will not fix

  
items

   
looking for contributor

   
mapgen

   
meta

Relating to VoxeLibre on Mesehub and elsewhere

  
mineclone2+

fit for MineClone2-Plus

  
Minecraft >= 1.13

   
Minecraft >= 1.17

   
missing feature

   
mobile

involving Minetest on mobile devices (android)

  
mobs

   
mod support

Issues related to mod support

  
model needed

A model is needed to be created or updated

  
multiplayer

Issues affecting multiplayer

  
Needs adoption

PR needs author action or to be adopted so changes can be implemented to get the PR closer to merge

  
needs discussion

   
needs engine change

   
needs more information

   
needs research

   
nodes

   
non-mob entities

   
performance

   
player

issues related to the player

  
possible close

   
redstone

   
release notes

This ticket will need information adding to release notes

  
schematics

   
Skyblock

   
sounds

   
Testing / Retest

This needs testing or retesting

  
tools

Related to the tools scripts, which aren't run in game

  
translation

   
unconfirmed
  
mcl5

Possibly relevant for MineClone5

  
mcla

Possibly relevant for Mineclonia

  
Media missing

media files for this feature are missing - contributions welcome

No Label
#P1 CRITICAL
#P2: HIGH
#P3: elevated
#P4 priority: medium
#P6: low
#Review
annoying
API
bug
code quality
combat
commands
compatibility
configurability
contribution inside
controls
core feature
creative mode
delayed for engine release
documentation
duplicate
enhancement
environment
feature request
gameplay
graphics
ground content conflict
GUI/HUD
help wanted
incomplete feature
invalid / won't fix
items
looking for contributor
mapgen
meta
mineclone2+
Minecraft >= 1.13
Minecraft >= 1.17
missing feature
mobile
mobs
mod support
model needed
multiplayer
Needs adoption
needs discussion
needs engine change
needs more information
needs research
nodes
non-mob entities
performance
player
possible close
redstone
release notes
schematics
Skyblock
sounds
Testing / Retest
tools
translation
unconfirmed
mcl5
mcla
Media missing
Milestone
Clear milestone
No items
No Milestone
0.84.0 - Very Nice
Projects
Clear projects
No project
Assignees
Clear assignees
No Assignees
4 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: VoxeLibre/VoxeLibre#3670
No description provided.
Delete Branch "add-barrel-sound"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?