Mineclonia
/
mcl_meshnode
7
0
Fork 0
Code Issues 2 Pull Requests Projects Releases Wiki Activity

Fix controller formspec #8

Closed
cora wants to merge 5 commits from fix-controller-formspec into master
pull from: fix-controller-formspec
merge into: Mineclonia:master
Conversation 0 Commits 5 Files Changed 3 +26 -22
cora commented 2021-08-21 23:41:19 +02:00
Member
Copy Link

this adresses #2

this changes the formspec geometry of the controller inventory to mcl
style 9x3

Verify Bug

  1. Start Mineclonia with mcl_meshnode enabled on commit ce02677e56
  2. /grantme give
  3. /grantme meshnode
  4. /giveme meshnode:controller
  5. place meshnode controller
  6. right click the controller and observe crash

Verify Patch

  1. Start Mineclonia with mcl_meshnode enabled on commit 6cfcb959e2b816ff3e413b5a11d56d56251aedcb
  2. /grantme give
  3. /grantme meshnode
  4. /giveme meshnode:controller
  5. place meshnode controller
  6. verify the formspec looks correct and you can take the glue out of the controller all without crashing the game.
this adresses #2 this changes the formspec geometry of the controller inventory to mcl style 9x3 #### Verify Bug 1. Start Mineclonia with mcl_meshnode enabled on commit ce02677e56aa6dba0c9ac2c65f7a0f5ff4f72968 2. /grantme give 3. /grantme meshnode 4. /giveme meshnode:controller 5. place meshnode controller 6. right click the controller and observe crash #### Verify Patch 1. Start Mineclonia with mcl_meshnode enabled on commit 6cfcb959e2b816ff3e413b5a11d56d56251aedcb 2. /grantme give 3. /grantme meshnode 4. /giveme meshnode:controller 5. place meshnode controller 6. verify the formspec looks correct and you can take the glue out of the controller all without crashing the game.
erlehmann reviewed 2021-08-22 00:04:35 +02:00
init.lua Outdated
@ -61,0 +66,4 @@
return out
end
local function get_itemslot_bg(x, y, w, h)
erlehmann commented 2021-08-22 00:04:35 +02:00
Owner
Copy Link

Why define get_itemslot_bg here instead of depending on mcl_formspec and using mcl_formspec.get_itemslot_bg?

Why define `get_itemslot_bg` here instead of depending on `mcl_formspec` and using `mcl_formspec.get_itemslot_bg`?
erlehmann reviewed 2021-08-22 00:06:31 +02:00
init.lua Outdated
@ -61,0 +61,4 @@
local function get_hotbar_bg(x,y)
local out = ""
for i=0,7,1 do
out = out .."image["..x+i..","..y..";1,1;gui_hb_bg.png]"
erlehmann commented 2021-08-22 00:06:31 +02:00
Owner
Copy Link

From where is the file gui_hb_bg.png loaded?

I could not find(1) it in the Mineclonia or meshnode repositories.

From where is the file `gui_hb_bg.png` loaded? I could not find(1) it in the Mineclonia or meshnode repositories.
cora commented 2021-08-22 00:12:53 +02:00
Author
Member
Copy Link

you tell me #2 (comment)

you tell me https://git.minetest.land/Mineclonia/mcl_meshnode/issues/2#issuecomment-26417
erlehmann commented 2021-08-22 03:33:38 +02:00
Owner
Copy Link

It is probably a default texture and thus not necessary.

It is probably a default texture and thus not necessary.
erlehmann commented 2021-08-22 03:34:16 +02:00
Owner
Copy Link

In fact, @cora and me agree the entire function is not necessary.

In fact, @cora and me agree the entire function is not necessary.
cora force-pushed fix-controller-formspec from 6cfcb959e2 to 51f940fcd0 2021-08-22 00:21:51 +02:00 Compare
cora added 4 commits 2021-08-23 17:30:47 +02:00
cora closed this pull request 2021-08-23 17:31:11 +02:00

Pull request closed

Please reopen this pull request to perform a merge.
Sign in to join this conversation.
Reviewers
No reviewers
Labels
Clear labels
  
in review

   
ready for review
No Label
in review
ready for review
Milestone
Clear milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
No Assignees
2 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: Mineclonia/mcl_meshnode#8
No description provided.
Delete Branch "fix-controller-formspec"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?