Crash on rightclick on meshnode controller #2

New Issue

erlehmann · 2021-08-20T19:18:45+02:00

erlehmann commented

2021-08-20 19:18:45 +02:00

How to reproduce

Place meshnode controller
Right click it

##### How to reproduce 1. Place meshnode controller 2. Right click it

erlehmann commented

2021-08-20 19:26:26 +02:00

Hotfix that looks ugly but works:

diff --git a/init.lua b/init.lua
index d20dcec..199319e 100644
--- a/init.lua
+++ b/init.lua
@@ -58,6 +62,14 @@ local function has_privilege(name)
        return minetest.check_player_privs(name, {meshnode=true})
 end
 
+local function get_hotbar_bg(x,y)
+       local out = ""
+       for i=0,7,1 do
+               out = out .."image["..x+i..","..y..";1,1;gui_hb_bg.png]"
+       end
+       return out
+end
+
 local function show_meshnode_formspec(pos, player)
        local name = player:get_player_name()
        if not has_privilege(name) then
@@ -69,10 +81,10 @@ local function show_meshnode_formspec(pos, player)
        local entity = meshnode.get_luaentity(id)
        local spos = pos.x..","..pos.y..","..pos.z
        local formspec = "size[8,8]"..
-               default.gui_bg..
-               default.gui_bg_img..
-               default.gui_slots..
-               default.get_hotbar_bg(0,4)..
+               ""..
+               ""..
+               ""..
+               get_hotbar_bg(0,4)..
                "list[current_player;main;0,4;8,1;]"..
                "list[current_player;main;0,5.25;8,3;8]"..
                "list[nodemeta:"..spos..";tool;0.5,1.5;1,1;]"

The solution is to fix the formspec ofc.

Hotfix that looks ugly but works: ``` diff --git a/init.lua b/init.lua index d20dcec..199319e 100644 --- a/init.lua +++ b/init.lua @@ -58,6 +62,14 @@ local function has_privilege(name) return minetest.check_player_privs(name, {meshnode=true}) end +local function get_hotbar_bg(x,y) + local out = "" + for i=0,7,1 do + out = out .."image["..x+i..","..y..";1,1;gui_hb_bg.png]" + end + return out +end + local function show_meshnode_formspec(pos, player) local name = player:get_player_name() if not has_privilege(name) then @@ -69,10 +81,10 @@ local function show_meshnode_formspec(pos, player) local entity = meshnode.get_luaentity(id) local spos = pos.x..","..pos.y..","..pos.z local formspec = "size[8,8]".. - default.gui_bg.. - default.gui_bg_img.. - default.gui_slots.. - default.get_hotbar_bg(0,4).. + "".. + "".. + "".. + get_hotbar_bg(0,4).. "list[current_player;main;0,4;8,1;]".. "list[current_player;main;0,5.25;8,3;8]".. "list[nodemeta:"..spos..";tool;0.5,1.5;1,1;]" ``` The solution is to fix the formspec ofc.

cora referenced this issue

2021-08-21 23:41:19 +02:00

Fix controller formspec #8

cora referenced this issue

2021-08-22 00:12:53 +02:00

Fix controller formspec #8

erlehmann commented

2021-08-26 02:59:54 +02:00

This does not crash right now.

erlehmann closed this issue

2021-08-26 02:59:55 +02:00

Sign in to join this conversation.