Mineclonia
/
mcl_meshnode
7
0
Fork 0
Code Issues 2 Pull Requests Projects Releases Wiki Activity

Fix mod loading at all by depending on mcl_player instead of default #6

Closed
cora wants to merge 0 commits from master into fix-depend-on-mcl_player
pull from: master
merge into: Mineclonia:fix-depend-on-mcl_player
Conversation 1 Commits - Files Changed -
cora commented 2021-08-21 23:19:59 +02:00
Member
Copy Link

Verify Bug

  1. Start Mineclonia with mcl_meshnode enabled on commit ab6d4df25f
  2. type /grantme meshnode in chat
  3. Verify error message "Unknown privilege: meshnode"

Verify Patch

  1. Start Mineclonia with mcl_meshnode enabled on thise branch c62018f92af475301555613dd115e8c4f1c5aee7
  2. type /grantme meshnode in chat
  3. Verify you get a list of priveleges of your player that includes "meshnode"
#### Verify Bug 1. Start Mineclonia with mcl_meshnode enabled on commit ab6d4df25fe4427ef67a89fb8beebe0dd5bef924 2. type /grantme meshnode in chat 3. Verify error message "Unknown privilege: meshnode" #### Verify Patch 1. Start Mineclonia with mcl_meshnode enabled on thise branch c62018f92af475301555613dd115e8c4f1c5aee7 2. type /grantme meshnode in chat 3. Verify you get a list of priveleges of your player that includes "meshnode"
cora added 2 commits 2021-08-21 23:20:01 +02:00
b74ac4d27c
Attach player on top of meshnode controller 
Previously, any player attached to the meshnode controller was floating
above it. This could lead to the attached player being unable to detach
from the controller, as a node could fit between player and controller.
cora closed this pull request 2021-08-21 23:21:13 +02:00
cora commented 2021-08-21 23:26:34 +02:00
Author
Member
Copy Link

i clicked to fast ig lol. closed in favor of #7

i clicked to fast ig lol. closed in favor of #7

Pull request closed

Please reopen this pull request to perform a merge.
Sign in to join this conversation.
Reviewers
No reviewers
Labels
Clear labels
  
in review

   
ready for review
No Label
in review
ready for review
Milestone
Clear milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
No Assignees
1 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: Mineclonia/mcl_meshnode#6
No description provided.
Delete Branch "master"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?