Mineclonia
/
mcl_meshnode
7
0
Fork 0
Code Issues 2 Pull Requests Projects Releases Wiki Activity

Attach player on top of meshnode controller #5

Merged
cora merged 1 commits from fix-player-attachment into master 2021-08-21 22:31:33 +02:00
Conversation 0 Commits 1 Files Changed 1 +4 -1
erlehmann commented 2021-08-21 19:22:01 +02:00
Owner
Copy Link
Description

Previously, any player attached to the meshnode controller was floating
above it. This could lead to the attached player being unable to detach
from the controller, as a node could fit between player and controller.

Solution

This patch modifies the attachment position to be about one node lower.

Isssue

This PR addresses issue #4 entirely.

Verify Bug
  1. Create a new world with the default game (“Minetest game”)
  2. Check out commit d88094f87e of the meshnode mod.
  3. Activate the “meshnode” mod for the new world.
  4. Enter the world in survival mode.
  5. Execute the following commands:
    • /grantme meshnode
    • /grantme give
    • /giveme meshnode:controller
    • /giveme default:stone
  6. Verify you have a meshnode controller and a stone block in your inventory.
  7. Place the meshnode controller on the ground.
  8. Place the stone next to the meshnode controller.
  9. Rightclick the meshnode controller.
  10. Verify that you see the meshnode controller inventory.
  11. Take the meshnode glue out of the meshnode controller inventory.
  12. Press the escape key to leave the meshnode controller inventory.
  13. Left click the previously placed stone node with the meshnode glue.
  14. Verify tht the stone node god a bit brighter.
  15. Right click the meshnode controller.
  16. Verify that you see the meshnode controller inventory.
  17. Put the meshnode glue back into the meshnode controller inventory.
  18. Click the button “Activate meshnode”.
  19. Verify that the meshnode controller inventory closed.
  20. Right click the meshnode controller.
  21. Verify that you see a menu with the following points:
    • Attach
    • Restore
    • Align
  22. Click the “Attach” button.
  23. Verify that the meshnode menu interface closed.
  24. Switch to third person view.
  25. Verify that the player is floating above the meshnode controller.
Verify Patch
  1. Check out commit b74ac4d27c of the meshnode mod.
  2. Enter the previously created world in survival mode.
  3. Right click the meshnode controller.
  4. Verify that you see a menu with the following points:
    • Attach
    • Restore
    • Align
  5. Click the “Attach” button.
  6. Verify that the meshnode menu interface closed.
  7. Switch to third person view.
  8. Verify that the player is standing directly on top of the meshnode controller.
##### Description Previously, any player attached to the meshnode controller was floating above it. This could lead to the attached player being unable to detach from the controller, as a node could fit between player and controller. ##### Solution This patch modifies the attachment position to be about one node lower. ##### Isssue This PR addresses issue #4 entirely. ##### Verify Bug 1. Create a new world with the default game (“Minetest game”) 2. Check out commit d88094f87e9bbe9bd759754d3d2d9099ec135ffa of the meshnode mod. 3. Activate the “meshnode” mod for the new world. 4. Enter the world in survival mode. 5. Execute the following commands: * `/grantme meshnode` * `/grantme give` * `/giveme meshnode:controller` * `/giveme default:stone` 6. Verify you have a meshnode controller and a stone block in your inventory. 7. Place the meshnode controller on the ground. 8. Place the stone next to the meshnode controller. 9. Rightclick the meshnode controller. 10. Verify that you see the meshnode controller inventory. 11. Take the meshnode glue out of the meshnode controller inventory. 12. Press the escape key to leave the meshnode controller inventory. 13. Left click the previously placed stone node with the meshnode glue. 14. Verify tht the stone node god a bit brighter. 13. Right click the meshnode controller. 10. Verify that you see the meshnode controller inventory. 11. Put the meshnode glue back into the meshnode controller inventory. 12. Click the button “Activate meshnode”. 13. Verify that the meshnode controller inventory closed. 14. Right click the meshnode controller. 15. Verify that you see a menu with the following points: * Attach * Restore * Align 16. Click the “Attach” button. 17. Verify that the meshnode menu interface closed. 18. Switch to third person view. 19. Verify that the player is floating above the meshnode controller. ###### Verify Patch 1. Check out commit b74ac4d27c1280e84a8c08973e472a9b5990c60c of the meshnode mod. 2. Enter the previously created world in survival mode. 3. Right click the meshnode controller. 15. Verify that you see a menu with the following points: * Attach * Restore * Align 16. Click the “Attach” button. 17. Verify that the meshnode menu interface closed. 18. Switch to third person view. 19. Verify that the player is standing directly on top of the meshnode controller.
erlehmann added 1 commit 2021-08-21 19:22:03 +02:00
b74ac4d27c
Attach player on top of meshnode controller 
Previously, any player attached to the meshnode controller was floating
above it. This could lead to the attached player being unable to detach
from the controller, as a node could fit between player and controller.
cora approved these changes 2021-08-21 22:31:25 +02:00
cora left a comment
Member
Copy Link
Verify Bug
  • 1.Create a new world with the default game (“Minetest game”)
  • 2.Check out commit d88094f87e of the meshnode mod.
  • 3. Activate the “meshnode” mod for the new world.
  • 4. Enter the world in survival mode.
  • 5. Execute the following commands: [...]
  • 6. Verify you have a meshnode controller and a stone block in your inventory.
  • 7. Place the meshnode controller on the ground.
  • 8. Place the stone next to the meshnode controller.
  • 9. Rightclick the meshnode controller.
  • 10. Verify that you see the meshnode controller inventory.
  • 11. Take the meshnode glue out of the meshnode controller inventory.
  • 12. Press the escape key to leave the meshnode controller inventory.
  • 13. Left click the previously placed stone node with the meshnode glue.
  • 14. Verify tht the stone node god a bit brighter.
  • 13. Right click the meshnode controller.
  • 10. Verify that you see the meshnode controller inventory.
  • 11. Put the meshnode glue back into the meshnode controller inventory.
  • 12. Click the button “Activate meshnode”.
  • 13. Verify that the meshnode controller inventory closed.
  • 14. Right click the meshnode controller.
  • 15. Verify that you see a menu with the following points [...]
  • 16. Click the “Attach” button.
  • 17. Verify that the meshnode menu interface closed.
  • 18. Switch to third person view.
  • 19. Verify that the player is floating above the meshnode controller.
Verify Patch
  • 1. Check out commit b74ac4d27c of the meshnode mod.
  • 2. Enter the previously created world in survival mode.
  • 3. Right click the meshnode controller.
  • 15. Verify that you see a menu with the following points: [...]
  • 16. Click the “Attach” button.
  • 17. Verify that the meshnode menu interface closed.
  • 18. Switch to third person view.
  • 19. Verify that the player is standing directly on top of the meshnode controller.

It should be noted that this puts the player 1 node lower i.e. .5 nodes above the position of the controller.

##### Verify Bug - [x] 1.Create a new world with the default game (“Minetest game”) - [x] 2.Check out commit d88094f87e9bbe9bd759754d3d2d9099ec135ffa of the meshnode mod. - [x] 3. Activate the “meshnode” mod for the new world. - [x] 4. Enter the world in survival mode. - [x] 5. Execute the following commands: [...] - [x] 6. Verify you have a meshnode controller and a stone block in your inventory. - [x] 7. Place the meshnode controller on the ground. - [x] 8. Place the stone next to the meshnode controller. - [x] 9. Rightclick the meshnode controller. - [x] 10. Verify that you see the meshnode controller inventory. - [x] 11. Take the meshnode glue out of the meshnode controller inventory. - [x] 12. Press the escape key to leave the meshnode controller inventory. - [x] 13. Left click the previously placed stone node with the meshnode glue. - [x] 14. Verify tht the stone node god a bit brighter. - [x] 13. Right click the meshnode controller. - [x] 10. Verify that you see the meshnode controller inventory. - [x] 11. Put the meshnode glue back into the meshnode controller inventory. - [x] 12. Click the button “Activate meshnode”. - [x] 13. Verify that the meshnode controller inventory closed. - [x] 14. Right click the meshnode controller. - [x] 15. Verify that you see a menu with the following points [...] - [x] 16. Click the “Attach” button. - [x] 17. Verify that the meshnode menu interface closed. - [x] 18. Switch to third person view. - [x] 19. Verify that the player is floating above the meshnode controller. ###### Verify Patch - [x] 1. Check out commit b74ac4d27c1280e84a8c08973e472a9b5990c60c of the meshnode mod. - [x] 2. Enter the previously created world in survival mode. - [x] 3. Right click the meshnode controller. - [x] 15. Verify that you see a menu with the following points: [...] - [x] 16. Click the “Attach” button. - [x] 17. Verify that the meshnode menu interface closed. - [x] 18. Switch to third person view. - [x] 19. Verify that the player is standing directly on top of the meshnode controller. It should be noted that this puts the player 1 node lower i.e. .5 nodes above the position of the controller.
cora merged commit ab6d4df25f into master 2021-08-21 22:31:33 +02:00
cora deleted branch fix-player-attachment 2021-08-21 22:31:41 +02:00
Sign in to join this conversation.
Reviewers
No reviewers
cora
Labels
Clear labels
  
in review

   
ready for review
No Label
in review
ready for review
Milestone
Clear milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
No Assignees
2 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: Mineclonia/mcl_meshnode#5
No description provided.
Delete Branch "fix-player-attachment"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?