Mineclonia
/
mcl_meshnode
7
0
Fork 0
Code Issues 2 Pull Requests Projects Releases Wiki Activity

Make the settings GUI actually work #17

Merged
cora merged 1 commits from fix-settingstypes into master 2021-08-30 21:17:17 +02:00
Conversation 0 Commits 1 Files Changed 1 +9 -9
erlehmann commented 2021-08-30 20:43:54 +02:00
Owner
Copy Link

This make settings actually work, hopefully.

(They were missing the “meshnode_” prefix.)

Testing instructions by @cora:

Verify Bug
  1. start Mineclonia with mcl_meshnode commit e9dd34eea0
  2. change "show_in_creative" from false to true to in advanced settings (mods->meshnode)
  3. start a game in creative mode
  4. verify the controller does not show up in the creative menu
Verify Fix
  1. start Mineclonia with mcl_meshnode commit c051fbffdc
  2. change "meshnode_show_in_creative" from false to true to in advanced settings (mods->meshnode)
  3. start a game in creative mode
  4. verify the controller does show up in the creative menu
This make settings actually work, hopefully. (They were missing the “meshnode_” prefix.) Testing instructions by @cora: ##### Verify Bug 1. start Mineclonia with mcl_meshnode commit e9dd34eea04c3116a8d2d00414380f705578e91f 2. change "show_in_creative" from false to true to in advanced settings (mods->meshnode) 3. start a game in creative mode 4. verify the controller does not show up in the creative menu ##### Verify Fix 1. start Mineclonia with mcl_meshnode commit c051fbffdca17bafd707974f39e9e127ea8e8118 2. change "meshnode_show_in_creative" from false to true to in advanced settings (mods->meshnode) 3. start a game in creative mode 4. verify the controller does show up in the creative menu
erlehmann added 1 commit 2021-08-30 20:43:56 +02:00
cora approved these changes 2021-08-30 21:17:06 +02:00
cora left a comment
Member
Copy Link
Verify Bug
  • 1. start Mineclonia with mcl_meshnode commit e9dd34eea0
  • 2. change "show_in_creative" from false to true to in advanced settings (mods->meshnode)
  • 3. start a game in creative mode
  • 4. verify the controller does not show up in the creative menu
Verify Fix
  • 1. start Mineclonia with mcl_meshnode commit c051fbffdc
  • 2. change "meshnode_show_in_creative" from false to true to in advanced settings (mods->meshnode)
  • 3. start a game in creative mode
  • 4. verify the controller does show up in the creative menu
##### Verify Bug - [x] 1. start Mineclonia with mcl_meshnode commit e9dd34eea04c3116a8d2d00414380f705578e91f - [x] 2. change "show_in_creative" from false to true to in advanced settings (mods->meshnode) - [x] 3. start a game in creative mode - [x] 4. verify the controller does not show up in the creative menu ##### Verify Fix - [x] 1. start Mineclonia with mcl_meshnode commit c051fbffdca17bafd707974f39e9e127ea8e8118 - [x] 2. change "meshnode_show_in_creative" from false to true to in advanced settings (mods->meshnode) - [x] 3. start a game in creative mode - [x] 4. verify the controller does show up in the creative menu
cora merged commit 2af311fc72 into master 2021-08-30 21:17:17 +02:00
cora deleted branch fix-settingstypes 2021-08-30 21:17:29 +02:00
Sign in to join this conversation.
Reviewers
No reviewers
cora
Labels
Clear labels
  
in review

   
ready for review
No Label
in review
ready for review
Milestone
Clear milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
No Assignees
2 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: Mineclonia/mcl_meshnode#17
No description provided.
Delete Branch "fix-settingstypes"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?