Mineclonia
/
mcl_meshnode
7
0
Fork 0
Code Issues 2 Pull Requests Projects Releases Wiki Activity

Add optional Archimedes' Ships crafting recipe #15

Merged
cora merged 1 commits from use-archimedes-ships-helm-recipe into master 2021-08-30 23:35:22 +02:00
Conversation 2 Commits 1 Files Changed 3 +16
erlehmann commented 2021-08-30 20:18:19 +02:00
Owner
Copy Link
Issue

Issue #13

Description

Several Minecraft mods enable the creation of multi-block ships. The most common
crafting recipe shared among them for a “steering wheel” or “helm” node (they use
different names for the equivalent of the meshnode controller) is the following:

wooden plank, stick, wooden plank
stick, iron ingot, stick
wooden plank, stick, wooden plank

A good example would be Archimedes' Ships Mod:
http://www.9minecraft.net/archimedes-ships-mod/

Testing

This PR adds a setting to enable a different meshnode controller crafting recipe.

  1. Checkout mcl_meshnode commit ad871ff41d.
  2. Ensure the setting “meshnode_enable_crafting” for the meshnode mod in the settings GUI is set to true.
  3. Check that the controller crafting recipes work with all of the following combinations:

  • Minetest Game, setting “meshnode_use_archimedes_ships_crafting_recipe” is false (default recipe)

    recipe = {
	{"default:bronzeblock", "default:diamondblock", "default:bronzeblock"},
	{"default:obsidian_block", "default:steelblock", "default:goldblock"},
	{"default:bronzeblock", "default:steelblock", "default:bronzeblock"},
}

  • Mineclonia, setting “meshnode_use_archimedes_ships_crafting_recipe” is false (default recipe)

    recipe = {
	{"mcl_colorblocks:concrete_orange", "mcl_core:diamondblock", "mcl_colorblocks:concrete_orange"},
	{"mcl_core:obsidian", "mcl_core:ironblock", "mcl_core:goldblock"},
	{"mcl_colorblocks:concrete_orange", "mcl_core:ironblock", "mcl_colorblocks:concrete_orange"},
}

  • Minetest Game, setting “meshnode_use_archimedes_ships_crafting_recipe” is true (changed recipe)

    	recipe = {
		{"group:wood", "group:stick", "group:wood"},
		{"group:stick", "default:steel_ingot", "group:stick"},
		{"group:wood", "group:stick", "group:wood"},
	}

  • Mineclonia, setting “meshnode_use_archimedes_ships_crafting_recipe” is true (changed recipe)

    	recipe = {
		{"group:wood", "group:stick", "group:wood"},
		{"group:stick", "mcl_core:iron_ingot", "group:stick"},
		{"group:wood", "group:stick", "group:wood"},
	}
##### Issue Issue https://git.minetest.land/Mineclonia/mcl_meshnode/issues/13 ##### Description Several Minecraft mods enable the creation of multi-block ships. The most common crafting recipe shared among them for a “steering wheel” or “helm” node (they use different names for the equivalent of the meshnode controller) is the following: wooden plank, stick, wooden plank stick, iron ingot, stick wooden plank, stick, wooden plank A good example would be Archimedes' Ships Mod: http://www.9minecraft.net/archimedes-ships-mod/ ##### Testing This PR adds a setting to enable a different meshnode controller crafting recipe. 0. Checkout mcl_meshnode commit ad871ff41db8f3c1fc599783c55a735250ddc17a. 1. Ensure the setting “meshnode_enable_crafting” for the meshnode mod in the settings GUI is set to true. 2. Check that the controller crafting recipes work with all of the following combinations: * Minetest Game, setting “meshnode_use_archimedes_ships_crafting_recipe” is false (default recipe) recipe = { {"default:bronzeblock", "default:diamondblock", "default:bronzeblock"}, {"default:obsidian_block", "default:steelblock", "default:goldblock"}, {"default:bronzeblock", "default:steelblock", "default:bronzeblock"}, } * Mineclonia, setting “meshnode_use_archimedes_ships_crafting_recipe” is false (default recipe) recipe = { {"mcl_colorblocks:concrete_orange", "mcl_core:diamondblock", "mcl_colorblocks:concrete_orange"}, {"mcl_core:obsidian", "mcl_core:ironblock", "mcl_core:goldblock"}, {"mcl_colorblocks:concrete_orange", "mcl_core:ironblock", "mcl_colorblocks:concrete_orange"}, } * Minetest Game, setting “meshnode_use_archimedes_ships_crafting_recipe” is true (changed recipe) recipe = { {"group:wood", "group:stick", "group:wood"}, {"group:stick", "default:steel_ingot", "group:stick"}, {"group:wood", "group:stick", "group:wood"}, } * Mineclonia, setting “meshnode_use_archimedes_ships_crafting_recipe” is true (changed recipe) recipe = { {"group:wood", "group:stick", "group:wood"}, {"group:stick", "mcl_core:iron_ingot", "group:stick"}, {"group:wood", "group:stick", "group:wood"}, }
erlehmann force-pushed use-archimedes-ships-helm-recipe from 662e9b8978 to 4bc44e2ccf 2021-08-30 20:49:56 +02:00 Compare
erlehmann commented 2021-08-30 20:54:34 +02:00
Author
Owner
Copy Link

Merge PR #17 before, then rebase this on master and remve the WIP prefix.

Merge PR https://git.minetest.land/Mineclonia/mcl_meshnode/pulls/17 before, then rebase this on master and remve the WIP prefix.
erlehmann force-pushed use-archimedes-ships-helm-recipe from 4bc44e2ccf to ad871ff41d 2021-08-30 21:25:50 +02:00 Compare
erlehmann changed title from WIP: Add optional Archimedes' Ships crafting recipe to Add optional Archimedes' Ships crafting recipe 2021-08-30 21:31:29 +02:00
erlehmann commented 2021-08-30 21:32:27 +02:00
Author
Owner
Copy Link

Rebased.

Rebased.
cora approved these changes 2021-08-30 23:35:01 +02:00
cora left a comment
Member
Copy Link
Testing
  • * Minetest Game, setting “meshnode_use_archimedes_ships_crafting_recipe” is false (default recipe)
  • * Mineclonia, setting “meshnode_use_archimedes_ships_crafting_recipe” is false (default recipe)
  • * Minetest Game, setting “meshnode_use_archimedes_ships_crafting_recipe” is true (changed recipe)
  • * Mineclonia, setting “meshnode_use_archimedes_ships_crafting_recipe” is true (changed recipe)
##### Testing - [x] * Minetest Game, setting “meshnode_use_archimedes_ships_crafting_recipe” is false (default recipe) - [x] * Mineclonia, setting “meshnode_use_archimedes_ships_crafting_recipe” is false (default recipe) - [x] * Minetest Game, setting “meshnode_use_archimedes_ships_crafting_recipe” is true (changed recipe) - [x] * Mineclonia, setting “meshnode_use_archimedes_ships_crafting_recipe” is true (changed recipe)
cora merged commit 3bfb73aa0a into master 2021-08-30 23:35:22 +02:00
cora deleted branch use-archimedes-ships-helm-recipe 2021-08-30 23:35:29 +02:00
Sign in to join this conversation.
Reviewers
No reviewers
cora
Labels
Clear labels
  
in review

   
ready for review
No Label
in review
ready for review
Milestone
Clear milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
No Assignees
2 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: Mineclonia/mcl_meshnode#15
No description provided.
Delete Branch "use-archimedes-ships-helm-recipe"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?