Commit Graph

12597 Commits

Author SHA1 Message Date
teknomunk 9fcfe9fd56 Fix alias 2024-10-10 12:47:57 +02:00
teknomunk 9c4ab2045e Implement more bonemeal mod shim, update bonemeal dependencies 2024-10-10 12:47:57 +02:00
teknomunk 6366b7e0ef Address review comments 2024-10-10 12:47:57 +02:00
teknomunk d673193219 Only show particles if bone meal is consumed, don't continue testing positions if bonemeal was used on the first check position 2024-10-10 12:47:57 +02:00
teknomunk 08a3b7e5a6 Show particles regardless of success 2024-10-10 12:47:57 +02:00
teknomunk 61e0f7dc95 Quick patch to get cherry saplings growing pending inclusing of a proper tree API 2024-10-10 12:47:57 +02:00
teknomunk 675399e8a5 Remove check with mcl_core.check_vines_supported for twisted and crimson vines 2024-10-10 12:47:57 +02:00
teknomunk 750045b5e5 Address review comments on mcl_util.trace_nodes 2024-10-10 12:47:57 +02:00
teknomunk 7342b23268 Add growth limits to crimson/twisting vines 2024-10-10 12:47:57 +02:00
teknomunk c1a331c951 Add mcl_util.trace_node(), rewrite bamboo growth code to fix bone meal growth 2024-10-10 12:47:57 +02:00
teknomunk f4fdfea2e9 Prevent bonemealing grass from making flowers and also bonemealing the block above the grass 2024-10-10 12:47:57 +02:00
teknomunk 029b8555ea Fix crash when bonemealing weaping and twisting vines, fix weaping vine growth 2024-10-10 12:47:57 +02:00
teknomunk 55400a616a Reorder functions to prevent crash 2024-10-10 12:47:57 +02:00
teknomunk f771fbb9a9 Remove TODO pending future discussions, revert timer change in composter code 2024-10-10 12:47:57 +02:00
teknomunk 47e80619b5 Make composter_progress_chance local, as it is not used anywhere except in mcl_composters 2024-10-10 12:47:57 +02:00
teknomunk 5a82fb62ce Fix typo that prevented bone mealing pumpkin plants 2024-10-10 12:47:57 +02:00
teknomunk edc4fcdc6a Check both above and below in pointed_thing for bonemealing (and pass thru the position as .under), make crimson vines and twisting vines compostable by rightclicking on the composter 2024-10-10 12:47:57 +02:00
teknomunk d043640599 Fix crash at one more spot 2024-10-10 12:47:57 +02:00
teknomunk aa8761cd2f Fix crashes when using bonemeal on nether nodes 2024-10-10 12:47:57 +02:00
teknomunk 14c840e78f Change _mcl_on_bonemealing to _on_bone_meal, update API.md to reflect this 2024-10-10 12:47:57 +02:00
teknomunk 854e92d954 Fix mods/ITEMS/mcl_composters/locale/mcl_composters.ru.tr 2024-10-10 12:47:57 +02:00
teknomunk 6892251882 Update mod authors, remove a TODO 2024-10-10 12:47:57 +02:00
teknomunk 0d88b7d18e Remove bone to bone meal recipe from mcl_dye as it now resides in mcl_bone_meal 2024-10-10 12:47:57 +02:00
teknomunk c09e99cbec Modify backtrace listing to use minetest.log 2024-10-10 12:47:57 +02:00
teknomunk ab18b4f49d Fix localization errors 2024-10-10 12:47:57 +02:00
teknomunk 8f20360bac Only consume bone meal if a _mcl_on_bonemealing callback is defined or the legacy API returns true, convert vines to use new bonemeal API 2024-10-10 12:47:57 +02:00
teknomunk 7a26281a3d Fix localization except mcl_composters.ru.tr 2024-10-10 12:47:57 +02:00
teknomunk 3ba155fcd0 Enable bamboo bonemealing despite rightclick handling strangeness 2024-10-10 12:47:57 +02:00
teknomunk 84a9c687ab Rename localization files 2024-10-10 12:47:57 +02:00
teknomunk 545e752289 Add untested bonemeal mod compatibility shim 2024-10-10 12:47:57 +02:00
teknomunk cd25480f56 Move commented out bamboo bone meal code into mods/ITEMS/mcl_bamboo/bamboo_base.lua 2024-10-10 12:47:57 +02:00
teknomunk a6aa5b215c Add new API call mcl_bone_meal.use_bone_meal and use this to remove duplicate code, update mcl_farming:sweet_berries to use bonemeal API, add stub for bonemeal mod compatibility 2024-10-10 12:47:57 +02:00
teknomunk cf294756a9 Update mcl_crimson to use bonemealing API 2024-10-10 12:47:57 +02:00
teknomunk cde63cceac Remove bone meal definition in mcl_dye, make textures in mcl_cocoas match master branch 2024-10-10 12:47:57 +02:00
teknomunk cde0162dac Display call stack to assist in removing deprecated function calls 2024-10-10 12:47:57 +02:00
teknomunk dc135d0730 Fix mod dependencies 2024-10-10 12:47:57 +02:00
kabou b619d7bf37 Remove color specifications from bone meal.
* The bone meal craftitem definition still had color specifications
  from its past as a dye substitute.  These can be removed now.
* Also remove default stack_max setting.
2024-10-10 12:47:57 +02:00
kabou 44569972cf Remove color specifications from cocoa beans.
* The cocoa beans craftitem definition still had color specifications
  from its past as a dye substitute.  These can be removed now.
2024-10-10 12:47:57 +02:00
kabou 41c058edbb Also generate double grass when bonemealing grass blocks. 2024-10-10 12:47:57 +02:00
kabou fee81806ba Remove expired bone meal API.md from mcl_dye. 2024-10-10 12:47:57 +02:00
kabou 98da3365a4 Bonemealing mechanics bugfix.
When applying bonemeal to eg. farm crops, these have a chance to grow in
response to the application of bone meal. When a node can be bonemealed, the
applied bone meal item should always be spent after using it, regardless of
the results.  Currently this does not work correctly, if the result of
bonemealing has no effect on the node, the used bone meal item is not spent.

This commit fixes the behavior of the bone meal item to always be taken when
used on a node that defines a `_mcl_on_bonemealing()` callback.

The nodes that implement the callback imay use the handler's return value
only to signal if the bonemealing was succesful, not to signal if it was at
all possible.  For this reason, some nodes need to be made more strictly
conforming to the API.

* Always take the used bone meal item (if user is not in creative mode),
  regardless of whether the bonemealed node's handler returned `true`.
* Make dispensers spawn particles after succesful bonemealing.
* Trivial comment fix.
* Ripe cocoa pod cannot be bonemealed.
* Update API.md to describe the stricter API semantics.
2024-10-10 12:47:57 +02:00
kabou c96cc30d3d Improve mcl_bone_meal fr translations.
* Changed the wording after suggestions by AFCMS.
2024-10-10 12:47:57 +02:00
kabou 8dac5778cc Add missing es translation to mcl_bone_meal. 2024-10-10 12:47:57 +02:00
kabou f07423a6ef Move cocoa beans item to mcl_cocoas.
* Add `mcl_cocoas:coca_beans` craftitem to mcl_cocoas.
* Remove `mcl_dye:brown` craftitem from mcl_dye.
* Move cocoa beans translations from mcl_dye to mcl_cocoas.
* Add `mcl_dye:brown` alias for `mcl_cocoas:cocoa_beans` to
  mcl_dye.
* Abstract cocoa pod node registration into a loop.
* Update chocolate cookies crafting recipe in mcl_farming.
2024-10-10 12:47:57 +02:00
kabou 4ab6958c25 Remove stray line from locale template.
* Removed a line from the mcl_bone_meal locale template that had by
  accident put there during the bone meal <-> white dye changes.
2024-10-10 12:47:57 +02:00
kabou 86a378d32a Use better override mechanism.
* Use `minetest.override_item()` instead of re-registering the node with
  ":" prefixed to its name.  Thanks again to wsor for mentioning this.
2024-10-10 12:47:57 +02:00
kabou 3a5b96b86b Add more particles when bonemealing grass.
* Bonemealing dirt_with_grass spawns new growth over a wide area, so it
  looks better if we spawn a few more extra bone meal particles.
* Update mod.conf depends to mcl_bone_meal.
2024-10-10 12:47:57 +02:00
kabou bdb0a6571f Update to new bone meal API.
* Update to use new mcl_bone_meal API:
* Use new bone meal item and remove related comment.
* Update mod depends in mod.conf
* Spelling fixes: s/bonemeal/bone meal/g
2024-10-10 12:47:57 +02:00
kabou d29edbd3f4 Add mcl_bone_meal.
* New mod mcl_bone_meal, replacing bone meal functionality previously
  held in mcl_dye.
* Improve bonemealing API using callbacks in the nodes that support
  bonemealing.
* Rename bone meal item to `"mcl_bone_meal:bone_meal"` and updated its
  crafting recipe.
* Implement legacy compatibility for older bone meal API.
* Remove all non dye-related bone meal code, texture and translations from
  mcl_dye.
* Add legacy compatibility shims to mcl_dye that refer to mcl_bone_meal.
* Add an alias for "mcl_dye:white" to keep mcl_dye and its API working
  uniterrupted.
* Update mod depends in mcl_dye mod.conf.
2024-10-10 12:47:57 +02:00
kabou 44a7f6a771 Add bonemealing callback for fern.
* Adds a _mcl_on_bonemealing callback to fern.
2024-10-10 12:47:57 +02:00