the-real-herowl
  • Joined on 2023-08-07
the-real-herowl commented on pull request VoxeLibre/VoxeLibre#3878 2023-09-22 22:26:35 +02:00
Wither finishing, effect fixes

Thing is, the array already exists, right at the start of mcl_mobs/init.lua – and I am just adding to it.

the-real-herowl approved VoxeLibre/VoxeLibre#3784 2023-09-22 07:03:40 +02:00
add 1.20 armor trims

It seems there are two licenses, the CC-BY is indeed there and is valid.

the-real-herowl commented on pull request VoxeLibre/VoxeLibre#3784 2023-09-22 06:23:36 +02:00
add 1.20 armor trims

All the stuff from the checklist works, can confirm.

the-real-herowl suggested changes for VoxeLibre/VoxeLibre#3784 2023-09-22 06:22:00 +02:00
add 1.20 armor trims

On top of the license problems, one of the trims (sentry) resembles the MC texture too closely IMHO.

the-real-herowl commented on pull request VoxeLibre/VoxeLibre#3784 2023-09-22 06:21:59 +02:00
add 1.20 armor trims

The license is certainly not CC-BY. It's a pinky promise license, that can at most be interpreted as CC-BY-NC, which gets flagged on CDB. However, it's not even that.

the-real-herowl suggested changes for VoxeLibre/VoxeLibre#3898 2023-09-19 23:43:31 +02:00
WIP: Add tridents
the-real-herowl commented on pull request VoxeLibre/VoxeLibre#3898 2023-09-19 23:43:30 +02:00
WIP: Add tridents

Define a _pickup_timer here.

the-real-herowl commented on pull request VoxeLibre/VoxeLibre#3898 2023-09-19 23:43:30 +02:00
WIP: Add tridents

Same thing as above.

the-real-herowl commented on pull request VoxeLibre/VoxeLibre#3898 2023-09-19 23:43:29 +02:00
WIP: Add tridents

Use a variable in the entity, like self._pickup_timer instead. This doesn't work the way you think it does. And don't set it to 0 every frame.

the-real-herowl commented on pull request VoxeLibre/VoxeLibre#3898 2023-09-19 23:43:28 +02:00
WIP: Add tridents

Don't.

the-real-herowl commented on pull request VoxeLibre/VoxeLibre#3898 2023-09-19 23:43:27 +02:00
WIP: Add tridents

This texture doesn't exist.

the-real-herowl commented on pull request VoxeLibre/VoxeLibre#3898 2023-09-19 23:43:27 +02:00
WIP: Add tridents

You're creating a global.

the-real-herowl commented on pull request VoxeLibre/VoxeLibre#3898 2023-09-19 23:43:26 +02:00
WIP: Add tridents

Why add the second vector to the trident_start_pos, which is calculated already? Putting the trident_start_pos there directly as a function argument seems to produce the desired result, the added vector breaks it.

the-real-herowl commented on pull request VoxeLibre/VoxeLibre#3898 2023-09-19 23:43:25 +02:00
WIP: Add tridents

Ekhm

the-real-herowl commented on pull request VoxeLibre/VoxeLibre#3898 2023-09-19 23:23:38 +02:00
WIP: Add tridents

This is worse than what you think it is. Look at the next line, it's creating a global.

the-real-herowl commented on pull request VoxeLibre/VoxeLibre#3898 2023-09-19 23:20:42 +02:00
WIP: Add tridents

Textures should be in our textures folder, not in the specific mod folder.

the-real-herowl commented on pull request VoxeLibre/VoxeLibre#3878 2023-09-18 02:32:21 +02:00
Wither finishing, effect fixes

For drops of items, they can get laggy if there are many of them, this is obvious. This is not a job for this PR though. Solutions if somebody has this problem: -focus more on picking up the…

the-real-herowl commented on pull request VoxeLibre/VoxeLibre#3878 2023-09-18 02:22:19 +02:00
Wither finishing, effect fixes

At this point (referring to earlier objections), spawning-player-checking is as optimized as it can be. There's no way to check if a player reference is valid except for getting a new one. Also,…

the-real-herowl pushed to master at the-real-herowl/MineClone2 2023-09-18 02:17:44 +02:00
a95c87dbc7 Implemented wither defensive measures
the-real-herowl commented on pull request VoxeLibre/VoxeLibre#3878 2023-09-18 02:12:47 +02:00
Wither finishing, effect fixes

okay, explain please?

MC wither does glitch into blocks when you purposely summon him in a place or use a contraption to glitch him. It's not really a glitch in the…