Fine, but what size should it be exactly? I set it at what felt right to me. It's like one number, it's not a problem to change it, or even make it into a setting.
All you ever wanted…
Removed searching for nodes, moved mob affecting to the mcl_mobs (I made it similar to magma blocks damage). Now it only looks through players, and only checks a single node per player. Should be…
Yeah, so I tested ABMs, and they are very unreliable. They mostly don't work when running through the rose. We could of course add a check for the effect before searching for the node, but it…
Yeah, I think the potions API is due for a rewrite. What I have in mind is getting rid of those specific functions and making it possible to register effects (in mods too) by name, and dealing…
This is dealing effect at attack, when hitting with a melee attack. This is for wither skeletons, because since I was doing wither effect, I wanted to put it wherever it should be (and it required…
I don't think I am the right person to review this as I never really touched mob related stuff, but here are some minor things I've found after skimming through the code...
Also,…
Yeah, so I figured that all "wither" sort of mobs are supposed to be resistant. Wither boss is already resistant due to being boss. This leaves only the wither skeleton, this is true, but it makes…
True, I'm removing it. Not commiting yet, since this is "just" a pointless if.
Well, look at the other effects. I kept it in the same style. The whole potions API could be redone though, just of course not in this PR.
Firstly, it makes it compatible with any ghasts variant a mod could add (or we could add down the line, which may not happen). Secondly, I had coded the spider poison resistance by using a…
If it is a player, entity is not present... Yeah, seems like the condition should be expanded.
Because I consider it cheap enough that timer only convolutes things. I think the function call staying on every step and an if and the timer would take a similar time to setting a bunch of…
That's why I have wither despawning code: wither follows the spawner, and despawns after a set time from him going offline (if somebody is fighting the wither in this time, this turns back the…