the-real-herowl
  • Joined on 2023-08-07
the-real-herowl deleted branch effect_load_fix from VoxeLibre/VoxeLibre 2024-06-13 13:21:38 +02:00
the-real-herowl merged pull request VoxeLibre/VoxeLibre#4425 2024-06-13 13:21:37 +02:00
Effect loading fixes
the-real-herowl commented on issue VoxeLibre/VoxeLibre#4428 2024-06-13 13:20:33 +02:00
Client-side mod?

Maybe we need to wait for this to happen before csm will be really useful: https://dev.minetest.net/Proposals/Client_scripting_plans

Not really. Nobody uses CSMs seriously, so without…

the-real-herowl commented on pull request VoxeLibre/VoxeLibre#4338 2024-06-13 13:15:23 +02:00
mcl_weather sky color refactor

Sky transitions when going out of the water were laggy for me even before. I did a lot of entering and leaving water when working on #4130 and sometimes it took reloading the world to fix the sky…

the-real-herowl commented on pull request VoxeLibre/VoxeLibre#4338 2024-06-13 13:12:50 +02:00
mcl_weather sky color refactor

Keep mgv6 support. We have a lot of code supporting it anyway, even though it may be disabled for new worlds for now Partially as a challenge, I'd like to remake mgv6 support and re-enable it in…

the-real-herowl commented on pull request VoxeLibre/VoxeLibre#4338 2024-06-12 17:49:15 +02:00
mcl_weather sky color refactor

Tbh comments should be impersonal. Not "you shouldn't do X", but rather "X shouldn't be done". At least in theory. Also things like "it is/was assumed...".

the-real-herowl commented on pull request VoxeLibre/VoxeLibre#4338 2024-06-12 17:47:28 +02:00
mcl_weather sky color refactor

Also "Ether" instead of "Either".

the-real-herowl commented on pull request VoxeLibre/VoxeLibre#4338 2024-06-12 17:45:55 +02:00
mcl_weather sky color refactor

It is a custom to end long blocks of code with such comments, especially in C++. Some like it, some hate it.

the-real-herowl commented on pull request VoxeLibre/VoxeLibre#4338 2024-06-12 17:41:04 +02:00
mcl_weather sky color refactor

I haven't started the work yet though, so if anyone wants to do it, go on.

the-real-herowl commented on pull request VoxeLibre/VoxeLibre#4338 2024-06-12 17:39:52 +02:00
mcl_weather sky color refactor

I've been looking at refactoring the dimensions API (mcl_worlds) lately... that could be the start of or prelude to the mapgen update. Registering dimensions is of course one of the desired features.

the-real-herowl commented on issue VoxeLibre/VoxeLibre#4427 2024-06-12 14:57:14 +02:00
General item conversion API

Makes sense.

the-real-herowl pushed to master at VoxeLibre/VoxeLibre 2024-06-12 14:18:06 +02:00
1f32b47208 Fix crash while fighting whither (#4392)
the-real-herowl closed issue VoxeLibre/VoxeLibre#4358 2024-06-12 14:18:05 +02:00
Crash while fighting wither
the-real-herowl merged pull request VoxeLibre/VoxeLibre#4392 2024-06-12 14:18:04 +02:00
Fix crash while fighting whither
the-real-herowl commented on issue VoxeLibre/VoxeLibre#4427 2024-06-12 14:11:59 +02:00
General item conversion API

Theoretically aliases handle simple conversions. It's when multiple items need to be converted into a single item (differing eg. in metadata) that aliases are insufficient and special code needs…

the-real-herowl commented on pull request VoxeLibre/VoxeLibre#4392 2024-06-12 02:16:39 +02:00
Fix crash while fighting whither

LGTM aside of those

the-real-herowl commented on pull request VoxeLibre/VoxeLibre#4392 2024-06-12 01:57:09 +02:00
Fix crash while fighting whither

Add bosses to the comment if it is supposed to be comprehensive.

the-real-herowl commented on pull request VoxeLibre/VoxeLibre#4392 2024-06-12 01:57:09 +02:00
Fix crash while fighting whither

Extra space near the end of the line?

the-real-herowl created pull request VoxeLibre/VoxeLibre#4426 2024-06-11 20:38:45 +02:00
Potion conversion fix