New crashes introduced:
AsyncErr: Lua: Runtime error from mod '??' in callback node_on_timer(): "Runtime error from mod '??' in callback luaentity_Activate(): .../.minetest/games/mcl2-dev/mod…Maybe explicitly shadow the parameter by local staticdata? I'm not sure if Lua treats this as a parameter overwrite or assignment to a global.
TBH we can leave the improperly converted mobs, just the spawners need to be looked into.
Also, while mobs convert properly by directly updating to this patch from 0.86.2, they don't get fixed if they got improperly converted into 0.87.1 first, and then loaded with this patch... not sure what is the correct solution.
I couldn't get anything to spawn from rover and stalker spawners converted with this patch, although the dolls were the correct models+textures (even though the rover one is very small, as you've once noticed).
Welp, looks like it's more complex than that. Still, reproduced and investigating.
Yeah reproduced. My guess was correct, it's the counter explosion, triggered by either a skull at close range or the soulfire attack.
Be aware that saturation is manipulated in mcl_potions in the Nausea effect, so may want to take that into account here.
When we make a CSM and the CSMs kick off in general and become a normal mainstream thing, we should be able to at least optimize away those things for people who do use the CSM.
There are a few…
Only partially. They give it when they hit player I think, but not when nearby.
Now this left me wondering if we have such things in code already... it could explain some bugs.
Also, sky changing is now very laggy? Attached video has me going in and out of water, first on
master, and then on your branch. This didn't happen when I was game-testing this PR the first…
It's fine.
Btw: While writing API, prefer table argument to multiple arguments for register functions.