Makes sense. Now we just have to make sure that whatever we want noticed doesn't use swap_node.
Do we want these noticed by observers? The following use swap_node():
- comparators
- …
Probably should've been obj, as it's an ObjectRef and not a luaentity.
Yes I just notice I had this comment hanging for some time. Not 100% sure about this now that I think about it.
This function should say object where it says entity (name and parameter), because player doesn't count as entity.
Found another bug while testing the sound fixes I just pushed: sometimes when you hit yourself with an arrow, keeps hitting you after it is stuck in you, until the one arrow kills you, with no…
Ah I was testing without the most recent commit, it's fine now.
However, regardless of that, spears stuck in walls (i.e. in the side of a block) are sometimes impossible to pick up without…
Same thing with spears. Also spears stuck in a player aren't preserved on reload... and they're supposed to be recoverable in all cases, that's why they are dropped as items on removal.
Now reloaded arrows do disappear when collected, but don't appear in the inventory and no sound is played (in survival). Also I think no pickup sound is played ever in creative.
Got one more issue. Arrows (shot in survival in my testing) stuck in the ground can't be picked up anymore after reloading a world. Weird stuff happens with other projectiles too, eg. spears stuck…
Somebody should close this issue or the old one at some point, or just fix and close them both then. Not sure.
Got the crash mentioned in #4703 here too:
AsyncErr: Lua: Runtime error from mod '??' in callback luaentity_Step(): ...wik/.minetest/games/mcl2-dev/mods/CORE/mcl_util/init.lua:735: bad…AsyncErr: Lua: Runtime error from mod '??' in callback luaentity_Step(): ...wik/.minetest/games/mcl2-dev/mods/CORE/mcl_util/init.lua:735: bad argument #1 to 'get_player_by_name' (string…Arrows stuck in walls (unlike those stuck in floors) misbehave seriously, dealing damage when picked up.
While throwing eggs (either after spawning a chicken or hitting a chicken with an egg):
AsyncErr: Lua: Runtime error from mod '??' in callback luaentity_Step(): ...inetest/games/mcl2-dev/mods…