teknomunk
  • Joined on 2024-02-12
teknomunk commented on pull request VoxeLibre/VoxeLibre#4433 2024-12-07 21:41:21 +01:00
Projectile Refactor

Okay. Looks like it might be a race condition that prevents the callback for fireballs from being called when it kills the ghast, which skips the check for the Fireball Redirection Service…

teknomunk commented on pull request VoxeLibre/VoxeLibre#4433 2024-12-07 20:43:55 +01:00
Projectile Refactor

It looks something a bit more complicated is going on, because I can get the achievement without modifications to logic, but it usually doesn't trigger. Without understanding what is going on, I…

teknomunk commented on pull request VoxeLibre/VoxeLibre#4433 2024-12-07 20:31:50 +01:00
Projectile Refactor

Hi, I'm the one who created #4738 . I just tested with the projectile-refactor branch and I'm NOT able to get the "Fireball Redirection Service" achievement. Hope that helps. :)

Yes, it does.…

teknomunk pushed to redstone-circuits at VoxeLibre/VoxeLibre 2024-12-07 19:40:40 +01:00
7ba2723dad Remove extra build_netlist() that always is run on block update (expensive)
teknomunk commented on pull request VoxeLibre/VoxeLibre#4433 2024-12-07 19:18:35 +01:00
Projectile Refactor
teknomunk pushed to projectile-refactor at VoxeLibre/VoxeLibre 2024-12-07 19:17:20 +01:00
teknomunk pushed to projectile-refactor at VoxeLibre/VoxeLibre 2024-12-07 19:15:47 +01:00
8aa3d255a4 Remove redundant table.copy()
ea21ec6619 Replace magic numbers with named constants, add missing 'local'
430cd8dffa Break long lines, add space between functions in vl_projectile/init.lua
429b55b9c6 Add _vl_projectile.can_punch() to mob API and move hard-coded entity behavior from arrow to rover code
d2523dcb02 Change to use nil radius in within_limits(pos,radius) check
Compare 108 commits »
teknomunk commented on pull request VoxeLibre/VoxeLibre#4433 2024-12-07 19:15:23 +01:00
Projectile Refactor

New task:

  • Check if this PR already includes a fix in #4738 Fixed achievement 'Fireball Redirection Service'
teknomunk pushed to redstone-circuits at VoxeLibre/VoxeLibre 2024-12-07 19:12:28 +01:00
b81cf544f8 Make sure reverse mapping in netlist_map always includes entries all wires and sinks when there are no sources (fixes netlists not depowering when no power sources present)
teknomunk pushed to redstone-circuits at VoxeLibre/VoxeLibre 2024-12-07 18:43:12 +01:00
e1571db17e Connect up circuits thru weakly powered blocks while disallowing passthru to wire
teknomunk pushed to redstone-circuits at VoxeLibre/VoxeLibre 2024-12-07 13:28:48 +01:00
53affeb796 Start strong/weak block powering logic
teknomunk commented on pull request VoxeLibre/VoxeLibre#4726 2024-12-07 13:08:47 +01:00
WIP: Redstone Circuits

Netlist ID indeterminism most likely from random ordering of vector components.

teknomunk pushed to redstone-circuits at VoxeLibre/VoxeLibre 2024-12-07 02:46:27 +01:00
feb7003904 Make power source nodes (redstone torches, redstone blocks, etc) power nets
teknomunk commented on pull request VoxeLibre/VoxeLibre#4433 2024-12-06 23:14:10 +01:00
Projectile Refactor

I think reverting is safe to do. At worst, it will have slightly higher memory usage.

teknomunk pushed to fireworks_update at VoxeLibre/VoxeLibre 2024-12-06 23:11:41 +01:00
79eff90ede Correct damage_groups return (ObjectRef:get_velocity() returns a vector not the required number)
39c3e51214 Initial firework projectile
3129264712 Remove redundant table.copy()
cbcda8a72f Replace magic numbers with named constants, add missing 'local'
41704122e6 Break long lines, add space between functions in vl_projectile/init.lua
Compare 109 commits »
teknomunk pushed to fireworks_update at VoxeLibre/VoxeLibre 2024-12-06 23:11:16 +01:00
e7e8c859b8 Correct damage_groups return (ObjectRef:get_velocity() returns a vector not the required number)
ce83ec4df5 Initial firework projectile
c2afe7c808 Remove redundant table.copy()
182e07d76b Replace magic numbers with named constants, add missing 'local'
b6f7a70e52 Break long lines, add space between functions in vl_projectile/init.lua
Compare 114 commits »
teknomunk pushed to minecart-update at teknomunk/MineClone2 2024-12-06 23:09:33 +01:00
34440497c4 Remove debug minetest.log()
1ed194bf03 Increase off-rail friction, make off-rail carts shake, remove debug print
0091cc9204 Address review comments
ddd7d90237 Change cart punching to impulse on velocity instead of acceleration, make punch impulse larger
f27c96e940 Fix syntax error from rebase, fix cart tilt, change cart speed to 4 blocks/second and make into a setting, make minecart settings compatibily with upcoming dynamic rules PR (#4662)
Compare 173 commits »
teknomunk pushed to projectile-refactor at VoxeLibre/VoxeLibre 2024-12-06 23:02:32 +01:00
3129264712 Remove redundant table.copy()
cbcda8a72f Replace magic numbers with named constants, add missing 'local'
41704122e6 Break long lines, add space between functions in vl_projectile/init.lua
b9147976ea Add _vl_projectile.can_punch() to mob API and move hard-coded entity behavior from arrow to rover code
759278d14e Change to use nil radius in within_limits(pos,radius) check
Compare 107 commits »
teknomunk pushed to redstone-circuits at VoxeLibre/VoxeLibre 2024-12-06 14:11:45 +01:00
6d22493b2f Clear netlist information from caches, update caches when new netlists are created
teknomunk commented on pull request VoxeLibre/VoxeLibre#4433 2024-12-06 04:17:45 +01:00
Projectile Refactor

Looks like _save_fields is only used by arrows and arrow derivatives. mcl_throwing projectiles have their own save/load functions at https://git.minetest.land/VoxeLibre/VoxeLibre/src/commit/c2a