Thanks for looking into this.
I'll recommend doing what Mineclonia did with furnaces and possibly…
I did get one prevented crash while testing involving a piglin. The error was "Invalid vector (expected table got nil)." I suspect this is an issue elsewhere in the mcl_mobs code, as I don't…
I used the following for profiling:
function do_stuff()
return 1,"test"
end
function profile(label,count,func)
local start_time = minetest.get_us_time()
…I believe this worked at one point and was broken by a formspec (GUI) rework. See VoxeLibre/VoxeLibre#631 for the old issue and a link to a PR that may have broken it.
table.update is part of mcl_util. Add that to the dependencies for the mod to make sure it gets loaded first.
Please never go above 120 characters per line. Usually you can see it at the bottom infobar of your text editor.
Does this also apply to the api.md file and inline code comments or just…
That looks it clamps the value to between 0 and 1. If that is the intention, it will help people in the future if you mention it is clamped and the range in the comment.
Used mcl_weather.skycolor.NIGHT_VISION_RATIO to move it into this file.
I find code that has more than about 3 indentation levels difficult to follow. I find that making code more linear and breaking things out into other functions helps a lot with reasoning about…