teknomunk
  • Joined on 2024-02-12
teknomunk commented on pull request VoxeLibre/VoxeLibre#4453 2024-06-24 15:05:17 +02:00
Grand Chests Refactor (fixes #281)

Location #4

teknomunk commented on pull request VoxeLibre/VoxeLibre#4453 2024-06-24 15:05:17 +02:00
Grand Chests Refactor (fixes #281)

Should this be protection_check_put? The function exists above.

teknomunk commented on pull request VoxeLibre/VoxeLibre#4453 2024-06-24 15:05:17 +02:00
Grand Chests Refactor (fixes #281)

Is this extra space intentional?

teknomunk commented on pull request VoxeLibre/VoxeLibre#4453 2024-06-24 15:05:17 +02:00
Grand Chests Refactor (fixes #281)

These LBMs may be better to be in chests.lua where these nodes are defined. Doing so would require makig function select_and_spawn_entity() available in chests.lua.

teknomunk commented on pull request VoxeLibre/VoxeLibre#4453 2024-06-24 15:05:16 +02:00
Grand Chests Refactor (fixes #281)

This logic is in 4 separate places. This is a candidate for moving to its own function (get_chest_inventories(pos, side)?) that returns top_inv,bottom_inv

teknomunk commented on pull request VoxeLibre/VoxeLibre#4453 2024-06-24 15:05:16 +02:00
Grand Chests Refactor (fixes #281)

Location #2

teknomunk commented on pull request VoxeLibre/VoxeLibre#4453 2024-06-24 15:05:16 +02:00
Grand Chests Refactor (fixes #281)

Location #3

teknomunk pushed to fix-has_room at VoxeLibre/VoxeLibre 2024-06-24 05:19:09 +02:00
c232270c11 Add most of the code for sub-node accurate spawning volume check (needs a function to calculate bounding box height of nodes)
789049615e Add spawnbox parameter that overrides collision box for spawn volume checks
170c6780f4 Fix space check function has_room() in mcl_mobs/spawning.lua so it allows spiderproofing
026ea5940c Merge pull request 'release/0.87.2' (#4457) from release/0.87.2 into master
be9fece0d3 Post-hotfix reset version 0.88.0-SNAPSHOT
Compare 24 commits »
teknomunk deleted branch fix-conversion-crash from teknomunk/MineClone2 2024-06-24 04:40:33 +02:00
teknomunk commented on issue VoxeLibre/VoxeLibre#4455 2024-06-23 22:28:33 +02:00
(Skeleton) horses never despawn

I have seen similar in worlds I've played before. In my case, I had a couple of depressions in the land nearby my base. Over time, as there were thunderstorms, skeleton horses would spawn and…

teknomunk commented on pull request VoxeLibre/VoxeLibre#4453 2024-06-23 16:33:25 +02:00
Grand Chests Refactor (fixes #281)

This isn't passing the correct inventory in the call to function double_chest_add_item(top_inv, bottom_inv, listname, stack). To correct this, you need to swap inv and other_inv when side == "right".

teknomunk commented on pull request VoxeLibre/VoxeLibre#4338 2024-06-22 15:37:41 +02:00
mcl_weather sky color refactor

I found a bug this morning with the sky color when returning to the overworld from the nether (see image, this is the overworld). master is also affected, but I think this should be resolved…

teknomunk pushed to skycolor-refactor at teknomunk/MineClone2 2024-06-22 02:47:25 +02:00
2e67e20932 Force has_mcl_potions to boolean
090c90f4fc Add mcl_util.to_bool
Compare 2 commits »
teknomunk pushed to add-dynamic-rules at teknomunk/MineClone2 2024-06-22 02:27:29 +02:00
9d13ea0eff Start GUI
1749d0a011 Fix typo in variable name
Compare 2 commits »
teknomunk commented on issue VoxeLibre/VoxeLibre#4452 2024-06-21 17:33:55 +02:00
Pressure plate not always fired when walking over them

I was able to reproduce this issue, and have an idea what is causing this to happen.

Currently pressure plates are implemented by periodically checking for entities nearby and triggering if…

teknomunk commented on issue VoxeLibre/VoxeLibre#4451 2024-06-21 04:40:18 +02:00
Shift-click armor item in inventory to equip

Thanks for looking into this.

I'll recommend doing what Mineclonia did with furnaces and possibly…

teknomunk commented on pull request VoxeLibre/VoxeLibre#4407 2024-06-21 04:15:37 +02:00
Fix #3710 (instant hoglin transformation) + other nether mob fixes

I did get one prevented crash while testing involving a piglin. The error was "Invalid vector (expected table got nil)." I suspect this is an issue elsewhere in the mcl_mobs code, as I don't…

teknomunk pushed to add-dynamic-rules at teknomunk/MineClone2 2024-06-21 04:03:46 +02:00
cbc0d6d581 Implement showDeathMessages gamerule
teknomunk commented on pull request VoxeLibre/VoxeLibre#4338 2024-06-21 02:06:21 +02:00
mcl_weather sky color refactor

I used the following for profiling:

function do_stuff()
        return 1,"test"
end

function profile(label,count,func)
        local start_time = minetest.get_us_time()
       
teknomunk commented on issue VoxeLibre/VoxeLibre#4451 2024-06-21 01:21:58 +02:00
Shift-click armor item in inventory to equip

I believe this worked at one point and was broken by a formspec (GUI) rework. See VoxeLibre/VoxeLibre#631 for the old issue and a link to a PR that may have broken it.