teknomunk
  • Joined on 2024-02-12
teknomunk commented on pull request VoxeLibre/VoxeLibre#4280 2024-06-26 13:46:11 +02:00
New mcl_copper

A few things:

  1. @rudzik8, the function as you have written there doesn't actually modify the tables. v = material updates the local variable v not the table contents. For that, you need…
teknomunk pushed to persist-xp-orbs at teknomunk/MineClone2 2024-06-26 12:23:32 +02:00
94981d9c09 Add return for get_staticdata
7ae05d9c06 Add persistence to XP orbs, cleanup xp_to_size
177e8f4b9d Code cleanup
026ea5940c Merge pull request 'release/0.87.2' (#4457) from release/0.87.2 into master
be9fece0d3 Post-hotfix reset version 0.88.0-SNAPSHOT
Compare 24 commits »
teknomunk pushed to update-german-translations at teknomunk/MineClone2 2024-06-26 03:10:14 +02:00
03d43346aa More translations entered
teknomunk pushed to update-german-translations at teknomunk/MineClone2 2024-06-26 03:02:46 +02:00
39378c96b0 Add more German translations from Laudrin
5175245cbd Add translation support to mcl_compressed_blocks
6af8026a70 Last of the translations provided that have existing translation code for translating strings
b7875f75a8 Enter more translations
161e4322a9 Start installing the German translations from #4333
Compare 38 commits »
teknomunk commented on pull request VoxeLibre/VoxeLibre#4350 2024-06-26 03:02:29 +02:00
WIP: Update German Translations

It looks like for the translation "Schmiedevorlage 'Küste'" the code currently can't handle "Küste", as "coast" isn't a translated string, I'm not sure if you can nest translated string inside…

teknomunk pushed to update-german-translations at teknomunk/MineClone2 2024-06-26 03:00:17 +02:00
ddb0117110 Add more German translations from Laudrin
teknomunk commented on pull request VoxeLibre/VoxeLibre#4453 2024-06-26 01:47:38 +02:00
Grand Chests Refactor (fixes #281)

Never mind. I think I found it. See below.

teknomunk commented on pull request VoxeLibre/VoxeLibre#4453 2024-06-26 01:46:09 +02:00
Grand Chests Refactor (fixes #281)

This should be inv:set_stack() to make the right half of double chests work correctly. For the left half of chests top_inv == inv.

teknomunk commented on pull request VoxeLibre/VoxeLibre#4453 2024-06-26 01:39:45 +02:00
Grand Chests Refactor (fixes #281)

For the latest commit, try this:

  1. Make double chest
  2. Create a stack of 1 item that can have a max stack size of 64 (i.e. sand)
  3. Open right-hand side of double chest
  4. Shift-click 1…
teknomunk commented on issue VoxeLibre/VoxeLibre#4072 2024-06-25 22:06:12 +02:00
Slimes are spawning too frequently and too fast

One thing that makes slimes spawn a lot less in MC is that they need 2x2 blocks afaik to spawn and then decide if large, med or small slime spawn. Maybe that would help? Is there a airblock…

teknomunk commented on pull request VoxeLibre/VoxeLibre#4443 2024-06-25 14:48:03 +02:00
Thunder/rain inconsistencies, sunburn and flashes of fire

I suspect that an entity will be needed to pass to punch() to make the message work as desired. If minetest engine supported passing a fake player to this API call, that would probably be the way…

teknomunk commented on pull request VoxeLibre/VoxeLibre#4453 2024-06-25 14:15:57 +02:00
Grand Chests Refactor (fixes #281)

The use of :get_list() without a corresponding :set_list() is supicious. I believe that :get_list() returns a list of ItemStack objects that need to be passed back to :set_list() to take effect. Not sure how this code worked before.

teknomunk commented on pull request VoxeLibre/VoxeLibre#4453 2024-06-25 14:15:57 +02:00
Grand Chests Refactor (fixes #281)

You don't need to put these in local variables to return. You can put the return inside the if statement block.

teknomunk suggested changes for VoxeLibre/VoxeLibre#4453 2024-06-25 14:15:57 +02:00
Grand Chests Refactor (fixes #281)

A couple of things. I'll do a proper test and review later when I have time.

teknomunk commented on issue VoxeLibre/VoxeLibre#4464 2024-06-25 06:01:11 +02:00
Villagers (and other mobs) oblivious to danger, drowning in the ocean or falling into the depth

This looks like #2456 - drowning occurs if the top part of the player and/or mob is in water, even if the head is not underwater. Hopefully PR #4412 will fix this problem.

That PR probably…

teknomunk pushed to fix-has_room at VoxeLibre/VoxeLibre 2024-06-24 16:35:46 +02:00
41c3524646 Make spiders require 3x1x3 space to spawn
teknomunk pushed to fix-has_room at VoxeLibre/VoxeLibre 2024-06-24 15:53:13 +02:00
e2636f6cc9 Implement partial node spawning check
bea6a9fd06 Add most of the code for sub-node accurate spawning volume check (needs a function to calculate bounding box height of nodes)
377c507529 Add spawnbox parameter that overrides collision box for spawn volume checks
ce0a34d667 Fix space check function has_room() in mcl_mobs/spawning.lua so it allows spiderproofing
Compare 4 commits »
teknomunk commented on pull request VoxeLibre/VoxeLibre#4453 2024-06-24 15:05:18 +02:00
Grand Chests Refactor (fixes #281)

This LBM could be moved to ender.lua.

teknomunk commented on pull request VoxeLibre/VoxeLibre#4453 2024-06-24 15:05:18 +02:00
Grand Chests Refactor (fixes #281)

"with following fields:" should be "with the following fields:"

teknomunk suggested changes for VoxeLibre/VoxeLibre#4453 2024-06-24 15:05:18 +02:00
Grand Chests Refactor (fixes #281)

Looking the code over I found a few things that could be improved, a grammatical mistake in the documentation and a nitpick.