- pos: (26.8, 8.3, 33.1)
- https://codeberg.org/rudzik8
-
Siberian 15yo Minetest player and modder, MineClone 2 contributor
#nowar
- Joined on
2022-02-18
First-of-all, thanks for reaching out with this mod and showing your willingness to work with us. We appreciate that.
We generally check for the air group to avoid mod conflicts (there's a surprising amount of air-like nodes that mods use for purely technical reasons).
I see what you're going for with that description, but it's easy to think that this has some more relation to golden apples than simply the recipe form.
You're using this to fill out the drawtype field later on L247, so I don't see how this naming makes sense.
In-game testing worked as expected, +1 for that. Just quality control.
I find this part a little bit hard to read. You also don't need to use ipairs for this.
facedir_to_degrotateis clearly a lookup table that doesn't have to be constructed each time that LBM is ran. Just move it up to a few levels above.
I think it'd be a sane idea to check whether user is nil or a player at all. This applies not only to this function, but to the ones following it too. We had (and kind of still have) too many player-is-nil crashes to neglect such checks.
Why the whitespace at the end?