- pos: (26.8, 8.3, 33.1)
- https://codeberg.org/rudzik8
-
Siberian 15yo Minetest player and modder, MineClone 2 contributor
#nowar
- Joined on
2022-02-18
cut_decay_chain and doors_decay_chain look pretty damn similar for the exception of the trailing _cut portion. It's not a huge deal, but I wonder if you could optimize that through code. Seems like an easy target.
Sorry for not being transparent enough and telling that the line breaks issue had been fixed (I was preparing to go to sleep and didn't look much into the diffs).
Lacks paramtype = "light" if we don't want this to happen (see the weird shadow in the center?):
I believe it has more problems than that. I think I'll take this and do a refactor of mcl_doors.
Yes, those lines. Thank you.
I'll take a more proper dive into the code itself tomorrow. For now, I'll remove the WIP: prefix.
Good job! The code quality is certainly improving. Sorry if I'm being too nitpicky, but my opinion is, if we are refactoring a mod with code quality improvements, we should go all the way (because nobody will care after it gets merged).
I don't know what happened, but there are invisible Unicode characters between "values " and "as" (U+200B). Not critical, but annoying, as it will pop up every time someone looks up the source code for this mod through Gitea.
Have the files been
optipng'd? bush_0 and bush_3 are larger than before.Yes, they were. `find -type f -name "mcl_farming_sweet_berr*.png" -exec optipng -o7 -nx -strip all {}…
- Still no explanations given in the code.
What explanations should I add and where should I add these explanations?
In general, I want you to explain what certain parts of code do…
Have the files been
optipng'd? bush_0 and bush_3 are larger than before.
Yes, they were. find -type f -name "mcl_farming_sweet_berr*.png" -exec optipng -o7 -nx -strip all {} \;