- pos: (26.8, 8.3, 33.1)
- https://codeberg.org/rudzik8
-
Siberian 15yo Minetest player and modder, MineClone 2 contributor
#nowar
- Joined on
2022-02-18
I know this is conversion code and it might not really matter, but it's the same thing as in the very first comment of this review. This line is unreadable, and feels like as if someone tried to compress it on purpose.
This didn't get into the diff, but in this function, line 13... is just a spaghetti mess. There are situations where putting an if-return statement in one single line is welcome, but this is not the case.
This is a bit more readable than the other one-liners I criticize in this review, but still, it's bad. Can you at least add spaces and maybe a comment explaining the +1.5 value?
Please don't use "I" in your comments, or any pronouns for that matter (I'm looking at you, "he/she" "her/his" from some weird 2015 Minetest code I examined earlier when working on Voxelgarden). Only use "you" or "they" (and variants) if you must. I think we should add that to the guidelines.
Although the bonemeal API is certainly up for a big change, we can't count on that change for such critical bugs as this. LGTM
supported_node_facedir group and apply it to item frames