- pos: (26.8, 8.3, 33.1)
- https://codeberg.org/rudzik8
-
Siberian 15yo Minetest player and modder, MineClone 2 contributor
#nowar
- Joined on
2022-02-18
Move all these settings assignments somewhere so that you aren't constantly writing vl_hudbars.settings.
The clouds are still not visible when you're underwater, but when you just leave it, having no jitter appear is pleasant. +1.
Why would you do it? nil acts as false (and not nil as true) either way, this is just confusing.
The issue I was experiencing is now gone, so +1 for that. In these comments, I give you another +1 for a little something, so in total you have already earned 3 imaginary points from this PR. You're welcome. :D
I like this trick. You did an if statement, but returned it in the end just to keep it at one less tab. Using else here would save you the later comment about no weather applying, but I'll give you a +1 as this is nothing critical, just a neat detail.
NIGHT_VISION_RATIO is not defined here, as it is still assigned locally at skycolor.lua.
Why don't you just assign it at the beginning? This is really unnatural.
At first, I was worried about the protection check part getting removed, but after testing this with Areas and Protection Redo, this seems fine.