n_to
/
Mineclonia
forked from Mineclonia/Mineclonia
1
0
Fork 0
Code Issues Pull Requests Projects Releases Wiki Activity

Fixes logic when to use mob-label and when to use subtype: subtype is preferred #1

Closed
n_to wants to merge 1 commits from fix_death_message_moblabel into master
pull from: fix_death_message_moblabel
merge into: n_to:master
Conversation 1 Commits 1 Files Changed 2 +8 -3
n_to commented 2021-04-18 22:09:20 +02:00
Owner
Copy Link

Background: Mineclonia/Mineclonia#18 resolved a crash but blocked the logic to display "Killer Rabbit"'s subtype deathmessage.

To resolve this I added an additional if/then statement to check for labeled mobs if there is a special death-message for the subtype. If so the subtype-death-message is preferred.

Testscenarios:

    1. Get killed by Killer Rabbit -> subtype message is displayed
    1. Get killed by labeled mob without subtype message (i removed Killer-Rabbits message for this and then let it kill me) -> muder by named mob is used
Background: https://git.minetest.land/Mineclonia/Mineclonia/issues/18 resolved a crash but blocked the logic to display "Killer Rabbit"'s subtype deathmessage. To resolve this I added an additional if/then statement to check for labeled mobs if there is a special death-message for the subtype. If so the subtype-death-message is preferred. Testscenarios: - 1) Get killed by Killer Rabbit -> subtype message is displayed - 2) Get killed by labeled mob without subtype message (i removed Killer-Rabbits message for this and then let it kill me) -> muder by named mob is used
n_to added 1 commit 2021-04-18 22:09:21 +02:00
n_to commented 2021-04-25 17:56:05 +02:00
Author
Owner
Copy Link

No longer needed -> close

No longer needed -> close
n_to closed this pull request 2021-04-25 17:56:05 +02:00

Pull request closed

Please reopen this pull request to perform a merge.
Sign in to join this conversation.
Reviewers
No reviewers
Labels
Clear labels
No items
No Label
Milestone
Clear milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
No Assignees
1 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: n_to/Mineclonia#1
No description provided.
Delete Branch "fix_death_message_moblabel"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?