Fix dynamic media race condition #2

appgurueu · 2023-04-08T20:10:16+02:00

appgurueu commented

2023-04-08 20:10:16 +02:00

First-time contributor

Wait for all players to receive the texture before using it.
Previously this would wait for any player to receive the texture.
This works fine in singleplayer (or on pre-5.5,
where dynamic_add_media would block until all players have received the texture),
but it may fail otherwise:
Either entity textures won't be available in time,
or, even worse, the HUD texture is unavailable.
Both produce an error in chat for clients.

Does not yet fix the information leakage issue.

Wait for *all* players to receive the texture before using it. Previously this would wait for *any* player to receive the texture. This works fine in singleplayer (or on pre-5.5, where dynamic_add_media would block until all players have received the texture), but it may fail otherwise: Either entity textures won't be available in time, or, even worse, the HUD texture is unavailable. Both produce an error in chat for clients. Does not yet fix the information leakage issue.

appgurueu force-pushed master from f33d0aaf53 to df5bd3c4ec

2023-04-08 20:11:10 +02:00

Compare

This pull request can be merged automatically.

You are not authorized to merge this pull request.

You can also view command line instructions.

Step 1:

From your project repository, check out a new branch and test the changes.

git checkout -b appgurueu-master master

git pull master

Step 2:

Merge the changes and update on Gitea.

git checkout master

git merge --no-ff appgurueu-master

git push origin master

Sign in to join this conversation.

No reviewers

No Label

No Milestone

No project

No Assignees

1 Participants

Notifications

Due Date

The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: erle/xmaps#2