erlehmann
/
bushy_leaves
1
0
Fork 2
Code Issues 1 Pull Requests 2 Projects Releases Wiki Activity

Fixes dirt or grass in in Plantlife mod #5

Open
Neuromancer56 wants to merge 1 commits from Neuromancer56/bushy_leaves:master into master
pull from: Neuromancer56/bushy_leaves:master
merge into: erlehmann:master
Conversation 2 Commits 1 Files Changed 1 +1 -1
Neuromancer56 commented 2023-05-30 00:25:43 +02:00
First-time contributor
Copy Link

When using this mod with Plantlife mod, it causes the nodes grass_with_leaves and dirt_with_leaves nodes to be converted to this nodebox. This fixes that.

When using this mod with Plantlife mod, it causes the nodes grass_with_leaves and dirt_with_leaves nodes to be converted to this nodebox. This fixes that.
Neuromancer56 added 1 commit 2023-05-30 00:25:44 +02:00
e3c287193b Fixes dirt or grass in in Plantlife mod 
When using this mod with Plantlife mod, it causes the nodes grass_with_leaves and dirt_with_leaves nodes to be converted to this nodebox.   This fixes that.
erlehmann commented 2023-09-08 22:15:48 +02:00
Owner
Copy Link

@Neuromancer56 thank you for your contribution. Sorry for the late reply.

I think an explicit node blacklist would make more sense. What do you think?

@Neuromancer56 thank you for your contribution. Sorry for the late reply. I think an explicit node blacklist would make more sense. What do you think?
cora commented 2023-09-09 02:56:51 +02:00
First-time contributor
Copy Link

what's wrong with

if minetest.get_item_group(node_name, "leaves") > 0 then ?

seems to work fine for me at least with mtg (yes needles too) and mcl at least

what's wrong with `if minetest.get_item_group(node_name, "leaves") > 0 then` ? seems to work fine for me at least with mtg (yes needles too) and mcl at least
This pull request can be merged automatically.
You are not authorized to merge this pull request.
You can also view command line instructions.

Step 1:

From your project repository, check out a new branch and test the changes.
git checkout -b Neuromancer56-master master
git pull master

Step 2:

Merge the changes and update on Gitea.
git checkout master
git merge --no-ff Neuromancer56-master
git push origin master
Sign in to join this conversation.
Reviewers
No reviewers
Labels
Clear labels
No items
No Label
Milestone
Clear milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
No Assignees
3 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: erlehmann/bushy_leaves#5
No description provided.
Delete Branch "Neuromancer56/bushy_leaves:master"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?