erlehmann
/
bushy_leaves
1
0
Fork 2
Code Issues 1 Pull Requests 2 Projects Releases Wiki Activity

Make bushy leaves/needles just visual #1

Closed
rudzik8 wants to merge 6 commits from (deleted):master into master
pull from: (deleted):master
merge into: erlehmann:master
Conversation 10 Commits 6 Files Changed 1 +8 -1
rudzik8 commented 2022-05-09 06:01:44 +02:00
First-time contributor
Copy Link

Now collision works just like if it was regular leaves/needles node, not making walking on leaves/needles such pain
It's just how I (and maybe most of players) expect your mod will work (just render thing, not causing such problems with collisions)

Maybe implementation is crappy, but it works

Now collision works just like if it was regular leaves/needles node, not making walking on leaves/needles such pain It's just how I (and maybe most of players) expect your mod will work (just render thing, not causing such problems with collisions) Maybe implementation is crappy, but it works
rudzik8 added 1 commit 2022-05-09 06:01:45 +02:00
d6d47b2d4c Make bushes just decorative (override collision) 
Now collision works just like if it was regular leaves/needles node
erlehmann commented 2022-05-09 11:27:00 +02:00
Owner
Copy Link

Thank you, I did not think of that at all.

Thank you, I did not think of that at all.
rudzik8 commented 2022-05-09 14:32:56 +02:00
Author
First-time contributor
Copy Link

Thank you, I did not think of that at all.

So, uh... will you merge it or just close? Is it sarcasm or something?..

> Thank you, I did not think of that at all. So, uh... will you merge it or just close? Is it sarcasm or something?..
erlehmann requested changes 2022-05-09 18:30:20 +02:00
erlehmann left a comment
Owner
Copy Link

Good work. I have minor comments about coding style only.

Good work. I have minor comments about coding style only.
init.lua Outdated
@ -31,6 +31,10 @@ local node_box_bushy_leaves = {
{ -4/16,-12/16, 0/16, 4/16, 12/16, 0/16 },
},
}
local node_box_one_node = {
erlehmann commented 2022-05-09 18:26:58 +02:00
Owner
Copy Link

Please add a single newline before this line.

Please add a single newline before this line.
erlehmann commented 2022-05-09 18:29:58 +02:00
Owner
Copy Link

Could node_box_full_node or node_box_normal_node be a better variable name here?

Could `node_box_full_node` or `node_box_normal_node` be a better variable name here?
rudzik8 marked this conversation as resolved
init.lua
@ -33,1 +33,4 @@
}
local node_box_one_node = {
type = "fixed",
fixed = { -0.5, -0.5, -0.5, 0.5, 0.5, 0.5 },
erlehmann commented 2022-05-09 18:26:47 +02:00
Owner
Copy Link

Please change 0.5 to 8/16 for consistency with the rest of the code.

Please change 0.5 to 8/16 for consistency with the rest of the code.
rudzik8 marked this conversation as resolved
erlehmann commented 2022-05-09 18:30:54 +02:00
Owner
Copy Link

Thank you, I did not think of that at all.

So, uh... will you merge it or just close?

I took a third option and left you some review comments.

Is it sarcasm or something?..

No, I meant exactly what I said.

> > Thank you, I did not think of that at all. > > So, uh... will you merge it or just close? I took a third option and left you some review comments. > Is it sarcasm or something?.. No, I meant exactly what I said.
rudzik8 added 1 commit 2022-05-10 06:57:17 +02:00
rudzik8 commented 2022-05-10 06:57:59 +02:00
Author
First-time contributor
Copy Link

Fixed

Fixed
erlehmann commented 2022-05-10 15:02:55 +02:00
Owner
Copy Link

Could you squash these two commits into one? Otherwise, I'll do it and credit you.

Could you squash these two commits into one? Otherwise, I'll do it and credit you.
rudzik8 added 1 commit 2022-05-10 16:29:38 +02:00
763ca3e7d4 Make bushes just decorative (override collision) 
Now collision works just like if it was regular leaves/needles node

Rename local to node_box_full_node and fix formatting

Make bushy leaves/needles just visual
rudzik8 commented 2022-05-10 16:30:38 +02:00
Author
First-time contributor
Copy Link

Ohhh
I tried to do a rebase but it doesn't work...
Will try to fix

Ohhh I tried to do a rebase but it doesn't work... Will try to fix
rudzik8 added 1 commit 2022-05-10 16:31:21 +02:00
e1c172dd72 Fix 
oops
rudzik8 commented 2022-05-10 16:41:05 +02:00
Author
First-time contributor
Copy Link

Nah, I'm trying to follow git rebase tutorial about squashing and it goes to nothing (or just broken commits)
For some reason it tries to rearrange commits that I pick to squash (in interactive mode) and makes nothing

Nah, I'm trying to follow git rebase tutorial about squashing and it goes to nothing (or just broken commits) For some reason it tries to rearrange commits that I pick to squash (in interactive mode) and makes nothing
rudzik8 added 2 commits 2022-05-10 16:55:23 +02:00
78e6a32873 Make bushy leaves/needles just visual 
Now collision works just like if it was regular leaves/needles node, not making walking on leaves/needles such pain
rudzik8 commented 2022-05-10 17:04:10 +02:00
Author
First-time contributor
Copy Link

Situation only got worse ._.
I need help

Situation only got worse ._. *I need help*
erlehmann commented 2022-05-10 18:23:34 +02:00
Owner
Copy Link

Dw I'll fix it!

Dw I'll fix it!
erlehmann commented 2022-05-10 18:41:15 +02:00
Owner
Copy Link

Closed in favor of this PR: #2

Closed in favor of this PR: https://git.minetest.land/erlehmann/bushy_leaves/pulls/2
erlehmann closed this pull request 2022-05-10 18:41:15 +02:00

Pull request closed

This pull request cannot be reopened because the branch was deleted.
Sign in to join this conversation.
Reviewers
No reviewers
erlehmann
Labels
Clear labels
No items
No Label
Milestone
Clear milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
No Assignees
2 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: erlehmann/bushy_leaves#1
No description provided.
Delete Branch "(deleted):master"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?