erlehmann
/
bushy_leaves
1
0
Fork 2
Code Issues 1 Pull Requests 2 Projects Releases Wiki Activity

Set full node collision box for bushy leaves #2

Merged
erlehmann merged 1 commits from fix-collision-box-2 into master 2022-05-11 18:51:07 +02:00
Conversation 4 Commits 1 Files Changed 1 +6
erlehmann commented 2022-05-10 18:40:26 +02:00
Owner
Copy Link

When a node has no collision box it uses the node box as the collision
box. This effect made walking on nodes modified by this mod difficult.

This patch explicitly sets a collision box with the size of a full node
for modified nodes. This makes the “bushy leaves” effect purely visual;
it does not affect collision differently than if the mod is not loaded.

When a node has no collision box it uses the node box as the collision box. This effect made walking on nodes modified by this mod difficult. This patch explicitly sets a collision box with the size of a full node for modified nodes. This makes the “bushy leaves” effect purely visual; it does not affect collision differently than if the mod is not loaded.
erlehmann commented 2022-05-10 18:42:56 +02:00
Author
Owner
Copy Link

@rudzik8 I do not know what went wrong in #1 … but I have rebased and hopefully fixed your commits.

Is this the change you originally intended?

@rudzik8 I do not know what went wrong in https://git.minetest.land/erlehmann/bushy_leaves/pulls/1 … but I have rebased and hopefully fixed your commits. Is this the change you originally intended?
erlehmann force-pushed fix-collision-box-2 from 4da7a40ac0 to e16e015cd8 2022-05-10 18:43:45 +02:00 Compare
erlehmann commented 2022-05-10 18:44:22 +02:00
Author
Owner
Copy Link

Force-pushed this to fix a missing comma.

Force-pushed this to fix a missing comma.
rudzik8 commented 2022-05-11 02:05:19 +02:00
First-time contributor
Copy Link

Is this the change you originally intended?

Yes, these two commits.

Thank you for rebasing

> Is this the change you originally intended? Yes, these two commits. Thank you for rebasing
erlehmann commented 2022-05-11 18:50:49 +02:00
Author
Owner
Copy Link

I have verified that this works. Thanks you, @rudzik8!

I have verified that this works. Thanks you, @rudzik8!
erlehmann merged commit 9be33ef9c3 into master 2022-05-11 18:51:07 +02:00
Sign in to join this conversation.
Reviewers
No reviewers
Labels
Clear labels
No items
No Label
Milestone
Clear milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
No Assignees
2 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: erlehmann/bushy_leaves#2
No description provided.
Delete Branch "fix-collision-box-2"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?