epCode/extra_mobs
epCode
/
extra_mobs
4
4
Fork 3
Code Issues 3 Pull Requests Projects Releases Wiki Activity

Use warped fungus on a stick and add mod.conf #1

Merged
epCode merged 4 commits from :master into master 2021-03-24 17:15:28 +01:00
Conversation 15 Commits 4 Files Changed 2 +12 -3
TechDudie commented 2021-03-24 16:14:44 +01:00
Contributor
Copy Link

Here’s a suggestion

Here’s a suggestion
TechDudie added 2 commits 2021-03-24 16:14:45 +01:00
TechDudie commented 2021-03-24 16:15:18 +01:00
Author
Contributor
Copy Link

https://git.minetest.land/TechDudie/mc

https://git.minetest.land/TechDudie/mc
epCode commented 2021-03-24 16:54:53 +01:00
Owner
Copy Link

there's only one problem, There's no such thing in MCL as a warped fungus on a stick.

there's only one problem, There's no such thing in MCL as a warped fungus on a stick.
TechDudie commented 2021-03-24 16:55:53 +01:00
Author
Contributor
Copy Link

True, but it’s added in mc, my own mod.

True, but it’s added in mc, my own mod.
TechDudie commented 2021-03-24 16:56:16 +01:00
Author
Contributor
Copy Link

And p.s.,found a quick bug I need to fix.

And p.s.,found a quick bug I need to fix.
epCode commented 2021-03-24 17:00:07 +01:00
Owner
Copy Link

that's fine, If you say:

if minetest.get_modpath("mc") then
    wield_item = "mc:warped_fungus_stick"
else
    mobs_mc.items.carrot_on_a_stick
 end
that's fine, If you say: ``` if minetest.get_modpath("mc") then wield_item = "mc:warped_fungus_stick" else mobs_mc.items.carrot_on_a_stick end ```
epCode commented 2021-03-24 17:00:33 +01:00
Owner
Copy Link

then it won't be dependent on your mod but will benifit from it.

then it won't be dependent on your mod but will benifit from it.
TechDudie commented 2021-03-24 17:01:05 +01:00
Author
Contributor
Copy Link

Ok, will add. Also, the bug in mc is fixed btw.

Ok, will add. Also, the bug in mc is fixed btw.
TechDudie added 1 commit 2021-03-24 17:05:32 +01:00
TechDudie added 1 commit 2021-03-24 17:06:53 +01:00
TechDudie commented 2021-03-24 17:07:31 +01:00
Author
Contributor
Copy Link

There we go :)

There we go :)
epCode commented 2021-03-24 17:08:29 +01:00
Owner
Copy Link

have you tested? If so and there are no bugs, Then I will (after you remove dependecy to mc) merge into master.

have you tested? If so and there are no bugs, Then I will (after you remove dependecy to mc) merge into master.
TechDudie commented 2021-03-24 17:09:53 +01:00
Author
Contributor
Copy Link

Yes i already removed dependency but I can’t test now, I’ll do so today evening where I am and I’ll let you know the results tommorow

Yes i already removed dependency but I can’t test now, I’ll do so today evening where I am and I’ll let you know the results tommorow
epCode commented 2021-03-24 17:10:43 +01:00
Owner
Copy Link

I will test then.

I will test then.
epCode merged commit 33e907ad29 into master 2021-03-24 17:15:28 +01:00
TechDudie commented 2021-03-24 17:18:07 +01:00
Author
Contributor
Copy Link

Drats, indentation issues.

https://git.minetest.land/epCode/extra_mobs/src/branch/master/strider.lua#L119

Drats, indentation issues. https://git.minetest.land/epCode/extra_mobs/src/branch/master/strider.lua#L119
epCode commented 2021-03-24 17:18:52 +01:00
Owner
Copy Link

I'll fix it.

I'll fix it.
TechDudie commented 2021-03-24 17:20:08 +01:00
Author
Contributor
Copy Link

Strange, when I look at the code the indentation issue is visible, but when I edit it, it is correct...

Strange, when I look at the code the indentation issue is visible, but when I edit it, it is correct...
epCode commented 2021-03-24 17:26:05 +01:00
Owner
Copy Link

it works! (after I fixed somethong)

it works! (after I fixed somethong)
Sign in to join this conversation.
Reviewers
No reviewers
Labels
Clear labels
No items
No Label
Milestone
Clear milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
No Assignees
2 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: epCode/extra_mobs#1
No description provided.
Delete Branch ":master"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?