ancientmarinerdev
  • Joined on 2022-10-03
ancientmarinerdev commented on pull request VoxeLibre/VoxeLibre#3749 2023-05-26 18:43:22 +02:00
Cherry Blossoms

In core, we have the following, that all the main leaves use:

ancientmarinerdev commented on pull request VoxeLibre/VoxeLibre#3749 2023-05-26 18:43:21 +02:00
Cherry Blossoms

Probably don't need this because of:

ancientmarinerdev commented on pull request VoxeLibre/VoxeLibre#3749 2023-05-26 18:43:20 +02:00
Cherry Blossoms

These 3 need to be vector.offset()

ancientmarinerdev commented on pull request VoxeLibre/VoxeLibre#3749 2023-05-26 18:43:20 +02:00
Cherry Blossoms

Probably don't need these 2 lines because of this:

ancientmarinerdev commented on pull request VoxeLibre/VoxeLibre#3749 2023-05-26 18:43:19 +02:00
Cherry Blossoms

Because we're calling this a lot, maybe pull this out of the function so it's created once. Something like:

ancientmarinerdev commented on pull request VoxeLibre/VoxeLibre#3749 2023-05-26 18:43:16 +02:00
Cherry Blossoms

vector.zero()

ancientmarinerdev commented on pull request VoxeLibre/VoxeLibre#3749 2023-05-26 18:43:15 +02:00
Cherry Blossoms

vector.zero()

ancientmarinerdev commented on pull request VoxeLibre/VoxeLibre#3749 2023-05-26 18:43:14 +02:00
Cherry Blossoms

We are changing translations? Did the keys change in the translation files also?

ancientmarinerdev commented on pull request VoxeLibre/VoxeLibre#3653 2023-05-26 17:54:23 +02:00
Add support for external custom skins mod

As an aside, it would be cool to save a custom skin as a name, so you can swap between them later. Opens up later to the concept of exporting and loading perhaps.

ancientmarinerdev commented on pull request VoxeLibre/VoxeLibre#3750 2023-05-26 17:42:23 +02:00
WIP: redesign mcl_mobs' do_env_damage

I've looked at this twice, and I'm struggling a bit. IMHO, this has made the code more complex and not really saved on code. I'm not even sure of the benefit in all honesty. It'll just make it…

ancientmarinerdev commented on pull request VoxeLibre/VoxeLibre#3653 2023-05-26 16:51:34 +02:00
Add support for external custom skins mod

Seems to be working ok from my side, minus a long trousers issue that goes over the top. Looks like those trouses seem to go all the way up the top and be on top of (maybe by rank) the t-shirt.

ancientmarinerdev commented on pull request VoxeLibre/VoxeLibre#3479 2023-05-26 14:43:32 +02:00
Door Fixes & Improvements

Seems to be better for open doors.

ancientmarinerdev commented on pull request VoxeLibre/VoxeLibre#3479 2023-05-26 14:32:05 +02:00
Door Fixes & Improvements

If the top is fixed, the other holes will still have the effect.

There, now the jungle door tops have had the holes closed.


Clearly they are required, but it looks…

ancientmarinerdev suggested changes for VoxeLibre/VoxeLibre#3740 2023-05-26 14:18:54 +02:00
Fix a typo in the Acquire Hardware achievement

Please can you change the key name in the other translation files, please?

ancientmarinerdev commented on pull request VoxeLibre/VoxeLibre#3740 2023-05-26 14:18:27 +02:00
Fix a typo in the Acquire Hardware achievement

Not all. It looks like it'll break the translation for 3 languages.

ancientmarinerdev commented on issue VoxeLibre/VoxeLibre#3569 2023-05-25 16:44:51 +02:00
Consider disabling catch_up for crops

I think this is a duplicate of: #2428

The problem is crop speed, this is one solution that could be considered.

ancientmarinerdev closed issue VoxeLibre/VoxeLibre#3759 2023-05-25 14:33:30 +02:00
bug warning dupper farm
ancientmarinerdev commented on issue VoxeLibre/VoxeLibre#3759 2023-05-25 14:33:27 +02:00
bug warning dupper farm

Duplicate of this: MineClone2/MineClone2#3687

ancientmarinerdev commented on issue VoxeLibre/VoxeLibre#3756 2023-05-23 14:25:18 +02:00
Villagers only spawn for red beds

Don't worry about creating a bug ticket for a bug you've found. You can just put the information in the PR and that is cool :).

ancientmarinerdev commented on pull request VoxeLibre/VoxeLibre#3653 2023-05-23 01:05:52 +02:00
Add support for external custom skins mod

The first image is the result of me commenting out the code that sets the player mesh in mcl_player. The second image is the result of commenting out the code that sets the player mesh and…