Solving ladder placement issues #4596

goodspeed · 2024-08-16T17:31:38+02:00

goodspeed commented

2024-08-16 17:31:38 +02:00

This MR solves two problems:

Ladder can be placed on some non-solid blocks (like anvil, bed, lightning rod etc.) and can't be placed on ice, glass, glowstone and sea lanterns. Confirming to the Minecraft wiki, ladder should be able to be place on solid blocks including ice, glass etc. I think this is pretty reasonable. This behavior also tested on Minecraft 1.19. The solution is to refer to group:solid directly.
The placing sound gets played when the place to be placed with ladder is occupied (and the placing rejected). The old did try to check this occasion but it seems it's wrong. This can be triggered by placing a solid node and a fence (or any node with hole like slabs) in front and click the solid node. See the picture:

Testing

Place the ladder on anvil, bed, lightning rod etc (and also glowstone, ice and sea lantern).
Follow the second picture and right click on the back node of the fence.

This MR solves two problems: 1. Ladder can be placed on some non-solid blocks (like anvil, bed, lightning rod etc.) and can't be placed on ice, glass, glowstone and sea lanterns. Confirming to the Minecraft wiki, ladder should be able to be place on solid blocks including ice, glass etc. I think this is pretty reasonable. This behavior also tested on Minecraft 1.19. The solution is to refer to `group:solid` directly. ![20240816_23h23m03s_grim.png](/attachments/53a1afbf-9a00-4af1-b00d-a07f270ed8f8) 2. The placing sound gets played when the place to be placed with ladder is occupied (and the placing rejected). The old did try to check this occasion but it seems it's wrong. This can be triggered by placing a solid node and a fence (or any node with hole like slabs) in front and click the solid node. See the picture: ![20240816_23h28m27s_grim.png](/attachments/265b51be-f04d-434f-a7fd-fc46aa37a2f1) ### Testing 1. Place the ladder on anvil, bed, lightning rod etc (and also glowstone, ice and sea lantern). 2. Follow the second picture and right click on the back node of the fence.

20240816_23h23m03s_grim.png

236 KiB

20240816_23h28m27s_grim.png

421 KiB

goodspeed changed title from ~~ladder-logic~~ to Solving ladder placement issues

2024-08-16 17:31:58 +02:00

the-real-herowl added the

nodes

Testing / Retest

#P4 priority: medium

labels 2024-08-16 21:55:28 +02:00

the-real-herowl reviewed 2024-08-16 21:56:35 +02:00