VoxeLibre/VoxeLibre
VoxeLibre
/
VoxeLibre
62
134
Fork 179
Code Issues 952 Pull Requests 88 Projects 4 Releases Wiki Activity

WIP: Creative pickblock functionality (fixes #197) #4552

Draft
rudzik8 wants to merge 19 commits from pickblock into master
pull from: pickblock
merge into: VoxeLibre:master
Conversation 6 Commits 19 Files Changed 24 +144 -15
rudzik8 commented 2024-08-01 04:59:27 +02:00
Member
Copy Link

According to Minecraft Wiki:

The player can obtain items using pick block (defaults to middle click on mouse). Unlike Survival, the block selected appears in the player's hotbar even if the block is not already in the hotbar or in the Survival inventory. If it is in the inventory, then the block moves out of its former slot and replaces the block/item in the active hotbar slot, with the size of the stack preserved. If the hotbar is full then the selected block replaces the block/item in the active slot.

Most blocks give the player a copy of themselves when using pick block. Using it on an item frame gives the player the item held inside, or the item frame itself if no item is held. Using it on a mob gives the player a spawn egg of that mob. Using it on a mob head gives the mob type that it is; using it on custom heads gives only the mob type that was used in the command, but without the custom skin.

If the player holds Control and presses pick block, in addition to obtaining the item, it also preserves the block's NBT tags, allowing the player to place an identical copy of the block; this allows the player to duplicate items inside of chests, dispensers, and so on, and also duplicates the text on signs.

Assigning actions to middle-click is impossible in MTE as of 5.9.1, so pickblock functionality is bound to the place key with a bare hand.

  • Basic pointed node pickblock
  • Don't pick nodes that are 'illegal' (not_in_creative_inventory ~= 0)
  • Allow 'illegal' nodes to have a pickblock alias (_vl_pickblock field of node def)
  • Notify the player if a node they're trying to pick is already in their hotbar
    NOTE: As of 5.8.1, MTE doesn't provide an API to change player's selected hotbar slot.
  • Mobs pickblock functionality
  • Mob head pickblock functionality
  • Patch our mods to support pickblock aliases
    • mcl_beds
    • mcl_beehives
    • mcl_brewing
    • mcl_cocoas
    • mcl_chests
    • mcl_doors
    • mcl_farming
    • mcl_flowers
    • mcl_mangrove
    • mcl_ocean
    • mcl_stairs
    • more?

Testing

  1. Load a creative world.
  2. Try picking a block while not holding anything (right-click).
  3. Try picking an 'illegal' block this way (like wheat plant).
  4. Try picking an 'illegal' block that has a pickblock alias (like kelp on sand).
  5. Try picking a block that is already in your hotbar (but on a different slot than your selected one, of course).
According to [Minecraft Wiki](https://minecraft.wiki/w/Creative#Pick_block): > The player can obtain items using *pick block* (defaults to middle click on mouse). Unlike Survival, the block selected appears in the player's hotbar even if the block is not already in the hotbar or in the Survival inventory. If it is in the inventory, then the block moves out of its former slot and replaces the block/item in the active hotbar slot, with the size of the stack preserved. If the hotbar is full then the selected block replaces the block/item in the active slot. > > Most blocks give the player a copy of themselves when using *pick block*. Using it on an item frame gives the player the item held inside, or the item frame itself if no item is held. Using it on a mob gives the player a spawn egg of that mob. Using it on a [mob head](https://minecraft.wiki/w/Mob_head) gives the mob type that it is; using it on custom heads gives only the mob type that was used in the [command](https://minecraft.wiki/w/Command), but without the custom skin. > > If the player holds Control and presses *pick block*, in addition to obtaining the item, it also preserves the block's [NBT tags](https://minecraft.wiki/w/NBT_format), allowing the player to place an identical copy of the block; this allows the player to duplicate items inside of chests, dispensers, and so on, and also duplicates the text on [signs](https://minecraft.wiki/w/Sign). Assigning actions to middle-click is impossible in MTE as of 5.9.1, so pickblock functionality is bound to the place key with a bare hand. - [x] [Basic pointed node pickblock](https://content.minetest.net/packages/ROllerozxa/pickblock/) - [x] Don't pick nodes that are 'illegal' (`not_in_creative_inventory ~= 0`) - [x] Allow 'illegal' nodes to have a pickblock alias (`_vl_pickblock` field of node def) - [x] Notify the player if a node they're trying to pick is already in their hotbar _NOTE: As of 5.8.1, MTE doesn't provide an API to change player's selected hotbar slot._ - [ ] Mobs pickblock functionality - [ ] Mob head pickblock functionality - [x] Patch our mods to support pickblock aliases - [x] `mcl_beds` - [x] `mcl_beehives` - [x] `mcl_brewing` - [x] `mcl_cocoas` - [ ] `mcl_chests` - [x] `mcl_doors` - [x] `mcl_farming` - [x] `mcl_flowers` - [x] `mcl_mangrove` - [x] `mcl_ocean` - [x] `mcl_stairs` - more? ### Testing 1. Load a creative world. 2. Try picking a block while not holding anything (right-click). 3. Try picking an 'illegal' block this way (like wheat plant). 4. Try picking an 'illegal' block that has a pickblock alias (like kelp on sand). 5. Try picking a block that is already in your hotbar (but on a different slot than your selected one, of course).
👍 1
rudzik8 added the
nodes
creative mode
 labels 2024-08-01 04:59:27 +02:00
kneekoo commented 2024-08-01 06:51:56 +02:00
Contributor
Copy Link

Nothing happens for:

  • bee nests having honey: one (without honey?) should be given.
  • slab_*_double: one slab should be given
  • flower pots with anything in them: should give an empty one
  • hanging_propagule: should give a propagule
  • sea pickle: should give one

Would be nice to give:

  • 1 cocoa bean when right-clicking their pods
  • 1 seed when right-clicking crops
Nothing happens for: - bee nests having honey: one *(without honey?)* should be given. - slab_*_double: one slab should be given - flower pots with anything in them: should give an empty one - hanging_propagule: should give a propagule - sea pickle: should give one Would be nice to give: - 1 cocoa bean when right-clicking their pods - 1 seed when right-clicking crops
👍 1
rudzik8 changed title from WIP: Creative pickblock functionality to WIP: Creative pickblock functionality (fixes #197) 2024-08-01 07:02:54 +02:00
the-real-herowl commented 2024-08-01 11:03:44 +02:00
Owner
Copy Link

Wait, we could have that control+pick lock (aux1 + pickblock?) by creating an itemstack from meta of the node, right...?

Wait, we could have that control+pick lock (aux1 + pickblock?) by creating an itemstack from meta of the node, right...?
dindowsfan6 commented 2024-08-02 07:15:32 +02:00
First-time contributor
Copy Link

Make sure it works with item frames as well. Besides, wouldn't it been better idea to do a shortcut key for this?

Make sure it works with item frames as well. Besides, wouldn't it been better idea to do a shortcut key for this?
kneekoo commented 2024-08-02 08:39:21 +02:00
Contributor
Copy Link

Minetest comes with a fixed set of controls, so we can only use those.

Minetest comes with a fixed set of controls, so we can only use those.
👍 1
rudzik8 commented 2024-08-03 09:11:09 +02:00
Author
Member
Copy Link
  • flower pots with anything in them: should give an empty one

Nothing happens with empty flowerpots too. They have an on_rightclick function, and that is logically prioritized over pickblock. That will require more than just a patch with a few one-liners, and I'm afraid I can't afford to do that in this PR, or else it will just become too cluttered.

> * flower pots with anything in them: should give an empty one Nothing happens with empty flowerpots too. They have an `on_rightclick` function, and that is logically prioritized over pickblock. That will require more than just a patch with a few one-liners, and I'm afraid I can't afford to do that in this PR, or else it will just become too cluttered.
the-real-herowl commented 2024-08-06 20:17:37 +02:00
Owner
Copy Link

What if you utilize the zoom key? It's not like it's doing anything with empty hand, and we're hijacking it anyway.

If not alone, then maybe as modifier... so if empty hand is placed, then first it's checked if zoom is pressed, and if it is, then run pickblock functionality and return.

What if you utilize the `zoom` key? It's not like it's doing anything with empty hand, and we're hijacking it anyway. If not alone, then maybe as modifier... so if empty hand is placed, then first it's checked if zoom is pressed, and if it is, then run pickblock functionality and return.
rudzik8 force-pushed pickblock from bd1f86fe4c to 271606cf27 2024-08-18 06:15:05 +02:00 Compare
This pull request has changes conflicting with the target branch.
  • mods/ITEMS/mcl_cocoas/init.lua
  • mods/ITEMS/mcl_farming/beetroot.lua
  • mods/ITEMS/mcl_farming/carrots.lua
  • mods/ITEMS/mcl_farming/melon.lua
  • mods/ITEMS/mcl_farming/potatoes.lua
  • mods/ITEMS/mcl_farming/pumpkin.lua
  • mods/ITEMS/mcl_farming/wheat.lua
Sign in to join this conversation.
Reviewers
No reviewers
Labels
Clear labels   
#P1 CRITICAL

for crashes, catastrophic bugs, etc.

  
#P2: HIGH

highest priority level

  
#P3: elevated

2nd-highest priority level

  
#P4 priority: medium

for things that aren't elevated but have been prioritised

  
#P6: low

low priority level

  
#Review

Tickets that may improve or fix an issue but will need a review after a short period of time

  
annoying

non-bugs that annoys people

  
API

   
bug

   
code quality

   
combat

   
commands

   
compatibility

Label to cover migration issues from old worlds or mcl5

  
configurability

   
contribution inside

   
controls

   
core feature

   
creative mode

   
delayed for engine release

   
documentation

   
duplicate

   
enhancement

enhancement request/suggestion

  
environment

Issues that affect weather or light

  
feature request

   
gameplay

   
graphics

   
ground content conflict

mapgen gc-specific quirks

  
GUI/HUD

   
help wanted

   
incomplete feature

   
invalid / won't fix

Invalid, or will not fix

  
items

   
looking for contributor

   
mapgen

   
meta

Relating to VoxeLibre on Mesehub and elsewhere

  
mineclone2+

fit for MineClone2-Plus

  
Minecraft >= 1.13

   
Minecraft >= 1.17

   
missing feature

   
mobile

involving Minetest on mobile devices (android)

  
mobs

   
mod support

Issues related to mod support

  
model needed

A model is needed to be created or updated

  
multiplayer

Issues affecting multiplayer

  
Needs adoption

PR needs author action or to be adopted so changes can be implemented to get the PR closer to merge

  
needs discussion

   
needs engine change

   
needs more information

   
needs research

   
nodes

   
non-mob entities

   
performance

   
player

issues related to the player

  
possible close

   
redstone

   
release notes

This ticket will need information adding to release notes

  
schematics

   
Skyblock

   
sounds

   
Testing / Retest

This needs testing or retesting

  
tools

Related to the tools scripts, which aren't run in game

  
translation

   
unconfirmed
  
mcl5

Possibly relevant for MineClone5

  
mcla

Possibly relevant for Mineclonia

  
Media missing

media files for this feature are missing - contributions welcome

No Label
#P1 CRITICAL
#P2: HIGH
#P3: elevated
#P4 priority: medium
#P6: low
#Review
annoying
API
bug
code quality
combat
commands
compatibility
configurability
contribution inside
controls
core feature
creative mode
delayed for engine release
documentation
duplicate
enhancement
environment
feature request
gameplay
graphics
ground content conflict
GUI/HUD
help wanted
incomplete feature
invalid / won't fix
items
looking for contributor
mapgen
meta
mineclone2+
Minecraft >= 1.13
Minecraft >= 1.17
missing feature
mobile
mobs
mod support
model needed
multiplayer
Needs adoption
needs discussion
needs engine change
needs more information
needs research
nodes
non-mob entities
performance
player
possible close
redstone
release notes
schematics
Skyblock
sounds
Testing / Retest
tools
translation
unconfirmed
mcl5
mcla
Media missing
Milestone
Clear milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
No Assignees
4 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: VoxeLibre/VoxeLibre#4552
No description provided.
Delete Branch "pickblock"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?