Split bamboo endcap into 2 nodes to avoid transparency issues with plantlike_rooted #4480

WillConker · 2024-07-02T10:39:49+02:00

WillConker commented

2024-07-02 10:39:49 +02:00

There are now 2 nodes in the bamboo endcap: mcl_bamboo:bamboo_endcap (axey group) and mcl_bamboo:bamboo_endcap_top (plantlike drawtype, drops nothing)
I noticed while doing this that the bamboo endcap texture is not very good, but you can't specify multiple texture tiles for allfaces drawtype iiuc

Things I already checked:

removes the mcl_bamboo:bamboo_endcap_top when below block is mined or broken by a chain of bamboo breaking
stops the bamboo endcap node making surrounding nodes transparent

Fixes #4461 There are now 2 nodes in the bamboo endcap: `mcl_bamboo:bamboo_endcap` (axey group) and `mcl_bamboo:bamboo_endcap_top` (plantlike drawtype, drops nothing) I noticed while doing this that the bamboo endcap texture is not very good, but you can't specify multiple texture tiles for `allfaces` drawtype iiuc Things I already checked: - removes the `mcl_bamboo:bamboo_endcap_top` when below block is mined or broken by a chain of bamboo breaking - stops the bamboo endcap node making surrounding nodes transparent

WillConker added 2 commits 2024-07-02 10:39:50 +02:00

6feb28ab75 Split bamboo endcap into 2 nodes to avoid transparency issues with plantlike_rooted

6d435fc0a4 Fixed bamboo endcap top not being removed when bamboo beneath broken

WillConker commented

2024-07-02 10:40:36 +02:00

If this is good to be merged I will remove the comments.

WillConker commented

2024-07-02 15:54:48 +02:00

btw the problem where nodes with "allfaces" drawtype can only have one texture is I think the reason for #4438
Could we fix this with a "nodebox" drawtype https://forum.minetest.net/viewtopic.php?t=7206?

btw the problem where nodes with "allfaces" drawtype can only have one texture is I think the reason for #4438 Could we fix this with a "nodebox" drawtype https://forum.minetest.net/viewtopic.php?t=7206?

seventeenthShulker commented

2024-07-02 17:38:36 +02:00

The new node is currently available in the creative inventory (is this intentional?).

WillConker added 1 commit 2024-07-02 19:37:37 +02:00

3a50194a4e Removed endcap top from creative inventory

WillConker commented

2024-07-02 19:38:41 +02:00

Ok, I removed it; it wasn't intentional.
Should both be left in for decoration? (would have to clean up description)

Ok, I removed it; it wasn't intentional. Should both be left in for decoration? (would have to clean up description)

This pull request doesn't have enough approvals yet. 0 of 1 approvals granted.

You are not authorized to merge this pull request.

Sign in to join this conversation.