Allow Unbreaking to be applied to crossbows via anvil #4449

seventeenthShulker · 2024-06-20T19:22:09+02:00

2024-06-20 19:22:09 +02:00

crossbow was not in the primary field of the Unbreaking enchantment, while (almost?) all other gear is (probably because crossbows are newer than this definition).

(Don't know if we actually need to list all tools/weapons; there seem to be groups for tool...)

I could previously not add Unbreaking to any crossbow via the anvil. There are no enchantments that are mutually exclusive with Unbreaking.

Testing

Add any level of Unbreaking to a crossbow with no enchants, a crossbow that already has unbreaking etc. and it should combine as expected.

`crossbow` was not in the `primary` field of the Unbreaking enchantment, while (almost?) all other gear is (probably because crossbows are newer than this definition). (Don't know if we actually need to list all tools/weapons; there seem to be groups for `tool`...) I could previously not add Unbreaking to any crossbow via the anvil. There are no enchantments that are mutually exclusive with Unbreaking. ### Testing Add any level of Unbreaking to a crossbow with no enchants, a crossbow that already has unbreaking etc. and it should combine as expected.

seventeenthShulker added 1 commit 2024-06-20 19:22:10 +02:00

d3f3697441 Allow Unbreaking to be applied to crossbows

the-real-herowl commented

2024-06-20 19:39:25 +02:00

Considering incoming things like #4261, it'd be prudent to focus on groups like tool, weapon, armor, or such, as you said.

seventeenthShulker added 1 commit 2024-06-20 22:25:03 +02:00

060ad9474c Use `weapon` group in enchantment def.

seventeenthShulker commented

2024-06-20 22:26:18 +02:00

weapon also includes the Shepherd Staff, but this was already in the secondary list via the tool group.

`weapon` also includes the Shepherd Staff, but this was already in the `secondary` list via the `tool` group.

rudzik8 added the