Fixed creative.lua invalidating iterator in loop #4354

the-real-herowl · 2024-06-02T00:52:45+02:00

the-real-herowl commented

2024-06-02 00:52:45 +02:00

Alternative to #4341 (fixes #4339).

Background

Somehow, call to tt.reload_itemstack_description() invalidates iterators to minetest.registered_items, which are used internally by pairs() in the for loop in creative.lua which fills the creative inventory with items. While I haven't managed to pinpoint where exactly the aforementioned function invalidates the iterators, abstracting the calls into another loop running through the already picked inventory lists (which doesn't rely on iterators to minetest.registered_items) fixes the issue.

Testing

See the referenced issue and PR.

Alternative to #4341 (fixes #4339). ### Background Somehow, call to `tt.reload_itemstack_description()` invalidates iterators to `minetest.registered_items`, which are used internally by `pairs()` in the `for` loop in creative.lua which fills the creative inventory with items. While I haven't managed to pinpoint where exactly the aforementioned function invalidates the iterators, abstracting the calls into another loop running through the already picked inventory lists (which doesn't rely on iterators to `minetest.registered_items`) fixes the issue. ### Testing See the referenced issue and PR.

the-real-herowl added this to the 0.87.1 milestone 2024-06-02 00:52:45 +02:00

the-real-herowl added the

#P3: elevated

label 2024-06-02 00:52:46 +02:00

the-real-herowl added 1 commit 2024-06-02 00:52:47 +02:00

64fa5282ac Fixed creative.lua invalidating iterator in loop

the-real-herowl added 1 commit 2024-06-02 01:45:02 +02:00

973d72b79d Added code comments

the-real-herowl referenced this pull request

2024-06-02 01:46:54 +02:00

Workaround pairs(minetest.registered_items) not working as expected #4341

teknomunk commented