Changes on slab placement checks #4317
No reviewers
Labels
No Label
#P1 CRITICAL
#P2: HIGH
#P3: elevated
#P4 priority: medium
#P6: low
#Review
annoying
API
bug
code quality
combat
commands
compatibility
configurability
contribution inside
controls
core feature
creative mode
delayed for engine release
documentation
duplicate
enhancement
environment
feature request
gameplay
graphics
ground content conflict
GUI/HUD
help wanted
incomplete feature
invalid / won't fix
items
looking for contributor
mapgen
meta
mineclone2+
Minecraft >= 1.13
Minecraft >= 1.17
missing feature
mobile
mobs
mod support
model needed
multiplayer
Needs adoption
needs discussion
needs engine change
needs more information
needs research
nodes
non-mob entities
performance
player
possible close
redstone
release notes
schematics
Skyblock
sounds
Testing / Retest
tools
translation
unconfirmed
mcl5
mcla
Media missing
No Milestone
No project
No Assignees
4 Participants
Notifications
Due Date
No due date set.
Dependencies
No dependencies set.
Reference: VoxeLibre/VoxeLibre#4317
Loading…
Reference in New Issue
No description provided.
Delete Branch ":slab_placement"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
Fixes #4316
Testing
Try to place slabs in every way possible.
d14f708cd2
tof3829e9cc9
f3829e9cc9
to82d1399e4f
82d1399e4f
to6f129aabb1
One thing I noticed while playing with this merged into my local preview branch is that if you have a slab on the upper half of a node, then place another slab above it, the new slab is unexpectedly placed on the bottom of the other slab.
794e1cdcd0
tobe42f4283c
be42f4283c
tod8f538ddee
d8f538ddee
to87b7d72022
87b7d72022
to1fe6472cb8
1fe6472cb8
to1bc0358db8
Very nice! This worked properly in my testing. :)
Side question: does anyone know if there's a reason not to allow combining different kinds of slabs in the same block space? Minecraft doesn't allow it, but I wonder why.
From my point of view it seems very difficult to implement.
It would involve making a node for every possible pair of slab types. Probably not feasible.
Exactly
1bc0358db8
tocb082d4fa8
cb082d4fa8
to67649500ef
67649500ef
to19bec4c8aa
19bec4c8aa
tofd49070456
fd49070456
tod58033753d
d58033753d
to33562ca447
33562ca447
toaf462bb296
af462bb296
tod7bb6ec2d6
d7bb6ec2d6
toae1c01196d
At first, I was worried about the protection check part getting removed, but after testing this with Areas and Protection Redo, this seems fine.
Tested in-game, fixes the issue. Approved.
ae1c01196d
tod8a4b58b86
d8a4b58b86
to07bb6dba1e
07bb6dba1e
to4e9647fccc