VoxeLibre/VoxeLibre
VoxeLibre
/
VoxeLibre
56
133
Fork 173
Code Issues 935 Pull Requests 78 Projects 4 Releases Wiki Activity

Changes on slab placement checks #4317

Open
JoseDouglas26 wants to merge 2 commits from JoseDouglas26/MineClone2:slab_placement into master
pull from: JoseDouglas26/MineClone2:slab_placement
merge into: VoxeLibre:master
Conversation 5 Commits 2 Files Changed 1 +28 -15
JoseDouglas26 commented 2024-05-22 23:15:30 +02:00
Contributor
Copy Link

Fixes #4316

Testing

Try to place slabs in every way possible.

Fixes #4316 ### Testing Try to place slabs in every way possible.
JoseDouglas26 force-pushed slab_placement from d14f708cd2 to f3829e9cc9 2024-05-22 23:15:51 +02:00 Compare
teknomunk added the
nodes
 label 2024-05-24 05:27:02 +02:00
JoseDouglas26 force-pushed slab_placement from f3829e9cc9 to 82d1399e4f 2024-05-24 16:26:28 +02:00 Compare
JoseDouglas26 force-pushed slab_placement from 82d1399e4f to 6f129aabb1 2024-05-24 23:16:53 +02:00 Compare
teknomunk commented 2024-05-25 00:24:35 +02:00
Member
Copy Link

One thing I noticed while playing with this merged into my local preview branch is that if you have a slab on the upper half of a node, then place another slab above it, the new slab is unexpectedly placed on the bottom of the other slab.

One thing I noticed while playing with this merged into my local preview branch is that if you have a slab on the upper half of a node, then place another slab above it, the new slab is unexpectedly placed on the bottom of the other slab.
JoseDouglas26 added 1 commit 2024-05-25 01:11:22 +02:00
JoseDouglas26 force-pushed slab_placement from 794e1cdcd0 to be42f4283c 2024-05-25 13:25:40 +02:00 Compare
JoseDouglas26 force-pushed slab_placement from be42f4283c to d8f538ddee 2024-05-25 17:19:48 +02:00 Compare
JoseDouglas26 force-pushed slab_placement from d8f538ddee to 87b7d72022 2024-05-26 17:57:34 +02:00 Compare
JoseDouglas26 force-pushed slab_placement from 87b7d72022 to 1fe6472cb8 2024-05-26 18:50:50 +02:00 Compare
JoseDouglas26 force-pushed slab_placement from 1fe6472cb8 to 1bc0358db8 2024-05-30 16:10:33 +02:00 Compare
kneekoo commented 2024-05-30 23:06:28 +02:00
Contributor
Copy Link

Very nice! This worked properly in my testing. :)

Side question: does anyone know if there's a reason not to allow combining different kinds of slabs in the same block space? Minecraft doesn't allow it, but I wonder why.

Very nice! This worked properly in my testing. :) Side question: does anyone know if there's a reason not to allow combining different kinds of slabs in the same block space? Minecraft doesn't allow it, but I wonder why.
JoseDouglas26 commented 2024-05-31 00:06:43 +02:00
Author
Contributor
Copy Link

Side question: does anyone know if there's a reason not to allow combining different kinds of slabs in the same block space? Minecraft doesn't allow it, but I wonder why.

From my point of view it seems very difficult to implement.

> Side question: does anyone know if there's a reason not to allow combining different kinds of slabs in the same block space? Minecraft doesn't allow it, but I wonder why. From my point of view it seems very difficult to implement.
teknomunk commented 2024-05-31 01:59:47 +02:00
Member
Copy Link

It would involve making a node for every possible pair of slab types. Probably not feasible.

It would involve making a node for every possible pair of slab types. Probably not feasible.
JoseDouglas26 commented 2024-05-31 09:37:25 +02:00
Author
Contributor
Copy Link

Exactly

Exactly
JoseDouglas26 force-pushed slab_placement from 1bc0358db8 to cb082d4fa8 2024-05-31 12:12:22 +02:00 Compare
teknomunk added this to the 0.88.0 milestone 2024-05-31 13:30:14 +02:00
JoseDouglas26 force-pushed slab_placement from cb082d4fa8 to 67649500ef 2024-06-02 07:55:18 +02:00 Compare
JoseDouglas26 force-pushed slab_placement from 67649500ef to 19bec4c8aa 2024-06-08 00:46:45 +02:00 Compare
JoseDouglas26 force-pushed slab_placement from 19bec4c8aa to fd49070456 2024-06-10 22:22:17 +02:00 Compare
JoseDouglas26 force-pushed slab_placement from fd49070456 to d58033753d 2024-06-11 19:27:27 +02:00 Compare
JoseDouglas26 force-pushed slab_placement from d58033753d to 33562ca447 2024-06-12 13:07:20 +02:00 Compare
JoseDouglas26 force-pushed slab_placement from 33562ca447 to af462bb296 2024-06-12 16:34:24 +02:00 Compare
JoseDouglas26 force-pushed slab_placement from af462bb296 to d7bb6ec2d6 2024-06-13 15:32:36 +02:00 Compare
JoseDouglas26 force-pushed slab_placement from d7bb6ec2d6 to ae1c01196d 2024-06-15 11:22:22 +02:00 Compare
rudzik8 approved these changes 2024-06-17 07:39:37 +02:00
rudzik8 left a comment
Member
Copy Link

At first, I was worried about the protection check part getting removed, but after testing this with Areas and Protection Redo, this seems fine.

Tested in-game, fixes the issue. Approved.

At first, I was worried about the protection check part getting removed, but after testing this with Areas and Protection Redo, this seems fine. Tested in-game, fixes the issue. Approved.
JoseDouglas26 force-pushed slab_placement from ae1c01196d to d8a4b58b86 2024-06-17 10:06:50 +02:00 Compare
JoseDouglas26 force-pushed slab_placement from d8a4b58b86 to 07bb6dba1e 2024-06-24 00:06:55 +02:00 Compare
JoseDouglas26 force-pushed slab_placement from 07bb6dba1e to 4e9647fccc 2024-06-24 15:50:45 +02:00 Compare
This pull request can be merged automatically.
You are not authorized to merge this pull request.
Sign in to join this conversation.
Reviewers
No reviewers
rudzik8
Labels
Clear labels   
#P1 CRITICAL

for crashes, catastrophic bugs, etc.

  
#P2: HIGH

highest priority level

  
#P3: elevated

2nd-highest priority level

  
#P4 priority: medium

for things that aren't elevated but have been prioritised

  
#P6: low

low priority level

  
#Review

Tickets that may improve or fix an issue but will need a review after a short period of time

  
annoying

non-bugs that annoys people

  
API

   
bug

   
code quality

   
combat

   
commands

   
compatibility

Label to cover migration issues from old worlds or mcl5

  
configurability

   
contribution inside

   
controls

   
core feature

   
creative mode

   
delayed for engine release

   
documentation

   
duplicate

   
enhancement

enhancement request/suggestion

  
environment

Issues that affect weather or light

  
gameplay

   
graphics

   
ground content conflict

mapgen gc-specific quirks

  
GUI/HUD

   
help wanted

   
incomplete feature

   
invalid / won't fix

Invalid, or will not fix

  
items

   
looking for contributor

   
mapgen

   
meta

Relating to VoxeLibre on Mesehub and elsewhere

  
mineclone2+

fit for MineClone2-Plus

  
Minecraft >= 1.13

   
Minecraft >= 1.17

   
missing feature

   
mobile

involving Minetest on mobile devices (android)

  
mobs

   
mod support

Issues related to mod support

  
model needed

A model is needed to be created or updated

  
multiplayer

Issues affecting multiplayer

  
Needs adoption

PR needs author action or to be adopted so changes can be implemented to get the PR closer to merge

  
needs discussion

   
needs engine change

   
needs more information

   
needs research

   
nodes

   
non-Minecraft feature

   
non-mob entities

   
performance

   
player

issues related to the player

  
possible close

   
redstone

   
release notes

This ticket will need information adding to release notes

  
schematics

   
Skyblock

   
sounds

   
Testing / Retest

This needs testing or retesting

  
tools

Related to the tools scripts, which aren't run in game

  
translation

   
unconfirmed
  
mcl5

Possibly relevant for MineClone5

  
mcla

Possibly relevant for Mineclonia

  
Media missing

media files for this feature are missing - contributions welcome

No Label
#P1 CRITICAL
#P2: HIGH
#P3: elevated
#P4 priority: medium
#P6: low
#Review
annoying
API
bug
code quality
combat
commands
compatibility
configurability
contribution inside
controls
core feature
creative mode
delayed for engine release
documentation
duplicate
enhancement
environment
gameplay
graphics
ground content conflict
GUI/HUD
help wanted
incomplete feature
invalid / won't fix
items
looking for contributor
mapgen
meta
mineclone2+
Minecraft >= 1.13
Minecraft >= 1.17
missing feature
mobile
mobs
mod support
model needed
multiplayer
Needs adoption
needs discussion
needs engine change
needs more information
needs research
nodes
non-Minecraft feature
non-mob entities
performance
player
possible close
redstone
release notes
schematics
Skyblock
sounds
Testing / Retest
tools
translation
unconfirmed
mcl5
mcla
Media missing
Milestone
Clear milestone
No items
No Milestone
0.88.0
Projects
Clear projects
No project
Assignees
Clear assignees
No Assignees
4 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: VoxeLibre/VoxeLibre#4317
No description provided.
Delete Branch "JoseDouglas26/MineClone2:slab_placement"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?