Changes on slab placement checks #4317

Merged
the-real-herowl merged 2 commits from :slab_placement into master 2024-07-31 00:11:24 +02:00
First-time contributor

Fixes #4316

Testing

Try to place slabs in every way possible.

Fixes #4316 ### Testing Try to place slabs in every way possible.
Ghost force-pushed slab_placement from d14f708cd2 to f3829e9cc9 2024-05-22 23:15:51 +02:00 Compare
teknomunk added the
nodes
label 2024-05-24 05:27:02 +02:00
Ghost force-pushed slab_placement from f3829e9cc9 to 82d1399e4f 2024-05-24 16:26:28 +02:00 Compare
Ghost force-pushed slab_placement from 82d1399e4f to 6f129aabb1 2024-05-24 23:16:53 +02:00 Compare
Member

One thing I noticed while playing with this merged into my local preview branch is that if you have a slab on the upper half of a node, then place another slab above it, the new slab is unexpectedly placed on the bottom of the other slab.

One thing I noticed while playing with this merged into my local preview branch is that if you have a slab on the upper half of a node, then place another slab above it, the new slab is unexpectedly placed on the bottom of the other slab.
Ghost force-pushed slab_placement from 794e1cdcd0 to be42f4283c 2024-05-25 13:25:40 +02:00 Compare
Ghost force-pushed slab_placement from be42f4283c to d8f538ddee 2024-05-25 17:19:48 +02:00 Compare
Ghost force-pushed slab_placement from d8f538ddee to 87b7d72022 2024-05-26 17:57:34 +02:00 Compare
Ghost force-pushed slab_placement from 87b7d72022 to 1fe6472cb8 2024-05-26 18:50:50 +02:00 Compare
Ghost force-pushed slab_placement from 1fe6472cb8 to 1bc0358db8 2024-05-30 16:10:33 +02:00 Compare
Contributor

Very nice! This worked properly in my testing. :)

Side question: does anyone know if there's a reason not to allow combining different kinds of slabs in the same block space? Minecraft doesn't allow it, but I wonder why.

Very nice! This worked properly in my testing. :) Side question: does anyone know if there's a reason not to allow combining different kinds of slabs in the same block space? Minecraft doesn't allow it, but I wonder why.
Author
First-time contributor

Side question: does anyone know if there's a reason not to allow combining different kinds of slabs in the same block space? Minecraft doesn't allow it, but I wonder why.

From my point of view it seems very difficult to implement.

> Side question: does anyone know if there's a reason not to allow combining different kinds of slabs in the same block space? Minecraft doesn't allow it, but I wonder why. From my point of view it seems very difficult to implement.
Member

It would involve making a node for every possible pair of slab types. Probably not feasible.

It would involve making a node for every possible pair of slab types. Probably not feasible.
Author
First-time contributor

Exactly

Exactly
Ghost force-pushed slab_placement from 1bc0358db8 to cb082d4fa8 2024-05-31 12:12:22 +02:00 Compare
teknomunk added this to the 0.88.0 – Back on Track milestone 2024-05-31 13:30:14 +02:00
Ghost force-pushed slab_placement from cb082d4fa8 to 67649500ef 2024-06-02 07:55:18 +02:00 Compare
Ghost force-pushed slab_placement from 67649500ef to 19bec4c8aa 2024-06-08 00:46:45 +02:00 Compare
Ghost force-pushed slab_placement from 19bec4c8aa to fd49070456 2024-06-10 22:22:17 +02:00 Compare
Ghost force-pushed slab_placement from fd49070456 to d58033753d 2024-06-11 19:27:27 +02:00 Compare
Ghost force-pushed slab_placement from d58033753d to 33562ca447 2024-06-12 13:07:20 +02:00 Compare
Ghost force-pushed slab_placement from 33562ca447 to af462bb296 2024-06-12 16:34:24 +02:00 Compare
Ghost force-pushed slab_placement from af462bb296 to d7bb6ec2d6 2024-06-13 15:32:36 +02:00 Compare
Ghost force-pushed slab_placement from d7bb6ec2d6 to ae1c01196d 2024-06-15 11:22:22 +02:00 Compare
rudzik8 approved these changes 2024-06-17 07:39:37 +02:00
rudzik8 left a comment
Member

At first, I was worried about the protection check part getting removed, but after testing this with Areas and Protection Redo, this seems fine.

Tested in-game, fixes the issue. Approved.

At first, I was worried about the protection check part getting removed, but after testing this with Areas and Protection Redo, this seems fine. Tested in-game, fixes the issue. Approved.
Ghost force-pushed slab_placement from ae1c01196d to d8a4b58b86 2024-06-17 10:06:50 +02:00 Compare
Ghost force-pushed slab_placement from d8a4b58b86 to 07bb6dba1e 2024-06-24 00:06:55 +02:00 Compare
Ghost force-pushed slab_placement from 07bb6dba1e to 4e9647fccc 2024-06-24 15:50:45 +02:00 Compare
the-real-herowl merged commit f7ee3b59d7 into master 2024-07-31 00:11:24 +02:00
Sign in to join this conversation.
No reviewers
No project
No Assignees
4 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: VoxeLibre/VoxeLibre#4317
No description provided.