Several improvements to the Shield #4294

Open
loveaabb wants to merge 5 commits from loveaabb/VoxeLibre:master into master
First-time contributor

changes:

  1. removed the limitation to block while pointing a node wielding an item
  2. check whether the player is pointing to a node defined with right-click Formspec (to avoid the formspec bug while blocking) and whether the player is wielding a node (to avoid continous node placing not functioning) before blocking
  3. decreased the interval between right click and block

#3156

changes: 1. removed the limitation to block while pointing a node wielding an item 2. check whether the player is pointing to a node defined with right-click Formspec (to avoid the formspec bug while blocking) and whether the player is wielding a node (to avoid continous node placing not functioning) before blocking 3. decreased the interval between right click and block <!-- Please follow our contributing guidelines first: https://git.minetest.land/MineClone2/MineClone2/src/branch/master/CONTRIBUTING.md#how-you-can-help-as-a-programmer By submitting this pull request, you agree to follow our Code of Conduct: https://git.minetest.land/MineClone2/MineClone2/src/branch/master/CODE_OF_CONDUCT.md --> ### Related Issues https://git.minetest.land/VoxeLibre/VoxeLibre/issues/3156
loveaabb added 1 commit 2024-05-16 18:42:49 +02:00
50fda3e844 Several improvements to the Shield
changes:
1. removed the limitation to block while pointing a node wielding an item
2. check whether the player is pointing to a node defined with right-click Formspec (to avoid the formspec bug while blocking) and whether the player is wielding a node (to avoid continous node placing not functioning) before blocking
3. decreased the interval between right click and block
the-real-herowl added the
gameplay
items
combat
#P4 priority: medium
player
labels 2024-05-17 07:46:27 +02:00
loveaabb reviewed 2024-05-18 17:01:47 +02:00
@ -254,0 +256,4 @@
end
local function is_rmb_conflicting_node(nodename)
nodedef = minetest.registered_nodes[nodename]
Author
First-time contributor

nodedef should be local

nodedef should be local
loveaabb marked this conversation as resolved
loveaabb added 1 commit 2024-05-18 17:15:47 +02:00
loveaabb added 1 commit 2024-05-18 17:21:44 +02:00
19190d92e7 revert f50ef6b52a
revert 更新 mods/ITEMS/mcl_shields/init.lua

change commit info
loveaabb added 1 commit 2024-05-18 17:25:07 +02:00
loveaabb added 1 commit 2024-05-24 03:39:15 +02:00
the-real-herowl added this to the 0.88.0 milestone 2024-06-03 18:21:45 +02:00
This pull request doesn't have enough approvals yet. 0 of 1 approvals granted.
This branch is out-of-date with the base branch
You are not authorized to merge this pull request.
Sign in to join this conversation.
No reviewers
No Milestone
No project
No Assignees
1 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: VoxeLibre/VoxeLibre#4294
No description provided.