VoxeLibre/VoxeLibre
VoxeLibre
/
VoxeLibre
62
134
Fork 181
Code Issues 955 Pull Requests 92 Projects 4 Releases Wiki Activity

Add MC hold to eat delay #4144

Merged
the-real-herowl merged 19 commits from Eliy21/MineClone2:eating_delay into master 2024-01-25 03:06:18 +01:00
Conversation 35 Commits 19 Files Changed 10 +460 -56
Eliy21 commented 2024-01-15 07:44:55 +01:00
Contributor
Copy Link

Fixes #3256

Testing

-Test eating foods by holding right-click or holding a double tap on touchscreen. (Make sure your hunger bar is not full)
-Test eating cakes, potions, golden apples, milk buckets and sus stew
-Test on creative and survival
-Test the mcl_eating_delay in settings

<!-- Please follow our contributing guidelines first: https://git.minetest.land/MineClone2/MineClone2/src/branch/master/CONTRIBUTING.md#how-you-can-help-as-a-programmer By submitting this pull request, you agree to follow our Code of Conduct: https://git.minetest.land/MineClone2/MineClone2/src/branch/master/CODE_OF_CONDUCT.md --> Fixes #3256 ### Testing -Test eating foods by holding right-click or holding a double tap on touchscreen. (Make sure your hunger bar is not full) -Test eating cakes, potions, golden apples, milk buckets and sus stew -Test on creative and survival -Test the mcl_eating_delay in settings
Eliy21 commented 2024-01-15 07:51:41 +01:00
Author
Contributor
Copy Link

This pull request has changes conflicting with the target branch.

  • settingtypes.txt

Oh crap. Please help. I allowed edits to PR if that can help. Otherwise I'll just remake the branch and PR without the settingtypes.txt as everything else is functional.

> This pull request has changes conflicting with the target branch. > > * settingtypes.txt Oh crap. Please help. I allowed edits to PR if that can help. Otherwise I'll just remake the branch and PR without the settingtypes.txt as everything else is functional.
Impulse commented 2024-01-15 08:05:49 +01:00
Member
Copy Link

Looks good!, just like MC. Question, Is the default delay the exact same as in MC?

Looks good!, just like MC. Question, Is the default delay the exact same as in MC?
the-real-herowl commented 2024-01-15 08:06:41 +01:00
Owner
Copy Link

This pull request has changes conflicting with the target branch.

  • settingtypes.txt

Oh crap. Please help. I allowed edits to PR if that can help. Otherwise I'll just remake the branch and PR without the settingtypes.txt as everything else is functional.

Pull the branch and apply the settings change again.

> > This pull request has changes conflicting with the target branch. > > > > * settingtypes.txt > > Oh crap. Please help. I allowed edits to PR if that can help. Otherwise I'll just remake the branch and PR without the settingtypes.txt as everything else is functional. Pull the branch and apply the settings change again.
Impulse commented 2024-01-15 08:07:17 +01:00
Member
Copy Link

This pull request has changes conflicting with the target branch.

  • settingtypes.txt

Oh crap. Please help. I allowed edits to PR if that can help. Otherwise I'll just remake the branch and PR without the settingtypes.txt as everything else is functional.

I can help!
Let me get setup.

> > This pull request has changes conflicting with the target branch. > > > > * settingtypes.txt > > Oh crap. Please help. I allowed edits to PR if that can help. Otherwise I'll just remake the branch and PR without the settingtypes.txt as everything else is functional. I can help! Let me get setup.
Eliy21 commented 2024-01-15 08:08:38 +01:00
Author
Contributor
Copy Link

Looks good!, just like MC. Question, Is the default delay the exact same as in MC?

Yes. https://minecraft.wiki/w/Food#Usage

Pull the branch and apply the settings change again.

I'll remake the whole thing again. Please wait.

> Looks good!, just like MC. Question, Is the default delay the exact same as in MC? Yes. https://minecraft.wiki/w/Food#Usage > Pull the branch and apply the settings change again. I'll remake the whole thing again. Please wait.
the-real-herowl commented 2024-01-15 08:09:08 +01:00
Owner
Copy Link

Mesehub falling apart again... wait before pulling.

Mesehub falling apart again... wait before pulling.
👍 1
Eliy21 commented 2024-01-15 08:09:43 +01:00
Author
Contributor
Copy Link

I can help!
Let me get setup.

Okay, I'll not remake the whole thing again for now while I wait for your help.

> I can help! > Let me get setup. Okay, I'll not remake the whole thing again for now while I wait for your help.
the-real-herowl commented 2024-01-15 08:09:55 +01:00
Owner
Copy Link

Looks good!, just like MC. Question, Is the default delay the exact same as in MC?

Yes. https://minecraft.wiki/w/Food#Usage

Pull the branch and apply the settings change again.

I'll remake the whole thing again. Please wait.

Don't remake. Just pull master into your branch and add the change.

> > > Looks good!, just like MC. Question, Is the default delay the exact same as in MC? > > Yes. https://minecraft.wiki/w/Food#Usage > > > Pull the branch and apply the settings change again. > > I'll remake the whole thing again. Please wait. Don't remake. Just pull master into your branch and add the change.
Eliy21 commented 2024-01-15 08:11:02 +01:00
Author
Contributor
Copy Link

Mesehub falling apart again... wait before pulling.

Is that why the "Update by rebase" button keeps failing?

>Mesehub falling apart again... wait before pulling. Is that why the "Update by rebase" button keeps failing?
the-real-herowl commented 2024-01-15 08:12:19 +01:00
Owner
Copy Link

Mesehub falling apart again... wait before pulling.

Is that why the "Update by rebase" button keeps failing?

Yeah. It may take a few hours or so until in works properly.

> >Mesehub falling apart again... wait before pulling. > > Is that why the "Update by rebase" button keeps failing? Yeah. It may take a few hours or so until in works properly.
Impulse commented 2024-01-15 08:13:14 +01:00
Member
Copy Link

I can help!
Let me get setup.

Okay, I'll not remake the whole thing again for now while I wait for your help.

umm, how do i make a PR for a repo thats already a fork?
or can you just add me to your repo?

> > > I can help! > > Let me get setup. > > Okay, I'll not remake the whole thing again for now while I wait for your help. umm, how do i make a PR for a repo thats already a fork? or can you just add me to your repo?
Eliy21 commented 2024-01-15 08:15:26 +01:00
Author
Contributor
Copy Link

umm, how do i make a PR for a repo thats already a fork?
or can you just add me to your repo?

I have no idea. It's probably easier if I remake the whole thing.

> umm, how do i make a PR for a repo thats already a fork? > or can you just add me to your repo? I have no idea. It's probably easier if I remake the whole thing.
Eliy21 commented 2024-01-15 08:17:08 +01:00
Author
Contributor
Copy Link

Okay here's my plan. I make an empty branch and make a new PR and then rebase it before doing any commits. Please wait...

Okay here's my plan. I make an empty branch and make a new PR and then rebase it before doing any commits. Please wait...
Impulse commented 2024-01-15 08:19:36 +01:00
Member
Copy Link

Just a question, How long does it take for someone to get write access on this repo @the-real-herowl?
It would be useful so i can work on a PR's branch.

Just a question, How long does it take for someone to get write access on this repo @the-real-herowl? It would be useful so i can work on a PR's branch.
Impulse commented 2024-01-15 08:20:07 +01:00
Member
Copy Link

Okay here's my plan. I make an empty branch and make a new PR and then rebase it before doing any commits. Please wait...

Okay, but i really need to learn how to do that, so i can contribute to other peoples PRs

> Okay here's my plan. I make an empty branch and make a new PR and then rebase it before doing any commits. Please wait... Okay, but i really need to learn how to do that, so i can contribute to other peoples PRs
Eliy21 commented 2024-01-15 08:24:41 +01:00
Author
Contributor
Copy Link

Okay, but i really need to learn how to do that, so i can contribute to other peoples PRs

Um should I wait for you on that. It's fine with me but I already PR'ed the thing. I'm fine either way but I'll just finish the other PR first. I don't mind if I waste my time there.

> Okay, but i really need to learn how to do that, so i can contribute to other peoples PRs Um should I wait for you on that. It's fine with me but I already PR'ed the thing. I'm fine either way but I'll just finish the other PR first. I don't mind if I waste my time there.
Impulse commented 2024-01-15 08:32:21 +01:00
Member
Copy Link

Okay, but i really need to learn how to do that, so i can contribute to other peoples PRs

Um should I wait for you on that. It's fine with me but I already PR'ed the thing. I'm fine either way but I'll just finish the other PR first. I don't mind if I waste my time there.

Can you give me write access to your repo please?
So i can push changes.

I cant figure out how to make a PR on a fork of a fork.

> > Okay, but i really need to learn how to do that, so i can contribute to other peoples PRs > > Um should I wait for you on that. It's fine with me but I already PR'ed the thing. I'm fine either way but I'll just finish the other PR first. I don't mind if I waste my time there. Can you give me write access to your repo please? So i can push changes. I cant figure out how to make a PR on a fork of a fork.
Eliy21 commented 2024-01-15 08:43:40 +01:00
Author
Contributor
Copy Link

Can you give me write access to your repo please?
So i can push changes.

I cant figure out how to make a PR on a fork of a fork.

I don't know how to do that. Can you tell me how?

> Can you give me write access to your repo please? > So i can push changes. > > I cant figure out how to make a PR on a fork of a fork. I don't know how to do that. Can you tell me how?
the-real-herowl commented 2024-01-15 08:58:58 +01:00
Owner
Copy Link

Just a question, How long does it take for someone to get write access on this repo @the-real-herowl?
It would be useful so i can work on a PR's branch.

Write access to regular branches on this repo has no hard cutoff, depends on how we feel about it, some got it after their first PR.

So anyway yes this mean that @Eliy21, you are eligible for it – if you want. You @Impulse not yet. Both of you, join our discord if you want. The link is in the Readme.md file.

Now, returning to the question, @Impulse, write access to regular branches of the repo doesn't grant you access to branches on forks anyway, even if someone ticks the "allow edits..." box.

And while you don't have access to the regular branches of the repo, you can make a PR targeting a branch (even those with master write access sometimes make such PRs, see #4019). You theoretically should be able to make a PR on a fork, but tbh better don't. Better keep it all in one place.

> Just a question, How long does it take for someone to get write access on this repo @the-real-herowl? > It would be useful so i can work on a PR's branch. Write access to regular branches on this repo has no hard cutoff, depends on how we feel about it, some got it after their first PR. So anyway yes this mean that @Eliy21, you are eligible for it – if you want. You @Impulse not yet. Both of you, join our discord if you want. The link is in the Readme.md file. Now, returning to the question, @Impulse, write access to regular branches of the repo doesn't grant you access to branches on forks anyway, even if someone ticks the "allow edits..." box. And while you don't have access to the regular branches of the repo, you can make a PR targeting a branch (even those with master write access sometimes make such PRs, see #4019). You theoretically should be able to make a PR on a fork, but tbh better don't. Better keep it all in one place.
the-real-herowl commented 2024-01-15 09:01:49 +01:00
Owner
Copy Link

@Eliy21 making the second PR for the same thing was unnecessary really over such a small thing.

@Eliy21 making the second PR for the same thing was unnecessary really over such a small thing.
Eliy21 commented 2024-01-15 09:04:50 +01:00
Author
Contributor
Copy Link

Write access to regular branches on this repo has no hard cutoff, depends on how we feel about it, some got it after their first PR.

So anyway yes this mean that @Eliy21, you are eligible for it – if you want. You @Impulse not yet. Both of you, join our discord if you want. The link is in the Readme.md file.

Thank you for the write access offer but I don't trust myself to not accidentally nuke stuff like when I oopsie'd my whole main fork and branches to oblivion. If there's a pressing need for it maybe but for now I'll just gratefully appreciate the thought.

> Write access to regular branches on this repo has no hard cutoff, depends on how we feel about it, some got it after their first PR. > > So anyway yes this mean that @Eliy21, you are eligible for it – if you want. You @Impulse not yet. Both of you, join our discord if you want. The link is in the Readme.md file. Thank you for the write access offer but I don't trust myself to not accidentally nuke stuff like when I oopsie'd my whole main fork and branches to oblivion. If there's a pressing need for it maybe but for now I'll just gratefully appreciate the thought.
Eliy21 commented 2024-01-15 09:06:11 +01:00
Author
Contributor
Copy Link

@Eliy21 making the second PR for the same thing was unnecessary really over such a small thing.

lol sorry

> @Eliy21 making the second PR for the same thing was unnecessary really over such a small thing. lol sorry
Impulse commented 2024-01-15 09:06:56 +01:00
Member
Copy Link

Okay i am ready to push to your fork, fixed it. I just need privs @Eliy21

Okay i am ready to push to your fork, fixed it. I just need privs @Eliy21
Eliy21 commented 2024-01-15 09:08:26 +01:00
Author
Contributor
Copy Link

Okay i am ready to push to your fork, fixed it. I just need privs @Eliy21

How can I do it? Please teach me. @Impulse

> Okay i am ready to push to your fork, fixed it. I just need privs @Eliy21 How can I do it? Please teach me. @Impulse
Impulse commented 2024-01-15 09:17:53 +01:00
Member
Copy Link

Here is the patch file:

These are the instructions @Eliy21

  • git pull your master branch so its updated with upstream
  • Reset the eating_delay branch to master
  • Run git apply /path/to/my_patch.patch
Here is the patch file: These are the instructions @Eliy21 - `git pull` your `master` branch so its updated with `upstream` - Reset the `eating_delay` branch to `master` - Run `git apply /path/to/my_patch.patch`
eating_delay.patch
26 KiB
Eliy21 commented 2024-01-15 09:19:25 +01:00
Author
Contributor
Copy Link

Here is the patch file:

These are the instructions @Eliy21

  • git pull your master branch so its updated with upstream
  • Reset the eating_delay branch to master
  • Run git apply /path/to/my_patch.patch

Um how do I do it in the gui?

> Here is the patch file: > > These are the instructions @Eliy21 > - `git pull` your `master` branch so its updated with `upstream` > - Reset the `eating_delay` branch to `master` > - Run `git apply /path/to/my_patch.patch` Um how do I do it in the gui?
Impulse commented 2024-01-15 09:19:46 +01:00
Member
Copy Link

Okay i am ready to push to your fork, fixed it. I just need privs @Eliy21

How can I do it? Please teach me. @Impulse

Go here and add me and i can push the changed for you:

https://git.minetest.land/Eliy21/MineClone2/settings/collaboration

EDIT: sorry i put wrong url in, now it works.

> > Okay i am ready to push to your fork, fixed it. I just need privs @Eliy21 > > How can I do it? Please teach me. @Impulse Go here and add me and i can push the changed for you: [https://git.minetest.land/Eliy21/MineClone2/settings/collaboration](https://git.minetest.land/Eliy21/MineClone2/settings/collaboration) EDIT: sorry i put wrong url in, now it works.
Eliy21 commented 2024-01-15 09:21:44 +01:00
Author
Contributor
Copy Link

Go here and add me and i can push the changed for you:

https://git.minetest.land/Impulse/Eliy21/settings/collaboration

It says 404:

The page you are trying to reach either does not exist or you are not authorized to view it.

EDIT:

Ohh okay I see it now. Wait...

> Go here and add me and i can push the changed for you: > > [https://git.minetest.land/Impulse/Eliy21/settings/collaboration](https://git.minetest.land/Impulse/Eliy21/settings/collaboration) It says 404: >The page you are trying to reach either does not exist or you are not authorized to view it. EDIT: Ohh okay I see it now. Wait...
Impulse commented 2024-01-15 09:22:22 +01:00
Member
Copy Link

Here is the patch file:

These are the instructions @Eliy21

  • git pull your master branch so its updated with upstream
  • Reset the eating_delay branch to master
  • Run git apply /path/to/my_patch.patch

Um how do I do it in the gui?

I don't think you can do it via a GUI, at least easily. If you add me i can push the changes for you.

> > Here is the patch file: > > > > These are the instructions @Eliy21 > > - `git pull` your `master` branch so its updated with `upstream` > > - Reset the `eating_delay` branch to `master` > > - Run `git apply /path/to/my_patch.patch` > > Um how do I do it in the gui? I don't think you can do it via a GUI, at least easily. If you add me i can push the changes for you.
Eliy21 commented 2024-01-15 09:22:57 +01:00
Author
Contributor
Copy Link

Ok I added you now @Impulse

Ok I added you now @Impulse
Impulse force-pushed eating_delay from e4549d327a to c70ae8e535 2024-01-15 09:45:54 +01:00 Compare
Eliy21 commented 2024-01-15 10:02:00 +01:00
Author
Contributor
Copy Link

@Impulse Did it work properly? When I look at my eating_delay branch it seems like everything got reset. (https://git.minetest.land/Eliy21/MineClone2/src/branch/eating_delay)

@Impulse Did it work properly? When I look at my eating_delay branch it seems like everything got reset. (https://git.minetest.land/Eliy21/MineClone2/src/branch/eating_delay)
Impulse commented 2024-01-15 10:12:13 +01:00
Member
Copy Link

Sorry its taking a while, the patch file has a conflict, i am just fixing it.

Sorry its taking a while, the patch file has a conflict, i am just fixing it.
Eliy21 commented 2024-01-15 10:19:04 +01:00
Author
Contributor
Copy Link

Sorry its taking a while, the patch file has a conflict, i am just fixing it.

Okay I'll leave it all up to you here since I gotta go for now.

> Sorry its taking a while, the patch file has a conflict, i am just fixing it. Okay I'll leave it all up to you here since I gotta go for now.
Impulse commented 2024-01-15 11:11:14 +01:00
Member
Copy Link

Sorry its taking a while, the patch file has a conflict, i am just fixing it.

Okay I'll leave it all up to you here since I gotta go for now.

Fixed it. Was a pa lava, because another commit in master modified the init.lua file as well as the settingtypes.txt and i had to resolve the conflicts. It should be fine now.

Just make sure to run git pull before you push your changes @Eliy21
It reduces these issues.

> > Sorry its taking a while, the patch file has a conflict, i am just fixing it. > > Okay I'll leave it all up to you here since I gotta go for now. Fixed it. Was a pa lava, because another commit in master modified the `init.lua` file as well as the `settingtypes.txt` and i had to resolve the conflicts. It should be fine now. Just make sure to run git pull before you push your changes @Eliy21 It reduces these issues.
Eliy21 commented 2024-01-15 17:10:52 +01:00
Author
Contributor
Copy Link

Fixed it. Was a pa lava, because another commit in master modified the init.lua file as well as the settingtypes.txt and i had to resolve the conflicts. It should be fine now.

Congrats on fixing it. I don't know what a "pa lava" is but I'm glad to be of use even as a Guinea pig. Thank you for helping me with this PR.

Just make sure to run git pull before you push your changes @Eliy21
It reduces these issues.

I don't use git but I'll try to keep that in mind if I ever do use it in the future. Thanks.

> Fixed it. Was a pa lava, because another commit in master modified the `init.lua` file as well as the `settingtypes.txt` and i had to resolve the conflicts. It should be fine now. Congrats on fixing it. I don't know what a "pa lava" is but I'm glad to be of use even as a Guinea pig. Thank you for helping me with this PR. > Just make sure to run git pull before you push your changes @Eliy21 > It reduces these issues. I don't use git but I'll try to keep that in mind if I ever do use it in the future. Thanks.
❤️ 1
Impulse force-pushed eating_delay from c580071ec5 to 2c52c9009f 2024-01-15 18:02:33 +01:00 Compare
the-real-herowl force-pushed eating_delay from 5db662f5ed to 760909f49c 2024-01-20 01:45:21 +01:00 Compare
the-real-herowl added this to the 0.87.0 - Prismatic milestone 2024-01-20 01:53:14 +01:00
the-real-herowl requested changes 2024-01-20 03:25:49 +01:00
mods/ITEMS/mcl_core/craftitems.lua Outdated
@ -183,1 +183,4 @@
local function eat_gapple_delayed(itemstack, placer, pointed_thing)
local function eat_gapple(itemstack, placer, pointed_thing)
the-real-herowl commented 2024-01-20 03:23:04 +01:00
Owner
Copy Link

Gapples have the same issue as milk, duped infinitely with itemframes.

Gapples have the same issue as milk, duped infinitely with itemframes.
Eliy21 commented 2024-01-21 09:48:32 +01:00
Author
Contributor
Copy Link

Done

Done
the-real-herowl marked this conversation as resolved
mods/ITEMS/mcl_mobitems/init.lua Outdated
@ -147,1 +147,4 @@
local function drink_milk_delayed(itemstack, player, pointed_thing)
local function drink_milk(itemstack, player, pointed_thing)
the-real-herowl commented 2024-01-20 03:21:12 +01:00
Owner
Copy Link

Milk bucket gets duplicated when putting it into an item frame. I'll leave it to you to find and patch the cause for now.

Milk bucket gets duplicated when putting it into an item frame. I'll leave it to you to find and patch the cause for now.
Eliy21 commented 2024-01-21 09:48:44 +01:00
Author
Contributor
Copy Link

Done

Done
the-real-herowl marked this conversation as resolved
mods/ITEMS/mcl_sus_stew/init.lua Outdated
@ -79,2 +79,4 @@
end
local function eat_stew_delayed(itemstack, user, pointed_thing)
-- Wrapper for handling mcl_hunger delayed eating
the-real-herowl commented 2024-01-20 03:18:50 +01:00
Owner
Copy Link

This function doesn't handle block right-click function when "placing". This results in not being able to put stews in itemframes, among other things. Look at or utilize the normal code for this maybe.

This function doesn't handle block right-click function when "placing". This results in not being able to put stews in itemframes, among other things. Look at or utilize the normal code for this maybe.
Eliy21 commented 2024-01-21 09:49:04 +01:00
Author
Contributor
Copy Link

Done

Done
the-real-herowl marked this conversation as resolved
mods/PLAYER/mcl_hunger/hunger.lua Outdated
@ -42,0 +48,4 @@
mcl_hunger.eat_internal[name].replace_with_item = replace_with_item
mcl_hunger.eat_internal[name].itemstack = itemstack
mcl_hunger.eat_internal[name].user = user
mcl_hunger.eat_internal[name].pointed_thing = pointed_thing
the-real-herowl commented 2024-01-20 03:10:50 +01:00
Owner
Copy Link

Use table.update() (defined in mcl_util) when changing so many predefined fields in one table in one go.

Use `table.update()` (defined in mcl_util) when changing so many predefined fields in one table in one go.
Eliy21 commented 2024-01-21 09:49:17 +01:00
Author
Contributor
Copy Link

Done

Done
the-real-herowl marked this conversation as resolved
mods/PLAYER/mcl_hunger/init.lua Outdated
@ -187,0 +289,4 @@
end
if not mcl_hunger.eat_internal[player_name].pitch then
mcl_hunger.eat_internal[player_name].pitch = 1 + math.random(-10, 10)*0.005
the-real-herowl commented 2024-01-20 03:12:14 +01:00
Owner
Copy Link

Out of curiosity, where is this formula from?

Out of curiosity, where is this formula from?
Michieal commented 2024-01-21 05:03:55 +01:00
Member
Copy Link

And, can it be documented? Just trying to prevent "magic numbers" as in the future someone will come along, and wonder what the numbers specifically mean. A lot of the code has this, and when we have to do a rewrite it becomes really annoying.

And, can it be documented? Just trying to prevent "magic numbers" as in the future someone will come along, and wonder what the numbers specifically mean. A lot of the code has this, and when we have to do a rewrite it becomes really annoying.
Eliy21 commented 2024-01-21 10:02:19 +01:00
Author
Contributor
Copy Link

The formula was always there before this PR. It was in lines 140 and 171 of /mods/PLAYER/mcl_hunger/hunger.lua previously.

This deals with randomizing the pitch each time a player eats from 0.95 to 1.05 but now that due to this PR the eating behavior will play those consecutively then the code was placed at the start of each eating session so that there is one chosen random pitch for the rest instead of randomizing all the sounds within one eating session.

Of course all of this is negated by the fact that there are two eating sound files that are chosen in random anyways (mcl_hunger_bite.1.ogg and mcl_hunger_bite.2.ogg) but the code is there if in the future the decision to opt for one sound per eating session is chosen.

The formula was always there before this PR. It was in lines 140 and 171 of /mods/PLAYER/mcl_hunger/hunger.lua previously. This deals with randomizing the pitch each time a player eats from 0.95 to 1.05 but now that due to this PR the eating behavior will play those consecutively then the code was placed at the start of each eating session so that there is one chosen random pitch for the rest instead of randomizing all the sounds within one eating session. Of course all of this is negated by the fact that there are **two** eating sound files that are chosen in random anyways (mcl_hunger_bite.1.ogg and mcl_hunger_bite.2.ogg) but the code is there if in the future the decision to opt for one sound per eating session is chosen.
❤️ 1
the-real-herowl marked this conversation as resolved
the-real-herowl added the
items
#P3: elevated
player
 labels 2024-01-20 03:26:39 +01:00
Eliy21 force-pushed eating_delay from 06962ebd95 to 5154dce8d0 2024-01-21 10:03:38 +01:00 Compare
Eliy21 requested review from the-real-herowl 2024-01-21 10:03:54 +01:00
the-real-herowl approved these changes 2024-01-25 03:05:57 +01:00
the-real-herowl merged commit 1175be45fb into master 2024-01-25 03:06:18 +01:00
Sign in to join this conversation.
Reviewers
No reviewers
the-real-herowl
Labels
Clear labels   
#P1 CRITICAL

for crashes, catastrophic bugs, etc.

  
#P2: HIGH

highest priority level

  
#P3: elevated

2nd-highest priority level

  
#P4 priority: medium

for things that aren't elevated but have been prioritised

  
#P6: low

low priority level

  
#Review

Tickets that may improve or fix an issue but will need a review after a short period of time

  
annoying

non-bugs that annoys people

  
API

   
bug

   
code quality

   
combat

   
commands

   
compatibility

Label to cover migration issues from old worlds or mcl5

  
configurability

   
contribution inside

   
controls

   
core feature

   
creative mode

   
delayed for engine release

   
documentation

   
duplicate

   
enhancement

enhancement request/suggestion

  
environment

Issues that affect weather or light

  
feature request

   
gameplay

   
graphics

   
ground content conflict

mapgen gc-specific quirks

  
GUI/HUD

   
help wanted

   
incomplete feature

   
invalid / won't fix

Invalid, or will not fix

  
items

   
looking for contributor

   
mapgen

   
meta

Relating to VoxeLibre on Mesehub and elsewhere

  
mineclone2+

fit for MineClone2-Plus

  
Minecraft >= 1.13

   
Minecraft >= 1.17

   
missing feature

   
mobile

involving Minetest on mobile devices (android)

  
mobs

   
mod support

Issues related to mod support

  
model needed

A model is needed to be created or updated

  
multiplayer

Issues affecting multiplayer

  
Needs adoption

PR needs author action or to be adopted so changes can be implemented to get the PR closer to merge

  
needs discussion

   
needs engine change

   
needs more information

   
needs research

   
nodes

   
non-mob entities

   
performance

   
player

issues related to the player

  
possible close

   
redstone

   
release notes

This ticket will need information adding to release notes

  
schematics

   
Skyblock

   
sounds

   
Testing / Retest

This needs testing or retesting

  
tools

Related to the tools scripts, which aren't run in game

  
translation

   
unconfirmed
  
mcl5

Possibly relevant for MineClone5

  
mcla

Possibly relevant for Mineclonia

  
Media missing

media files for this feature are missing - contributions welcome

No Label
#P1 CRITICAL
#P2: HIGH
#P3: elevated
#P4 priority: medium
#P6: low
#Review
annoying
API
bug
code quality
combat
commands
compatibility
configurability
contribution inside
controls
core feature
creative mode
delayed for engine release
documentation
duplicate
enhancement
environment
feature request
gameplay
graphics
ground content conflict
GUI/HUD
help wanted
incomplete feature
invalid / won't fix
items
looking for contributor
mapgen
meta
mineclone2+
Minecraft >= 1.13
Minecraft >= 1.17
missing feature
mobile
mobs
mod support
model needed
multiplayer
Needs adoption
needs discussion
needs engine change
needs more information
needs research
nodes
non-mob entities
performance
player
possible close
redstone
release notes
schematics
Skyblock
sounds
Testing / Retest
tools
translation
unconfirmed
mcl5
mcla
Media missing
Milestone
Clear milestone
No items
No Milestone
0.87.0 - Prismatic
Projects
Clear projects
No project
Assignees
Clear assignees
No Assignees
4 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: VoxeLibre/VoxeLibre#4144
No description provided.
Delete Branch "Eliy21/MineClone2:eating_delay"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?