Increase shield activation speed #3993

Eliy21 · 2023-11-03T16:20:13+01:00

Eliy21 commented

2023-11-03 16:20:13 +01:00

Increase the responsiveness of shields.

Testing

-In creative get 2 shields and hold right click while shield is in hotbar to see if it activates faster
-Place a shield in the inventory shield slot and hold right click to test if the results are the same
-Get some weapons (e.g. sword) while the shield is in offhand and right click to see if they work
-Get some mob eggs and summon them and test if your shield still protects you from danger (test both offhand and hotbar shielding)

EDIT:
-Also test multiple times (10 or 100 or more) while shield is in hotbar hold right-click the crafting table and the enchanting table and see if the shield HUD gets stuck and blocks the menu preventing you from using these tables.

Increase the responsiveness of shields. ### Testing -In creative get 2 shields and hold right click while shield is in hotbar to see if it activates faster -Place a shield in the inventory shield slot and hold right click to test if the results are the same -Get some weapons (e.g. sword) while the shield is in offhand and right click to see if they work -Get some mob eggs and summon them and test if your shield still protects you from danger (test both offhand and hotbar shielding) EDIT: -Also test multiple times (10 or 100 or more) while shield is in hotbar hold right-click the crafting table and the enchanting table and see if the shield HUD gets stuck and blocks the menu preventing you from using these tables.

Eliy21 force-pushed faster_shielding from 4a2341f26c to ada1e1e0ff

2023-11-03 16:20:38 +01:00

Compare

ancientmarinerdev requested changes 2023-11-03 17:07:32 +01:00

ancientmarinerdev left a comment

Nice piece of investigation and I appreciate the PR.

However, I would probably be against this change right now until we have a resolution for: #2756

Basically shield comes up when you use the crafting table in common play. It is infuriating because it isn't obvious why it happens and took a while for us to figure it out. This would make this happen statistically more. Without a way to cancel blocking when interacting with crafting table and all other blocks with an interface, I would be reluctant for this to go in as it would probably make player experience worse for most.

Nice piece of investigation and I appreciate the PR. However, I would probably be against this change right now until we have a resolution for: #2756 Basically shield comes up when you use the crafting table in common play. It is infuriating because it isn't obvious why it happens and took a while for us to figure it out. This would make this happen statistically more. Without a way to cancel blocking when interacting with crafting table and all other blocks with an interface, I would be reluctant for this to go in as it would probably make player experience worse for most.

Eliy21 commented

2023-11-03 17:17:32 +01:00

@ancientmarinerdev I can't seem to reproduce that bug. Can you give me a step by step? Since with this PR, the shield also deactivates quickly so it might even reduce the likelihood of blocking the crafting table? I'm testing it right now but can't reproduce it.

Eliy21 commented

2023-11-03 17:23:54 +01:00

@ancientmarinerdev The shield seems to not activate when near and at the same time pointing to a node on rightclick so the proper right clicking action happens. If it's not a bother, can you see if you can reproduce that bug using this branch?

Eliy21 commented

2023-11-03 17:40:44 +01:00

Okay for some reason I can now right click while pointing to a near node so I can shield while right clicking the crafting table but the shield automatically disappears when the menu appears so the bug didn't happen.

ancientmarinerdev commented

2023-11-03 18:19:51 +01:00

Okay for some reason I can now right click while pointing to a near node so I can shield while right clicking the crafting table but the shield automatically disappears when the menu appears so the bug didn't happen.

Not on your machine right now. It isn't common, but it's happened to me 8 or 9 times, and for other users also including multiplayer.

It isn't all the time, but does happen enough to be baffling and frustratiing.

> Okay for some reason I can now right click while pointing to a near node so I can shield while right clicking the crafting table but the shield automatically disappears when the menu appears so the bug didn't happen. Not on your machine right now. It isn't common, but it's happened to me 8 or 9 times, and for other users also including multiplayer. It isn't all the time, but does happen enough to be baffling and frustratiing.

Eliy21 commented

2023-11-03 18:27:53 +01:00

If I know what causes it I might see if I can fix it but since the cause seems vague I don't know if I can.

Not on your machine right now. It isn't common, but it's happened to me 8 or 9 times, and for other users also including multiplayer.

If my machine can't reproduce the bug then can you reproduce it on this PR branch?

If I know what causes it I might see if I can fix it but since the cause seems vague I don't know if I can. > Not on your machine right now. It isn't common, but it's happened to me 8 or 9 times, and for other users also including multiplayer. If my machine can't reproduce the bug then can you reproduce it on this PR branch?

Eliy21 added 1 commit 2023-11-03 19:13:16 +01:00

fe139554cb Attempt at preventing the shield HUD from blocking the crafting and enchanting table menu - bug

Eliy21 commented

2023-11-03 19:24:35 +01:00

@ancientmarinerdev I've implemented some additional shield HUD removal line that will hopefully increase the chances of the HUD being purged in case those bug causes were due to globalstep not making it in time and having a gap in closing the HUD before the menu GUI pops out. This also might explain why some machines do or do not encounter this problem often as having a difference resources might make the globalstep less prone to missing those HUD clearing timings.

Eliy21 requested review from ancientmarinerdev 2023-11-03 19:42:58 +01:00

Michieal commented

2023-11-03 20:27:06 +01:00

I've also had this bug happen. And, I am running a pretty decent machine.

A thought for it would be, clear the HUD before interacting with any formspec. As, it can occur on any of them (like the crafting table, inventory, etc.)

I've also had this bug happen. And, I am running a pretty decent machine. A thought for it would be, clear the HUD before interacting with any formspec. As, it can occur on any of them (like the crafting table, inventory, etc.)

the-real-herowl added the

labels 2023-11-03 22:58:37 +01:00

the-real-herowl commented

2023-11-03 23:03:47 +01:00

Rejected. This aggravates the bug mentioned (and no, fe139554cb doesn't fix it, not sure how the bug even happens exactly), isn't that important, and doesn't touch the other ton of issues that we have with shields. One thing this does is making the bug way easier to reproduce, so thank you for that.

The shields' code is a mess, and needs a thorough review, if not rewriting from scratch. I'm currently looking through it to see its state.

Rejected. This aggravates the bug mentioned (and no, fe139554cb doesn't fix it, not sure how the bug even happens exactly), isn't that important, and doesn't touch the other ton of issues that we have with shields. One thing this does is making the bug way easier to reproduce, so thank you for that. The shields' code is a mess, and needs a thorough review, if not rewriting from scratch. I'm currently looking through it to see its state.

👍 1

the-real-herowl closed this pull request

2023-11-03 23:03:51 +01:00

Michieal commented

2023-11-03 23:16:35 +01:00

It needs a serious rewrite. As I have mentioned before, the shield code is a hack because minetest removed the offhand use of items.

Eliy21 commented

2023-11-04 04:14:41 +01:00

It was a shot in the dark trying to fix a bug that I can't see/reproduce. I was going to have a go at it again but if the code is planned to be rewritten then I guess I'll leave it for now.

the-real-herowl referenced this pull request

2023-12-14 22:09:29 +01:00

Crafting/Enchanting interface - can't take crafted item #2756