Add ability for shovels to turn grass paths into dirt on shift+right click #3932

SmokeyDope · 2023-09-11T20:14:40+02:00

SmokeyDope commented

2023-09-11 20:14:40 +02:00

This is a quality of life enhancement that allows players to easily fix misplaced paths by shift+right_clicking with a shovel. Discussion for whether or not this non-vanilla enhancement should be put in happened in and closes #3928 and the consensus reached was that its a good fit.

🎉 3

Codiac requested review from Codiac 2023-09-26 04:16:11 +02:00

Codiac refused to review 2023-09-26 04:16:25 +02:00

Codiac commented

2023-09-26 04:17:26 +02:00

PEBKAC

Hi, I tested this and it functions as described when single clicking.

If you right click and drag then a path is drawn. If you go over a node more than once it has no effect.

If you do the same using shift-right click when you go over a node you have removed a path from it will re-add the path.

I would prefer it if when using shift-click it only removed paths and didn't add them.

PEBKAC Hi, I tested this and it functions as described when single clicking. If you right click and drag then a path is drawn. If you go over a node more than once it has no effect. If you do the same using shift-right click when you go over a node you have removed a path from it will re-add the path. I would prefer it if when using shift-click it only removed paths and didn't add them.

👍 2

chmodsayshello reviewed 2023-10-15 21:29:44 +02:00

mods/ITEMS/mcl_tools/init.lua Outdated

					
				@ -171,2 +171,4 @@

					end

				-- Remove grass paths

					if (minetest.get_item_group(node.name, "path_remove_possible") == 1) and placer:get_player_control().sneak == true then

chmodsayshello commented

2023-10-15 21:29:44 +02:00

Minor nitpick, but is there any particular reason you've used
and placer:get_player_control().sneak == true
instead of just
and placer:get_player_control().sneak

Minor nitpick, but is there any particular reason you've used `and placer:get_player_control().sneak == true` instead of just `and placer:get_player_control().sneak`

the-real-herowl marked this conversation as resolved

the-real-herowl added the

labels 2023-10-16 03:50:57 +02:00

SmokeyDope commented

2023-11-02 13:41:37 +01:00

I currently do not possess the programming ability required to improve the code any further. It took everything I had just to get it working to this point.

I can see now that this PR is not of a high enough code quality to pass for merging into the main game code, and I don't have the skills to polish it to that acceptable point. It is not fair to expect any of the real devs here to fix up my sloppy work either. The mod is up on contentdb for those who would want it. I think its best to close this PR as I have no intentions of working on this farther any time soon.

Im sorry.

I currently do not possess the programming ability required to improve the code any further. It took everything I had just to get it working to this point. I can see now that this PR is not of a high enough code quality to pass for merging into the main game code, and I don't have the skills to polish it to that acceptable point. It is not fair to expect any of the real devs here to fix up my sloppy work either. The mod is up on contentdb for those who would want it. I think its best to close this PR as I have no intentions of working on this farther any time soon. Im sorry.

the-real-herowl added the

Needs adoption

label 2023-11-02 18:30:40 +01:00

the-real-herowl commented

2023-11-02 18:33:43 +01:00

I currently do not possess the programming ability required to improve the code any further. It took everything I had just to get it working to this point.

I can see now that this PR is not of a high enough code quality to pass for merging into the main game code, and I don't have the skills to polish it to that acceptable point. It is not fair to expect any of the real devs here to fix up my sloppy work either. The mod is up on contentdb for those who would want it. I think its best to close this PR as I have no intentions of working on this farther any time soon.

Im sorry.

You did a bunch of work on it though. No need to be sorry. I'll see if I can fix this up later and merge it. Don't close it yet.

> I currently do not possess the programming ability required to improve the code any further. It took everything I had just to get it working to this point. > > I can see now that this PR is not of a high enough code quality to pass for merging into the main game code, and I don't have the skills to polish it to that acceptable point. It is not fair to expect any of the real devs here to fix up my sloppy work either. The mod is up on contentdb for those who would want it. I think its best to close this PR as I have no intentions of working on this farther any time soon. > > Im sorry. You did a bunch of work on it though. No need to be sorry. I'll see if I can fix this up later and merge it. Don't close it yet.

the-real-herowl force-pushed add-dirty-shovel-function from 3be6bf404d to fa1d8dfc47

2023-11-02 18:34:18 +01:00

Compare

the-real-herowl added 1 commit 2023-11-02 20:01:04 +01:00

5b1deedaf0 Disabled grass path making when sneaking

the-real-herowl approved these changes 2023-11-02 20:03:19 +01:00

the-real-herowl left a comment

Fixed it up.

the-real-herowl merged commit 8789411ab7 into master

2023-11-02 20:03:50 +01:00

the-real-herowl referenced this issue from a commit

2023-11-02 20:03:51 +01:00