Correct the names of pumpkins and carved pumpkins. Slightly update their descriptions. #3828
No reviewers
Labels
No Label
#P1 CRITICAL
#P2: HIGH
#P3: elevated
#P4 priority: medium
#P6: low
#Review
annoying
API
bug
code quality
combat
commands
compatibility
configurability
contribution inside
controls
core feature
creative mode
delayed for engine release
documentation
duplicate
enhancement
environment
gameplay
graphics
ground content conflict
GUI/HUD
help wanted
incomplete feature
invalid / won't fix
items
looking for contributor
mapgen
meta
mineclone2+
Minecraft >= 1.13
Minecraft >= 1.17
missing feature
mobile
mobs
mod support
model needed
multiplayer
Needs adoption
needs discussion
needs engine change
needs more information
needs research
nodes
non-Minecraft feature
non-mob entities
performance
player
possible close
redstone
release notes
schematics
Skyblock
sounds
Testing / Retest
tools
translation
unconfirmed
mcl5
mcla
Media missing
No Milestone
No project
No Assignees
6 Participants
Notifications
Due Date
No due date set.
Dependencies
No dependencies set.
Reference: VoxeLibre/VoxeLibre#3828
Loading…
Reference in New Issue
No description provided.
Delete Branch "fix_pumpkin_names"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
'Faceless Pumpkin' has been corrected to 'Pumpkin'.
'Pumpkin' has been corrected to 'Carved Pumpkin'.
their descriptions have been slightly altered.
Fixes #3788
Please update the translation template and remove the changed phrases from all translation files (as they are no longer used)... I could provide new german translations...
Smokey, if you haven't done so already, please remember to put aliases in for the old item names, so that existing worlds won't have broken "Unknown node" / "Unknown Item"s.
how would that be? he didn't change any item names, only descriptions
I could provide new Russian ones too, considering how bad and archaic the current ones are. "Faceless" should not be a word for a pumpkin really, the Russian translation for it means something more like "anonymous", which makes it seem like the pumpkin is some kinda mystical superhero XD
Translations are supposed to reflect the meaning, which can be complicated when you're constrained to short strings. But the target being a description in this case, a pumpkin without a face carved on it is easier to translate than it would be on an item's name. :)
Notes for myself regarding this PR:
all the translation files .tr within the mcl_farming/locale directory need the english pumpkin equivalent text updated.
(old english description) = (description in other language)
change it to
(new english description) = (description in other language)
Translation tool scripts by wuzzy so I dont have to do it by hand:
https://codeberg.org/Wuzzy/minetest_translation_tools
Update the translation files and we're merging this.