Optimise mobs #3720

ancientmarinerdev · 2023-05-12T15:30:29+02:00

ancientmarinerdev commented

2023-05-12 15:30:29 +02:00

Fixes #3686

Optimisations conducted based on profiling from Solo un altro clone

env_danger_movement_checks only called in range now. The mobs are already stopped out of range
can_jump_cliff only called once in the on_step. Can be called multiple times from multiple places so makes sense to set it on the mob and access it that way.
Attack, follow and runaway mob_step functions called 5 times a second now, which is enough without being excessive
Check mob can fly (self.fly) before conducting a self:flight_check() unnecessarily when setting animations
Looking at check ineffectively restricted. Changed this.
Water check was copied from cliff check. Unneccessary duplicated code. Called every mob_step without question. Very expensive. Cliff check is called for attack, and before walking and during attack code. Didn't need to be called again for every state. Also do not execute this code for mobs that aren't affected by water. Don't execute code if already in unsafe water and shouldn't stop.
Only make a mob stand if not standing to avoid unnecessary state calls send to client
If outside of active range, mob shouldn't be made to walk only to stop again.
Falling code cleaned up, and duplicate expensive node_ok call removed
Added some vectors in various code
Mobs less jittery now at edges/water (they used to change yaw in do_states_stand, after cliff danger check and after water change) so would try to change their yaw multiple times a method and on every tick.
check_suspend calls falling which is called twice.

Testing

/spawn_mob llama
/spawn_mob parrot

Do many times. Close game and open, close and open. Check they don't lose their set texture.
Check mobs far away don't move but yaw around
Check mobs close by move
Check mobs still mostly try and stay away from water (still needs to be improved, but efficiently)
Sheep still try to avoid suiciding off posts
Mobs still follow
Mobs runaway
Mobs fight
Mobs still fall out of range

Fixes #3686 Optimisations conducted based on profiling from Solo un altro clone 1. env_danger_movement_checks only called in range now. The mobs are already stopped out of range 2. can_jump_cliff only called once in the on_step. Can be called multiple times from multiple places so makes sense to set it on the mob and access it that way. 3. Attack, follow and runaway mob_step functions called 5 times a second now, which is enough without being excessive 4. Check mob can fly (self.fly) before conducting a self:flight_check() unnecessarily when setting animations 5. Looking at check ineffectively restricted. Changed this. 6. Water check was copied from cliff check. Unneccessary duplicated code. Called every mob_step without question. Very expensive. Cliff check is called for attack, and before walking and during attack code. Didn't need to be called again for every state. Also do not execute this code for mobs that aren't affected by water. Don't execute code if already in unsafe water and shouldn't stop. 7. Only make a mob stand if not standing to avoid unnecessary state calls send to client 8. If outside of active range, mob shouldn't be made to walk only to stop again. 9. Falling code cleaned up, and duplicate expensive node_ok call removed 10. Added some vectors in various code 11. Mobs less jittery now at edges/water (they used to change yaw in do_states_stand, after cliff danger check and after water change) so would try to change their yaw multiple times a method and on every tick. 12. check_suspend calls falling which is called twice. ### Testing /spawn_mob llama /spawn_mob parrot * Do many times. Close game and open, close and open. Check they don't lose their set texture. * Check mobs far away don't move but yaw around * Check mobs close by move * Check mobs still mostly try and stay away from water (still needs to be improved, but efficiently) * Sheep still try to avoid suiciding off posts * Mobs still follow * Mobs runaway * Mobs fight * Mobs still fall out of range

10players.svg

245 KiB